From: Brendan Tildesley <mail@brendan.scot>
To: "Ludovic Courtès" <ludo@gnu.org>,
"Christopher Baines" <mail@cbaines.net>
Cc: 46695@debbugs.gnu.org
Subject: [bug#46695] [PATCH 0/2] Update 0ad to 0.0.24-alpha
Date: Sat, 4 Sep 2021 03:43:04 +0200 (CEST) [thread overview]
Message-ID: <1872927810.103187.1630719784241@office.mailbox.org> (raw)
In-Reply-To: <87tuj1zaaa.fsf@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 739 bytes --]
> On 09/03/2021 10:14 PM Ludovic Courtès <ludo@gnu.org> wrote:
>
>
> Hello,
>
> Christopher Baines <mail@cbaines.net> skribis:
>
> > Work in progress patches to update 0ad, was more complicated than I'd
> > imagined. There are issues with running the tests, and the program also
> > doesn't start properly.
> >
> > Christopher Baines (2):
> > gnu: mozjs-78: Update to 78.6.1.
> > gnu: 0ad-data: Update to 0.0.24-alpha.
>
> This LGTM at first sight, and given the changes Brendan proposed, we
> should be all set?
>
> I’d be more comfortable if you could confirm and apply these, Chris.
>
> Thanks,
> Ludo’.
I have an update for 0.0.25b-alpha. I also added both our copyright notices if that's ok.
[-- Attachment #2: 0001-gnu-0ad-Update-to-0.0.25b-alpha.patch --]
[-- Type: text/x-patch, Size: 10114 bytes --]
From c8c04d24ffabaeecfe00dce05387448999b486e0 Mon Sep 17 00:00:00 2001
From: Brendan Tildesley <mail@brendan.scot>
Date: Thu, 2 Sep 2021 22:54:27 +1000
Subject: [PATCH] gnu: 0ad: Update to 0.0.25b-alpha.
* gnu/packages/games.scm
0ad-data: Update to 0.0.25b-alpha.
Unpack .zip files without need for a snippet.
0ad: Update to 0.0.25b-alpha.
Properly unbundle cxxtest.
Respect #:tests?.
Disable tests for now since they don't run.
Install Freedesktop mimeinfo.
Install icon to hicolor theme instead of share/pixmaps, which I don't
think is used.
---
gnu/packages/games.scm | 87 +++++++++++++++++++++++-------------------
1 file changed, 48 insertions(+), 39 deletions(-)
diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm
index 79754d3185..6658a3a315 100644
--- a/gnu/packages/games.scm
+++ b/gnu/packages/games.scm
@@ -64,6 +64,8 @@
;;; Copyright © 2021 Solene Rapenne <solene@perso.pw>
;;; Copyright © 2021 Noisytoot <noisytoot@disroot.org>
;;; Copyright © 2019 Pkill -9 <pkill9@runbox.com>
+;;; Copyright © 2021 Brendan Tildesley <mail@brendan.scot>
+;;; Copyright © 2021 Christopher Baines <mail@cbaines.net>
;;;
;;; This file is part of GNU Guix.
;;;
@@ -150,6 +152,7 @@
#:use-module (gnu packages less)
#:use-module (gnu packages libcanberra)
#:use-module (gnu packages libedit)
+ #:use-module (gnu packages libidn)
#:use-module (gnu packages libunwind)
#:use-module (gnu packages linux)
#:use-module (gnu packages llvm)
@@ -170,6 +173,7 @@
#:use-module (gnu packages perl-check)
#:use-module (gnu packages perl-compression)
#:use-module (gnu packages pkg-config)
+ #:use-module (gnu packages pretty-print)
#:use-module (gnu packages protobuf)
#:use-module (gnu packages pulseaudio)
#:use-module (gnu packages python)
@@ -6588,7 +6592,7 @@ fight against their plot and save his fellow rabbits from slavery.")
(define-public 0ad-data
(package
(name "0ad-data")
- (version "0.0.23b-alpha")
+ (version "0.0.25b-alpha")
(source
(origin
(method url-fetch)
@@ -6597,20 +6601,10 @@ fight against their plot and save his fellow rabbits from slavery.")
(file-name (string-append name "-" version ".tar.xz"))
(sha256
(base32
- "04x7729hk6zw1xj3n4s4lvaviijsnbjf5rhzvjxlr5fygvg4l6z1"))
- (modules '((guix build utils)))
- (snippet
- #~(begin
- (for-each (lambda (name)
- (let* ((dir (string-append "binaries/data/mods/" name))
- (file (string-append dir "/" name ".zip"))
- (unzip #$(file-append unzip "/bin/unzip")))
- (invoke unzip "-d" dir file)
- (delete-file file)))
- '("mod" "public"))
- #t))))
+ "1c9zrddmjxvvacismld6fbwbw9vrdbq6g6d3424p8w5p6xg5wlwy"))))
(build-system trivial-build-system)
(native-inputs `(("tar" ,tar)
+ ("unzip" ,unzip)
("xz" ,xz)))
(arguments
`(#:modules ((guix build utils))
@@ -6620,10 +6614,17 @@ fight against their plot and save his fellow rabbits from slavery.")
(let ((out (assoc-ref %outputs "out"))
(source (assoc-ref %build-inputs "source"))
(tar (string-append (assoc-ref %build-inputs "tar") "/bin/tar"))
+ (unzip (string-append (assoc-ref %build-inputs "unzip") "/bin/unzip"))
(xz-path (string-append (assoc-ref %build-inputs "xz") "/bin")))
(setenv "PATH" xz-path)
(mkdir out)
- (invoke tar "xvf" source "-C" out "--strip=3")))))
+ (invoke tar "xvf" source "-C" out "--strip=3")
+ (for-each (lambda (name)
+ (let* ((dir (string-append out "/mods/" name))
+ (file (string-append dir "/" name ".zip")))
+ (invoke unzip "-o" "-d" dir file)
+ (delete-file file)))
+ '("mod" "public"))))))
(synopsis "Data files for 0ad")
(description "0ad-data provides the data files required by the game 0ad.")
(home-page "https://play0ad.com")
@@ -6641,7 +6642,7 @@ fight against their plot and save his fellow rabbits from slavery.")
(define-public 0ad
(package
(name "0ad")
- (version "0.0.23b-alpha")
+ (version "0.0.25b-alpha")
(source
(origin
(method url-fetch)
@@ -6650,22 +6651,24 @@ fight against their plot and save his fellow rabbits from slavery.")
(file-name (string-append name "-" version ".tar.xz"))
(sha256
(base32
- "0draa53xg69i5qhqym85658m45xhwkbiimaldj4sr3703rjgggq1"))))
+ "1p9fa8f7sjb9c5wl3mawzyfqvgr614kdkhrj2k4db9vkyisws3fp"))))
;; A snippet here would cause a build failure because of timestamps
;; reset. See https://bugs.gnu.org/26734.
(inputs
`(("0ad-data" ,0ad-data)
("curl" ,curl)
("enet" ,enet)
+ ("fmt" ,fmt)
("gloox" ,gloox)
- ("icu4c" ,icu4c)
+ ("icu4c" ,icu4c-68)
+ ("libidn" ,libidn)
("libpng" ,libpng)
("libsodium" ,libsodium)
("libvorbis" ,libvorbis)
("libxcursor" ,libxcursor)
("libxml2" ,libxml2)
("miniupnpc" ,miniupnpc)
- ("mozjs-38" ,mozjs-38)
+ ("mozjs" ,mozjs-78)
("openal" ,openal)
("sdl2" ,sdl2)
("wxwidgets" ,wxwidgets)
@@ -6673,29 +6676,28 @@ fight against their plot and save his fellow rabbits from slavery.")
(native-inputs
`(("boost" ,boost)
("cmake" ,cmake-minimal)
+ ("cxxtest" ,cxxtest)
("mesa" ,mesa)
("pkg-config" ,pkg-config)
("python-2" ,python-2)))
(build-system gnu-build-system)
(arguments
`(#:make-flags '("config=release" "verbose=1" "-C" "build/workspaces/gcc")
+ #:tests? #f ;; Tests fail currently
#:phases
(modify-phases %standard-phases
(add-after 'unpack 'delete-bundles
- (lambda _
+ (lambda* (#:key inputs #:allow-other-keys)
(delete-file-recursively "libraries/source/spidermonkey")
- #t))
- (add-after 'unpack 'fix-x11-includes
- (lambda _
- (substitute* "source/lib/sysdep/os/unix/x/x.cpp"
- (("<Xlib.h>") "<X11/Xlib.h>"))
- (substitute* "source/lib/sysdep/os/unix/x/x.cpp"
- (("<Xatom.h>") "<X11/Xatom.h>"))
- (substitute* "source/lib/sysdep/os/unix/x/x.cpp"
- (("<Xcursor/Xcursor.h>") "<X11/Xcursor/Xcursor.h>"))
+ (delete-file-recursively "libraries/source/cxxtest-4.4")
+ (substitute* "build/premake/premake5.lua"
+ (("rootdir\\.\\.\"\\/libraries\\/source\\/cxxtest-4.4\\/bin\\/cxxtestgen\"")
+ (string-append "\"" (assoc-ref inputs "cxxtest")
+ "/bin/cxxtestgen"
+ "\"")))
#t))
(replace 'configure
- (lambda* (#:key inputs outputs #:allow-other-keys)
+ (lambda* (#:key inputs outputs tests? #:allow-other-keys)
(let* ((jobs (number->string (parallel-job-count)))
(out (assoc-ref outputs "out"))
(lib (string-append out "/lib"))
@@ -6703,11 +6705,13 @@ fight against their plot and save his fellow rabbits from slavery.")
(setenv "JOBS" (string-append "-j" jobs))
(setenv "CC" "gcc")
(with-directory-excursion "build/workspaces"
- (invoke "./update-workspaces.sh"
- (string-append "--libdir=" lib)
- (string-append "--datadir=" data)
- ;; TODO: "--with-system-nvtt"
- "--with-system-mozjs38")))))
+ (apply invoke
+ `("./update-workspaces.sh"
+ ,(string-append "--libdir=" lib)
+ ,(string-append "--datadir=" data)
+ ;; TODO: "--with-system-nvtt"
+ "--with-system-mozjs"
+ ,@(if tests? '() '("--without-tests"))))))))
(delete 'check)
(replace 'install
(lambda* (#:key inputs outputs #:allow-other-keys)
@@ -6717,7 +6721,9 @@ fight against their plot and save his fellow rabbits from slavery.")
(lib (string-append out "/lib"))
(data (string-append out "/share/0ad"))
(applications (string-append out "/share/applications"))
- (pixmaps (string-append out "/share/pixmaps"))
+ (hicolor (string-append out "/share/icons/hicolor/128x128/apps"))
+ (metainfo (string-append out "/share/metainfo"))
+ (mime (string-append out "/share/mime/application"))
(0ad-data (assoc-ref inputs "0ad-data")))
;; data
(copy-recursively "data" data)
@@ -6736,12 +6742,15 @@ fight against their plot and save his fellow rabbits from slavery.")
;; resources
(with-directory-excursion "../build/resources"
(install-file "0ad.desktop" applications)
- (install-file "0ad.png" pixmaps))
+ (install-file "0ad.png" hicolor)
+ (install-file "0ad.appdata.xml" metainfo)
+ (install-file "pyrogenesis.xml" mime))
#t)))
(add-after 'install 'check
- (lambda _
- (with-directory-excursion "system"
- (invoke "./test")))))))
+ (lambda* (#:key tests? #:allow-other-keys)
+ (when tests?
+ (with-directory-excursion "system"
+ (invoke "./test"))))))))
(home-page "https://play0ad.com")
(synopsis "3D real-time strategy game of ancient warfare")
(description "0 A.D. is a real-time strategy (RTS) game of ancient
--
2.33.0
next prev parent reply other threads:[~2021-09-04 1:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-21 21:37 [bug#46695] [PATCH 0/2] Update 0ad to 0.0.24-alpha Christopher Baines
2021-02-21 21:41 ` [bug#46695] [PATCH 1/2] gnu: mozjs-78: Update to 78.6.1 Christopher Baines
2021-02-21 21:41 ` [bug#46695] [PATCH 2/2] gnu: 0ad-data: Update to 0.0.24-alpha Christopher Baines
2021-06-29 3:12 ` [bug#46695] [PATCH 0/2] Update 0ad " Brendan Tildesley
2021-09-03 20:14 ` Ludovic Courtès
2021-09-04 1:43 ` Brendan Tildesley [this message]
2021-11-07 22:06 ` bug#46695: " Nicolas Goaziou
[not found] ` <8b5e70a8-da98-e690-017b-398bc4f6a5e9@brendan.scot>
2021-11-09 11:46 ` [bug#46695] " Nicolas Goaziou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1872927810.103187.1630719784241@office.mailbox.org \
--to=mail@brendan.scot \
--cc=46695@debbugs.gnu.org \
--cc=ludo@gnu.org \
--cc=mail@cbaines.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).