From: Eric Bavier <ericbavier@centurylink.net>
To: Paul Garlick <pgarlick@tourbillion-technology.com>,
Marius Bakke <mbakke@fastmail.com>
Cc: 28045@debbugs.gnu.org
Subject: [bug#28045] [PATCH] gnu: Add openfoam
Date: Wed, 16 Aug 2017 15:04:28 -0500 [thread overview]
Message-ID: <17DA467A-7864-4EED-9F61-16D634A0B976@centurylink.net> (raw)
In-Reply-To: <1502905946.2548.31.camel@tourbillion-technology.com>
[-- Attachment #1: Type: text/plain, Size: 2112 bytes --]
Scotch's INTSIZE64 is a bit of a misnomer, as it simply tells scotch to use the 'long' type rather than 'int'. IIRC, Ludovic's rational was that this would be 32 bits or 64 bit integers depending on the platform.
I think this is a reasonable default, but, like you point out, it does mean we need to keep thing consistent across packages. For metis this might mean a build phase that patches metis.h's IDXTYPEWIDTH macro appropriately for the target system. That should be a separate patch.
Thanks for working on it,
`~Eric
On August 16, 2017 12:52:26 PM CDT, Paul Garlick <pgarlick@tourbillion-technology.com> wrote:
>Hello Guix,
>Thank you Marius and Eric for your reviews and comments.
>I have been working through the changes and updating the patch.
> However, in the process of rebasing I have noticed a change in Guix
>that impacts on the OpenFOAM definition. Specifically, a recent commit
>(26599d6) has changed the definition of the scotch package so that it
>now uses 64bit integers. In a nutshell, this causes a build failure in
>OpenFOAM.
>In OpenFOAM, there is a variable to specify the size of the integer
>values (32bit or 64bit). This single variable is used by both metis
>and scotch, meaning that they both have to use 32bit integers or both
>use 64bit integers. At present, Guix offers a 64bit scotch and a 32bit
>metis.
>A straightforward solution would be to add the extra packages, a 32bit
>scotch and/or a 64bit metis. For scotch, that would be the same
>definition, except for the 'INTSIZE64' line. For metis, that would
>involve an edit of 'metis.h', setting IDXTYPEWIDTH and REALTYPEWIDTH to
>64.
>Would you prefer this to be the subject of a separate patch, or
>included in the OpenFOAM patch? There is also a question about how to
>name the packages; scotch and scotch32, for example, or scotch and
>scotch-64int etc.
>Best regards,
>Paul
>On Mon, 2017-08-14 at 21:49 -0500, Eric Bavier wrote:
>> Hello Paul,
>>
>> Thank you for the patch!
>>
>>
--
Sent from my Android device with K-9 Mail. Please excuse my brevity.
[-- Attachment #2: Type: text/html, Size: 2631 bytes --]
next prev parent reply other threads:[~2017-08-16 20:05 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1504818378.3116.38.camel@tourbillion-technology.com>
2017-08-11 11:06 ` [bug#28045] [PATCH] gnu: Add openfoam Paul Garlick
2017-08-14 23:07 ` Marius Bakke
2017-08-15 2:49 ` Eric Bavier
2017-08-16 17:52 ` Paul Garlick
2017-08-16 20:04 ` Eric Bavier [this message]
2017-08-17 9:42 ` Paul Garlick
2017-08-22 13:02 ` Ludovic Courtès
2017-08-22 17:10 ` Paul Garlick
2017-08-22 22:33 ` Ludovic Courtès
2017-08-30 15:08 ` Paul Garlick
2017-09-06 21:28 ` Paul Garlick
2017-09-07 11:57 ` Ludovic Courtès
2017-09-07 22:41 ` [bug#28045] [PATCH] gnu: Add openfoam] Paul Garlick
2017-09-08 8:23 ` [bug#28045] [PATCH] gnu: Add openfoam Ludovic Courtès
2017-09-08 11:32 ` Paul Garlick
2017-09-08 15:34 ` Eric Bavier
2017-09-08 20:30 ` Ludovic Courtès
2017-09-11 9:18 ` Paul Garlick
2017-09-11 11:39 ` Ludovic Courtès
2017-09-14 15:46 ` Paul Garlick
2017-09-15 16:35 ` bug#28045: " Ludovic Courtès
2017-09-08 15:39 ` [bug#28045] " Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=17DA467A-7864-4EED-9F61-16D634A0B976@centurylink.net \
--to=ericbavier@centurylink.net \
--cc=28045@debbugs.gnu.org \
--cc=mbakke@fastmail.com \
--cc=pgarlick@tourbillion-technology.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).