unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: paul via Guix-patches via <guix-patches@gnu.org>
To: Liliana Marie Prikler <liliana.prikler@gmail.com>, 73458@debbugs.gnu.org
Subject: [bug#73458] [PATCH 2/2] build-system: mix: Fix decoding of package names with git versions.
Date: Wed, 25 Sep 2024 23:30:02 +0200	[thread overview]
Message-ID: <17618f3c-2e80-f45a-b655-838420bce576@autistici.org> (raw)
In-Reply-To: <8264dde7b19aa96fb004f0aeb7908c43db6ad926.camel@gmail.com>

Hi Liliana,

Thank you for your help! I'm sending  v2 addressing your comments. I 
dropped the

elixir-relative-libdir

procedure all together because after some experimentation over at [0] it 
doesn't seem to be actually required. About splitting at dots it would 
complicate the logic imho as you would need to discriminate dots between 
version numbers and the dot before the commit. If you don't consider 
this as a blocking issue I think the regexp should be enough for the 
cases I tried.

Thank you for your work,

giacomo



[0]: https://github.com/fishinthecalculator/bonfire-guix





  reply	other threads:[~2024-09-25 21:48 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-24 17:03 [bug#73458] Fix mix-build-system bugs (73453 , 73454) paul via Guix-patches via
2024-09-25  8:24 ` [bug#73458] [PATCH 1/2] build-system: mix: Allow loading Erlang dependencies in Mix driven builds Giacomo Leidi via Guix-patches via
2024-09-25  8:24   ` [bug#73458] [PATCH 2/2] build-system: mix: Fix decoding of package names with git versions Giacomo Leidi via Guix-patches via
2024-09-25 19:54     ` Liliana Marie Prikler
2024-09-25 21:30       ` paul via Guix-patches via [this message]
2024-09-25 18:42   ` [bug#73458] [PATCH 1/2] build-system: mix: Allow loading Erlang dependencies in Mix driven builds Liliana Marie Prikler
2024-09-25 21:39 ` [bug#73458] [PATCH v2 " Giacomo Leidi via Guix-patches via
2024-09-25 21:39   ` [bug#73458] [PATCH v2 2/2] build-system: mix: Fix decoding of package names with git versions Giacomo Leidi via Guix-patches via

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=17618f3c-2e80-f45a-b655-838420bce576@autistici.org \
    --to=guix-patches@gnu.org \
    --cc=73458@debbugs.gnu.org \
    --cc=goodoldpaul@autistici.org \
    --cc=liliana.prikler@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).