From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id QIg4Ez8YX1+NbgAA0tVLHw (envelope-from ) for ; Mon, 14 Sep 2020 07:14:07 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id iDl8DT8YX186FwAAB5/wlQ (envelope-from ) for ; Mon, 14 Sep 2020 07:14:07 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id B82F49400C9 for ; Mon, 14 Sep 2020 07:14:06 +0000 (UTC) Received: from localhost ([::1]:37174 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kHigf-0005yB-L1 for larch@yhetil.org; Mon, 14 Sep 2020 03:14:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48424) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kHigc-0005xm-9r for guix-patches@gnu.org; Mon, 14 Sep 2020 03:14:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:40812) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kHigb-0001N0-Uh for guix-patches@gnu.org; Mon, 14 Sep 2020 03:14:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kHigb-0001Wp-Qh for guix-patches@gnu.org; Mon, 14 Sep 2020 03:14:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#43347] [PATCH] services: dovecot: Do not require dovecot to be globally installed. Resent-From: Alexey Abramov Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 14 Sep 2020 07:14:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43347 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: me@tobias.gr, pierre.langlois@gmx.com, 43347@debbugs.gnu.org X-Debbugs-Original-To: "Tobias Geerinckx-Rice" , Pierre Langlois , <43347@debbugs.gnu.org>, "Tobias Geerinckx-Rice via Guix-patches via" Received: via spool by submit@debbugs.gnu.org id=B.16000676275847 (code B ref -1); Mon, 14 Sep 2020 07:14:01 +0000 Received: (at submit) by debbugs.gnu.org; 14 Sep 2020 07:13:47 +0000 Received: from localhost ([127.0.0.1]:52358 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kHigM-0001WE-Uv for submit@debbugs.gnu.org; Mon, 14 Sep 2020 03:13:47 -0400 Received: from lists.gnu.org ([209.51.188.17]:59538) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kHigK-0001W5-0W for submit@debbugs.gnu.org; Mon, 14 Sep 2020 03:13:46 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48386) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kHigJ-0005jQ-Rx for guix-patches@gnu.org; Mon, 14 Sep 2020 03:13:43 -0400 Received: from mx4.mail.mmer.org ([178.22.66.29]:16218) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kHigH-0001LY-R5 for guix-patches@gnu.org; Mon, 14 Sep 2020 03:13:43 -0400 Received: from [192.168.1.188] (unknown [92.109.1.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx4.mail.mmer.org (Postfix) with ESMTPSA id 315CA9CC2C; Sat, 12 Sep 2020 14:35:54 +0000 (UTC) From: Alexey Abramov Date: Sat, 12 Sep 2020 17:06:39 +0200 Message-ID: <17482da9c18.281d.da5dc967fe079fb386b94d5b80162893@mmer.org> In-Reply-To: References: <87k0x09k6h.fsf@gmx.com> User-Agent: AquaMail/1.26.0-1689 (build: 102600004) MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="----------17482da9e031c25281d4a5784b" Received-SPF: pass client-ip=178.22.66.29; envelope-from=levenson@mmer.org; helo=mx4.mail.mmer.org X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/14 03:09:04 X-ACL-Warn: Detected OS = FreeBSD 9.x or newer [fuzzy] X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, HTML_MESSAGE=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -2.4 (--) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -0.01 X-TUID: EZIYPjilskkX This is a multi-part message in MIME format. ------------17482da9e031c25281d4a5784b Content-Type: text/plain; format=flowed; charset="UTF-8" Content-Transfer-Encoding: 8bit Hi, I see, let me try to fix this. Alexey On September 11, 2020 23:03:22 Tobias Geerinckx-Rice via Guix-patches via wrote: > Pierre, > > Thank you very much for the bug report. > > On 2020-09-11 21:40, Pierre Langlois wrote: >> I noticed recently my little dovecot mailserver failed to boot, I >> tracked it down to our service installing a symlink as: >> >> /etc/dovecot/modules -> /run/current-system/profile/lib/dovecot >> >> However, I didn't have the dovecot package globally installed, the >> service does not install it AFAICT. > > Sorry, this is my fault. I've been slowly merging some Dovecot > improvements[0] into master. > > While I'm happily replying from the latest Dovecot service, I run it in > an... idiosyncratic manner that had me write some glue code to test > these patches. I didn't realize that said glue was doing more work than > I, er, realized. Too much. > >> We could extend the service to install dovecot into the global profile, >> however instead we can just symlink /etc/dovecot/modules to the dovecot >> package in the store directly. > > Nack. That just reverts to last week's monolithic Dovecot service that > doesn't support modules, but now with pointless indirection via /etc. > Nor should the service add anything to the system profile, or expect the > user to do so. > > The fix is to add a ‘modules’ field to the service configuration that, > exactly like CUPS's ‘extensions’ field, adds module packages like > dovecot-pigeonhole to the union directory that /etc/dovecot/modules > points to. > > Kind regards, > > T G-R > > Sent from a Web browser. Excuse or enjoy my brevity. > > [0]: https://issues.guix.gnu.org/42899 ------------17482da9e031c25281d4a5784b Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi,

I = see, let me try to fix this.

Alexey=

On September 11, 2020 23:03:22 Tobias Geerinckx-Rice via = Guix-patches via <guix-patches@gnu.org> wrote:

Pierre,

Thank you very much for the bug report.

On 2020-09-11 21:40, Pierre Langlois wrote:
I noticed recently my little dovecot mailserver failed to= boot, I
tracked it down to our service installing a symlink as:

/etc/dovecot/modules -> /run/current-system/profile/li= b/dovecot

However, I didn't have the dovecot package globally insta= lled, the
service does not install it AFAICT.

Sorry, this is my fault.  I've been slowly merging s= ome Dovecot 
improvements[0] into master.

While I'm happily replying from the latest Dovecot servic= e, I run it in 
an... idiosyncratic manner that had me write some glue co= de to test 
these patches.  I didn't realize that said glue was = doing more work than 
I, er, realized.  Too much.

We could extend the service to install dovecot into the g= lobal profile,
however instead we can just symlink /etc/dovecot/modules = to the dovecot
package in the store directly.

Nack.  That just reverts to last week's monolithic D= ovecot service that 
doesn't support modules, but now with pointless indirecti= on via /etc.  
Nor should the service add anything to the system profile= , or expect the 
user to do so.

The fix is to add a =E2=80=98modules=E2=80=99 field to th= e service configuration that, 
exactly like CUPS's =E2=80=98extensions=E2=80=99 field, a= dds module packages like 
dovecot-pigeonhole to the union directory that /etc/dovec= ot/modules 
points to.

Kind regards,

T G-R

Sent from a Web browser. Excuse or enjoy my brevity.

[0]: https://issues.guix.gnu.org/42899

------------17482da9e031c25281d4a5784b--