From: Eric Bavier <ericbavier@centurylink.net>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 37510-done@debbugs.gnu.org
Subject: bug#37510: [PATCH 1/1] compile: Fix race condition on completion progress.
Date: Sat, 28 Sep 2019 00:01:08 -0400 (EDT) [thread overview]
Message-ID: <1740315284.38306958.1569643268369.JavaMail.zimbra@centurylink.net> (raw)
In-Reply-To: <87tv8yixmb.fsf@gnu.org>
----- On Sep 26, 2019, at 3:57 PM, Ludovic Courtès ludo@gnu.org wrote:
> Eric Bavier <ericbavier@centurylink.net> skribis:
>
>>>> +++ b/guix/build/compile.scm
>>>> @@ -173,7 +173,8 @@ files are for HOST, a GNU triplet such as
>>>> \"x86_64-linux-gnu\"."
>>>>
>>>> (define (build file)
>>>> (with-mutex progress-lock
>>>> - (report-compilation file total completed))
>>>> + (report-compilation file total completed)
>>>> + (set! completed (+ 1 completed)))
>>>
>>> Here ‘completed’ is incremented before the thing is even started.
>>
>> Maybe a more generic name like "progress" would be appropriate?
>
> Yes, probably!
Ok, pushed with a rename to "progress" in commit 21391f8c83.
--
`~Eric
prev parent reply other threads:[~2019-09-28 4:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-25 2:07 [bug#37510] [PATCH 1/1] compile: Fix race condition on completion progress ericbavier
2019-09-26 9:28 ` Ludovic Courtès
2019-09-26 13:42 ` Eric Bavier
2019-09-26 20:57 ` Ludovic Courtès
2019-09-28 4:01 ` Eric Bavier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1740315284.38306958.1569643268369.JavaMail.zimbra@centurylink.net \
--to=ericbavier@centurylink.net \
--cc=37510-done@debbugs.gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).