unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Dumitrascu Vasile via Guix-patches via <guix-patches@gnu.org>
To: 37534@debbugs.gnu.org, me@tobias.gr
Subject: [bug#37534] [PATCH] gnu: conky: Activate Pulseaudio support.
Date: Sat, 28 Sep 2019 09:02:12 +0000 (UTC)	[thread overview]
Message-ID: <1727802752.681659.1569661332406@mail.yahoo.com> (raw)
In-Reply-To: <875zlde4m5.fsf@nckx>


[-- Attachment #1.1: Type: text/plain, Size: 1277 bytes --]

  Hi Tobias
Thank you for the review and sorry to have missed the sorting.
I have re-attached the original patch as a file to this email, as I guess the encoding issues were caused by git send-mail.
  Thank you again,    Vasile

    On Saturday, September 28, 2019, 12:50:15 AM GMT+2, Tobias Geerinckx-Rice <me@tobias.gr> wrote:  
 
 Vasile,

Vasile Dumitrascu via Guix-patches via 写道:
> --- a/gnu/packages/conky.scm
> +++ b/gnu/packages/conky.scm
> @@ -2,6 +2,7 @@
>  ;;; Copyright ?? 2015 Sini??a Bi??in <sinisa@bidin.eu>
>  ;;; Copyright ?? 2018, 2019 Tobias Geerinckx-Rice 
>  <me@tobias.gr>
>  ;;; Copyright ?? 2019 Pierre Neidhardt <mail@ambrevar.xyz>
> +;;; Copyright ?? 2019 Vasile Dumitrascu <va511e@yahoo.com>

Does this show up as corrupted in your mailbox as well?  (‘??’ 
instead of ‘©’.)

> @@ -76,6 +79,7 @@
>        ("libxext" ,libxext)
>        ("libxft" ,libxft)
>        ("libxinerama" ,libxinerama)
> +      ("pulseaudio", pulseaudio)
>        ("lua" ,lua)
>        ("ncurses" ,ncurses)
>        ("curl" ,curl)))

I guess any hope of alphabetical ordering was lost long ago.

The change looks fine to me, but could you try fixing the text 
encoding?

Thanks!

T G-R  

[-- Attachment #1.2: Type: text/html, Size: 3234 bytes --]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnu-conky-Activate-Pulseaudio-support.patch --]
[-- Type: text/x-patch, Size: 1628 bytes --]

From ddd14f92faa6298f93ded11ff1f96b34f847a549 Mon Sep 17 00:00:00 2001
From: Vasile Dumitrascu <va511e@yahoo.com>
Date: Fri, 27 Sep 2019 22:32:05 +0200
Subject: [PATCH] gnu: conky: Activate Pulseaudio support.

* gnu/packages/conky.scm (conky):
  [inputs] Add pulseaudio.
---
 gnu/packages/conky.scm | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/conky.scm b/gnu/packages/conky.scm
index 681feb6e43..046d132a9b 100644
--- a/gnu/packages/conky.scm
+++ b/gnu/packages/conky.scm
@@ -2,6 +2,7 @@
 ;;; Copyright © 2015 Siniša Biđin <sinisa@bidin.eu>
 ;;; Copyright © 2018, 2019 Tobias Geerinckx-Rice <me@tobias.gr>
 ;;; Copyright © 2019 Pierre Neidhardt <mail@ambrevar.xyz>
+;;; Copyright © 2019 Vasile Dumitrascu <va511e@yahoo.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -31,6 +32,7 @@
   #:use-module (gnu packages lua)
   #:use-module (gnu packages ncurses)
   #:use-module (gnu packages pkg-config)
+  #:use-module (gnu packages pulseaudio)
   #:use-module (gnu packages xorg))
 
 (define-public conky
@@ -51,7 +53,8 @@
     (arguments
      `(#:tests? #f                      ; there are no tests
        #:configure-flags
-       (list "-DRELEASE=true")
+       (list "-DRELEASE=true"
+             "-DBUILD_PULSEAUDIO=ON")
        #:phases
        (modify-phases %standard-phases
          (add-after 'unpack 'add-freetype-to-search-path
@@ -76,6 +79,7 @@
        ("libxext" ,libxext)
        ("libxft" ,libxft)
        ("libxinerama" ,libxinerama)
+       ("pulseaudio", pulseaudio)
        ("lua" ,lua)
        ("ncurses" ,ncurses)
        ("curl" ,curl)))
-- 
2.23.0


  reply	other threads:[~2019-09-28  9:03 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-27 20:32 [bug#37534] [PATCH] gnu: conky: Activate Pulseaudio support Vasile Dumitrascu via Guix-patches via
2019-09-27 22:50 ` Tobias Geerinckx-Rice via Guix-patches via
2019-09-28  9:02   ` Dumitrascu Vasile via Guix-patches via [this message]
2019-10-01 16:16     ` bug#37534: " Tobias Geerinckx-Rice via Guix-patches via

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1727802752.681659.1569661332406@mail.yahoo.com \
    --to=guix-patches@gnu.org \
    --cc=37534@debbugs.gnu.org \
    --cc=me@tobias.gr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).