From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id QJ+JMiJS/WUPeAAAe85BDQ:P1 (envelope-from ) for ; Fri, 22 Mar 2024 10:40:51 +0100 Received: from aspmx1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2.migadu.com with LMTPS id QJ+JMiJS/WUPeAAAe85BDQ (envelope-from ) for ; Fri, 22 Mar 2024 10:40:50 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=bioneland.org header.s=20230804 header.b=cZ7Dj0q8; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1711100450; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=o8OqEc6hhJBgFjww+QlbfqqBAYvQejLbJfzNOd/AJnE=; b=CtskVEf95V4NDLxybPonYqFqxiLX02jjOJ/R4qYPPgHu1kscnx+LcRFS4zqOKoe3j2hCsK 3XPFqIOtynzUe/+XmhYjYKHq6mrOIS5DioSBnwKACi+7t0zUa+ejDjnkNIxfy+t1C4hBtZ GaHXGZmA6XJmZG7WKmdQVkgx8hizSefC3U16D8aHV4RabBM2j9hkVwUAVJgorF0VnQLOUw 5oWso4aScMrqkxfVYwhmWFQIJS7v1cIBKSmNPw2C4Jhgt9k2bKwFtosLUuLldihtWFICuE S5k1tGCyaTdL0B0wL63qBuEDbvUdFj+B7A/J65eTQUe5AO5mZX4OoDx2gFa9nQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=bioneland.org header.s=20230804 header.b=cZ7Dj0q8; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Seal: i=1; s=key1; d=yhetil.org; t=1711100450; a=rsa-sha256; cv=none; b=aat5kiPqFJsvq1A02ZDCiB6GbbC0D1E30yw9E355+B6DRVWiiMJXIbGWdnDKNE2OvjB9ij 9RjRgvMZLDqAuJsFoPOdqZk69CNE4iw4yIN+CIU/8BZ1+j/8sqG66x4FdKkAeG+czGeaoV NWZ/sbwOKOhN1LZczJsVukpo1FZ/fb9vAdwRVAvB7Z/Xo5r2lyOKTcjaM+wuHU4yiR44K4 LQFbYoE2wV7sx0vI4TATVZhKIBLfRA2unAYvgMVjxdE71TwGFo1c5HDrnv10U0hY+TFxsr sWsKGY0jgeImZEpiiaX143L43jEb8jg82rde+YFIvIIN4vcCpX764yDMl1dfDg== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 5259F14000 for ; Fri, 22 Mar 2024 10:40:49 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rnbO2-0001ZF-La; Fri, 22 Mar 2024 05:40:30 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rnbNu-0001Yu-2t for guix-patches@gnu.org; Fri, 22 Mar 2024 05:40:22 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rnbNt-0000ZI-RA for guix-patches@gnu.org; Fri, 22 Mar 2024 05:40:21 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rnbOY-00065j-5j for guix-patches@gnu.org; Fri, 22 Mar 2024 05:41:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#69867] [PATCH 1/2] gnu: Add python-noiseprotocol. Resent-From: Tanguy LE CARROUR Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 22 Mar 2024 09:41:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 69867 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 69867@debbugs.gnu.org, normally_js Received: via spool by 69867-submit@debbugs.gnu.org id=B69867.171110042523286 (code B ref 69867); Fri, 22 Mar 2024 09:41:02 +0000 Received: (at 69867) by debbugs.gnu.org; 22 Mar 2024 09:40:25 +0000 Received: from localhost ([127.0.0.1]:37745 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rnbNv-00063N-Ef for submit@debbugs.gnu.org; Fri, 22 Mar 2024 05:40:24 -0400 Received: from smtp-1909.mail.infomaniak.ch ([185.125.25.9]:55429) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rnbHi-0005iI-Ik for 69867@debbugs.gnu.org; Fri, 22 Mar 2024 05:34:01 -0400 Received: from smtp-4-0001.mail.infomaniak.ch (smtp-4-0001.mail.infomaniak.ch [10.7.10.108]) by smtp-4-3000.mail.infomaniak.ch (Postfix) with ESMTPS id 4V1HDS2V18zCmJ; Fri, 22 Mar 2024 10:32:40 +0100 (CET) Received: from unknown by smtp-4-0001.mail.infomaniak.ch (Postfix) with ESMTPA id 4V1HDR6jX5zNLf; Fri, 22 Mar 2024 10:32:39 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=bioneland.org; s=20230804; t=1711099960; bh=zZfdOlQhIxMeZRsWxOtk58+yjpZItEmf5I6PHJyuSvo=; h=References:Subject:From:To:In-Reply-To:Date:From; b=cZ7Dj0q8G7xiaJdsNJu8/uesW6j0rrX9TQ0D9GjOlmAsywU+Kfo8ikVWgoQc5FyPj GJziZuzrRTzEpNnrSDWpb39fLV0CCZEv+jbpnqTQkGqHg+D5hmMnNdcEVsxegxLdOu 6EtRRDgGY44UpNtG4WefE8iui1qEWb9WF/YWqpd2ehIZ9i7U2GVP6VhQgNK8Snnc9v 6YpIXEIEXFj216VY5D0bCVvtygdBWsdk1ukAUWaAgX/j27Gut40BVc+yoCsyOBZLXu cA5AcWzGdGDCWR04BsEp5bb1OifirrlKVcD15UnF9pwDnZajTOG3eTJceg1HBxvtRZ F17oylvLYbajA== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable References: <363ccec2b669280c76d8bbb9fb7749735b850a05.1710960666.git.normally_js@posteo.net> <171101047539.12926.16325090825361818580@bioneland.org> <55c45f96-e664-674c-42c2-0502591eeed0@posteo.net> From: Tanguy LE CARROUR In-Reply-To: <55c45f96-e664-674c-42c2-0502591eeed0@posteo.net> Date: Fri, 22 Mar 2024 10:32:39 +0100 Message-ID: <171109995921.22023.15345518586065905969@bioneland.org> User-Agent: alot/0.10 X-Infomaniak-Routing: alpha X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Scanner: mx13.migadu.com X-Migadu-Spam-Score: -2.43 X-Spam-Score: -2.43 X-Migadu-Queue-Id: 5259F14000 X-TUID: qN0ghxd/Rqow Hi, Quoting normally_js (2024-03-21 19:59:15) > Short answer: I don't know how to disable specific tests within the=20 > python-build-system, but since we already have a solution that works it=20 > likely doesn't matter. > But I'd assume that getting tests to pass is better than being forced to = > disable them and python-team should *not* be affected by this addition. My bad! I should have suggested the code snippet to disable it! As the error message is: ``` ERROR: test_large_frame (wormhole.test.dilate.test_record.Record) Noise only allows 64KiB message, but the API allows up to 4GiB ---------------------------------------------------------------------- Traceback (most recent call last): [=E2=80=A6] File "/tmp/guix-build-magic-wormhole-0.13.0.drv-0/magic-wormhole-0.13.0/s= rc/wormhole/_dilation/connector.py", line 45, in build_noise return NoiseConnection.from_name(NOISEPROTO) AttributeError: 'NoneType' object has no attribute 'from_name' ``` =E2=80=A6 the failing test is `test_large_frame`. You can disable it the sa= me way it is done in, for instance, `magic-wormhole-mailbox-server`: ```scheme (arguments '(#:phases (modify-phases %standard-phases (add-after 'unpack 'disable-some-tests (lambda _ (substitute* "src/wormhole/_dilation/connector.py" (("test_large_frame") "disabled_test_large_frame")) #t))))) ``` But, actually, the problem comes from the fact that the `noise` module is not available. You must add `python-noiseprotocol` as an input to the package. Either as a native input for the test to pass, or, if it make sense, as a propagated input for it to be available at run time. Hence, the patch adding `python-noiseprotocol` should come before the one updating `magic-wormhole`. Regards, --=20 Tanguy