From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id GN3KIcYcS2XpKAAAauVa8A:P1 (envelope-from ) for ; Wed, 08 Nov 2023 06:29:42 +0100 Received: from aspmx1.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id GN3KIcYcS2XpKAAAauVa8A (envelope-from ) for ; Wed, 08 Nov 2023 06:29:42 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 537C434915 for ; Wed, 8 Nov 2023 06:29:42 +0100 (CET) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=l8fJ0iAT; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1699421382; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=NrsoUdCnzFjPpIPXeje7PSQqSD+HFRm6y5+ur04AUAM=; b=qEMUWZmdAdorC/547S3Qhl5O5z3SLgy6DXCh8IgbP1gZzvNUFiZ8EtF23zEocobLrZcATF e6g6bVU5bqRt0Z/Bk0YFJV/msaMoqjbzVyIA4oKR6dD0Lvtt3CpM4m5MsBXOO9qsfbfgX0 TLSisR27fLqCV4B+J9guRhYuoksHZ94Y1P2uJ/ldXD+22tacTt0kSwrvvoyGMM2kcSH81r N1JCMwZh4OsDUF8G2C7oQXeXvuNpqx96yviF0dvzKuemKt6SNeFePnYj/npsrdCXI1/uHF zhNBMYVfO3XeihrZpJgECOA7d7CcArT/nGaBRqhwbU14OUjk3DgHnPp8Lzc0ow== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=l8fJ0iAT; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1699421382; a=rsa-sha256; cv=none; b=EVtP2xNWJZX0WXK4b2RauefkZDgvNemMw1dN0VAmNe6XEkg6gzdLrLLdY/CnDOAuQR/s5W 0IYyof/aAPN56gYqLIseTVr7db7Zwh4g5C04oM3Qwe9RFAvyskO6KDUgyTZIwuF7YkWBKT njU9ap95EuUgPUe6dChsFI0lu6TwnpgYIEjp5n/UvsmfvCysVHm1x4lal+sFCBD0XW/5Ho v5+Vxi7IPokfctLRnt4VXJfStAzzAEGC3sSXMJPIaGE4UvBGw3Vf3B9ostoxBK3ba8+C5k 6g2etCFj1MUnBDPd3IOWcrr2yfvp/HwbsbnBamPqQQiOxAdRIfg8tUlJgK58fQ== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r0b83-0000Mo-I2; Wed, 08 Nov 2023 00:29:27 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r0b81-0000Mf-7m for guix-patches@gnu.org; Wed, 08 Nov 2023 00:29:25 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1r0b80-0002qt-CC for guix-patches@gnu.org; Wed, 08 Nov 2023 00:29:25 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1r0b8c-0004tn-DJ for guix-patches@gnu.org; Wed, 08 Nov 2023 00:30:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#62848] [PATCH v2] environment: Add --remote option and emacsclient-eshell backend. Resent-From: Liliana Marie Prikler Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 08 Nov 2023 05:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62848 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: moreinfo patch To: Antero Mejr , 62848@debbugs.gnu.org Cc: maxim.cournoyer@gmail.com Received: via spool by 62848-submit@debbugs.gnu.org id=B62848.169942139418788 (code B ref 62848); Wed, 08 Nov 2023 05:30:02 +0000 Received: (at 62848) by debbugs.gnu.org; 8 Nov 2023 05:29:54 +0000 Received: from localhost ([127.0.0.1]:43877 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r0b8T-0004sx-Q3 for submit@debbugs.gnu.org; Wed, 08 Nov 2023 00:29:54 -0500 Received: from mail-ej1-x644.google.com ([2a00:1450:4864:20::644]:46239) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r0b8Q-0004si-QX for 62848@debbugs.gnu.org; Wed, 08 Nov 2023 00:29:52 -0500 Received: by mail-ej1-x644.google.com with SMTP id a640c23a62f3a-9db6cf8309cso958407966b.0 for <62848@debbugs.gnu.org>; Tue, 07 Nov 2023 21:29:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1699421346; x=1700026146; darn=debbugs.gnu.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=NrsoUdCnzFjPpIPXeje7PSQqSD+HFRm6y5+ur04AUAM=; b=l8fJ0iATamT0r35v0fuToezrDJahvWSI6esSdITNkwxrfsCJ2OQwIV4Ru3Chf+hS7P 61NaFHLlK+0XrFlBIuGpXOA5Iue/quDu+CrVKYyd8UKin2xskvPEwadMA7w0g881jNJ8 AhVjnBin/qaLfUmpjeidjUYFZZd9gO1zZlObP28bx/txuzcOJhRuvRk7zno1KiE9wE1P reyDA6MARVTF7FKPPMxWa0Y9kByYQXkGtvSVeVINB/G07XndkNGgsCJc8ZbGovDtWsE2 muZLX2hcdeVFDFEB+E5wYdsEHqdhsnIopYsnGYGz4TJclFSz1G3JGGbsgsQjcj7jLaK1 w3Gg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699421346; x=1700026146; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=NrsoUdCnzFjPpIPXeje7PSQqSD+HFRm6y5+ur04AUAM=; b=qO3zHqb7YujgB2XgXXQZBpBhv/F0RI7uyxIHe6rUaw8prIJn+1Z1oDAqd0fwgyyUKX D5QTqBnVW6xHOhKoSTwsHaIfGM/JqtwOHzq3aeHxLchg47m6JU3pzc5g8vlD5YTOyS+k uAG9rLaQQIgGZ2gELrNj9fZg22j+HQ9eJ2FH7k/D8+FUXGAYW7mFaWLPD+ab4At0Jz3r kkCEvxifEib9FHWGJTxuElD7+KfkIJJp3SBZVxlPfTZ+xOSvzhgLnoLJfi8YrH1XU7n0 8QLKyXDq0wp4Ij2AbWcxfuO6Vr1hcLUY+ZivFwu9JFoYVY63+RIU9T/QGFRkh+x0MlBR scTg== X-Gm-Message-State: AOJu0YwLR5pDVK19Yv9Ogr8P0dCWeII5pV5F8dmdIlSjU7ixyrC8Beoy BYZ9g9pPEqMRfd5ZGqagJjA= X-Google-Smtp-Source: AGHT+IHGXki7/F20XFG1tdX+MahDmtx1i3g3iVrBHJkZqgjmgmx1SV5Nx4sci6PQ+TWDYzrJpVuVuw== X-Received: by 2002:a17:906:ee81:b0:9dc:21c7:9ae5 with SMTP id wt1-20020a170906ee8100b009dc21c79ae5mr495384ejb.26.1699421346304; Tue, 07 Nov 2023 21:29:06 -0800 (PST) Received: from lumine.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id d27-20020a170906371b00b009ae3d711fd9sm453004ejc.69.2023.11.07.21.29.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Nov 2023 21:29:05 -0800 (PST) Message-ID: <16e985a5a6cc331daecfb58a1a737e6c6f76fa32.camel@gmail.com> From: Liliana Marie Prikler Date: Wed, 08 Nov 2023 06:29:03 +0100 In-Reply-To: <87msvpmc2e.fsf@mailbox.org> References: <87msvpmc2e.fsf@mailbox.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.4 MIME-Version: 1.0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: 2.89 X-Spam-Score: 2.89 X-Migadu-Queue-Id: 537C434915 X-Migadu-Scanner: mx10.migadu.com X-TUID: GegOW9ibfRTt Am Dienstag, dem 07.11.2023 um 22:30 +0000 schrieb Antero Mejr: > * guix/scripts/environment.scm (launch-environment/eshell): New > procedure. > (%remote-backends): New variable. > (guix-environment*): Add logic for remote backend switching. > (launch-envrionment)[white-list]: Change keyword argument name to > 'allow-list'. You have a typo here. In general, should be (launch-environment): Rename #:white-list to #:allow-list > (launch-environment/fork)[white-list]: Change keyword argument name > to > 'allow-list'. > (%options): Add --remote and --list-remote-backends options. > (show-environment-options-help): Add help text for new options. > * guix/profiles.scm (load-profile)[getenv-proc, setenv-proc, > unsetenv-proc]: > New optional keyword arguments. > (load-profile)[white-list]: Change keyword argument name to 'allow- > list'. > (purify-environment)[white-list-regexps]: Change argument name to > 'allow-list-regexps'. > (purify-environment)[unsetenv-proc]: New argument. > * guix/build/emacs-utils.scm (%emacsclient): New parameter. > (emacsclient-batch-script): New procedure. > * doc/guix.texi(Invoking guix shell): Document --remote and > --list-remote-backends options. > * tests/build-emacs-utils.scm(emacsclient-batch-script): New test. > * tests/profiles.scm(load-profile): Change 'white-list' keyword > argument to > 'allow-list'. > --- > With requested changes from Maxim's review: > Update white-list/allow-list terminology throughout. > Always check for errors when invoking emacsclient. > Simplify emacsclient invocation code by using the > (guix build emacs-utils) module. > Add new test to build-emacs-utils.scm for testing emacsclient. You have merged two changes into one patch imho. I think it'd be better if you swapped the wording first and then added the emacsclient code. Interestingly, this still won't support emacs sans client IIUC as we anyhow have to spawn a new process. Can we (perhaps in cooperation with guix-emacs) make it so that 'guix shell' spawned from eshell does "the right thing"? Cheers