unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / Atom feed
* [bug#47863] [PATCH] gnu: xfce4-settings: Add gsettings-desktop-schemas.
@ 2021-04-18  6:23 Brendan Tildesley
  2021-04-28 23:23 ` Ludovic Courtès
  0 siblings, 1 reply; 5+ messages in thread
From: Brendan Tildesley @ 2021-04-18  6:23 UTC (permalink / raw)
  To: 47863

* gnu/packages/xfce.scm (xfce4-settings):[propagated-inputs]: Add
gsettings-desktop-schemas. This makes it appear in the system profile
via the xfce service. This fixes a bug where changing icon theme causes
xfce4-appearance-settings to crash with the error:

GLib-GIO-ERROR **: 15:41:45.828: Settings schema 'org.gnome.desktop.interface' is not installed
Trace/breakpoint trap
---
 gnu/packages/xfce.scm | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/gnu/packages/xfce.scm b/gnu/packages/xfce.scm
index 38240d7b9f..ffac62af9e 100644
--- a/gnu/packages/xfce.scm
+++ b/gnu/packages/xfce.scm
@@ -755,6 +755,8 @@ allows you to shut down the computer from Xfce.")
        ("upower" ,upower) ;; TODO needs upower-glib
        ("python" ,python) ;; for xfce4-compose-mail
        ("xf86-input-libinput" ,xf86-input-libinput)))
+    (propagated-inputs
+     `(("gsettings-desktop-schemas" ,gsettings-desktop-schemas)))
     (home-page "https://www.xfce.org/")
     (synopsis "Xfce settings manager")
     (description
-- 
2.31.1





^ permalink raw reply	[flat|nested] 5+ messages in thread

* [bug#47863] [PATCH] gnu: xfce4-settings: Add gsettings-desktop-schemas.
  2021-04-18  6:23 [bug#47863] [PATCH] gnu: xfce4-settings: Add gsettings-desktop-schemas Brendan Tildesley
@ 2021-04-28 23:23 ` Ludovic Courtès
  2021-04-29  5:53   ` Brendan Tildesley
  2021-04-29  7:58   ` [bug#47863] " Brendan Tildesley
  0 siblings, 2 replies; 5+ messages in thread
From: Ludovic Courtès @ 2021-04-28 23:23 UTC (permalink / raw)
  To: Brendan Tildesley; +Cc: 47863

Hi,

Brendan Tildesley <mail@brendan.scot> skribis:

> * gnu/packages/xfce.scm (xfce4-settings):[propagated-inputs]: Add
> gsettings-desktop-schemas. This makes it appear in the system profile
> via the xfce service. This fixes a bug where changing icon theme causes
> xfce4-appearance-settings to crash with the error:
>
> GLib-GIO-ERROR **: 15:41:45.828: Settings schema 'org.gnome.desktop.interface' is not installed
> Trace/breakpoint trap

The patch LGTM but I can’t seem to reproduce the issue here.  Namely, if
I go to Settings → Appearance and switch from “GNOME Theme” to
“Adwaita”, it just works.

Am I missing something?

Thanks,
Ludo’.




^ permalink raw reply	[flat|nested] 5+ messages in thread

* [bug#47863] [PATCH] gnu: xfce4-settings: Add gsettings-desktop-schemas.
  2021-04-28 23:23 ` Ludovic Courtès
@ 2021-04-29  5:53   ` Brendan Tildesley
  2021-04-30 16:20     ` bug#47863: " Ludovic Courtès
  2021-04-29  7:58   ` [bug#47863] " Brendan Tildesley
  1 sibling, 1 reply; 5+ messages in thread
From: Brendan Tildesley @ 2021-04-29  5:53 UTC (permalink / raw)
  To: 47863; +Cc: Ludovic Courtès


> On 04/29/2021 1:23 AM Ludovic Courtès <ludo@gnu.org> wrote:
> 
>  
> Hi,
> 
> Brendan Tildesley <mail@brendan.scot> skribis:
> 
> > * gnu/packages/xfce.scm (xfce4-settings):[propagated-inputs]: Add
> > gsettings-desktop-schemas. This makes it appear in the system profile
> > via the xfce service. This fixes a bug where changing icon theme causes
> > xfce4-appearance-settings to crash with the error:
> >
> > GLib-GIO-ERROR **: 15:41:45.828: Settings schema 'org.gnome.desktop.interface' is not installed
> > Trace/breakpoint trap
> 
> The patch LGTM but I can’t seem to reproduce the issue here.  Namely, if
> I go to Settings → Appearance and switch from “GNOME Theme” to
> “Adwaita”, it just works.
> 
> Am I missing something?
> 
If you also have GNOME installed then it will work. GNOME provides them via propagated inputs in many packages.
For me, the theme changes, but then the settings window crashes.

BTW do you think the way the gnome package is made with propagated inputs is better than how the xfce is made by union-ing everything?




^ permalink raw reply	[flat|nested] 5+ messages in thread

* [bug#47863] [PATCH] gnu: xfce4-settings: Add gsettings-desktop-schemas.
  2021-04-28 23:23 ` Ludovic Courtès
  2021-04-29  5:53   ` Brendan Tildesley
@ 2021-04-29  7:58   ` Brendan Tildesley
  1 sibling, 0 replies; 5+ messages in thread
From: Brendan Tildesley @ 2021-04-29  7:58 UTC (permalink / raw)
  To: Ludovic Courtès; +Cc: 47863

Run 
$(guix system vm ./xfce-os-test.scm) -m 1G
with this:

(use-modules (gnu)
             (srfi srfi-1))
(use-service-modules desktop xorg)
(operating-system
  (bootloader (grub-configuration))
  (file-systems %base-file-systems)
  (locale "en_AU.utf8")
  (timezone "Australia/Hobart")
  (keyboard-layout    (keyboard-layout "us" "colemak"))
  (host-name "jiu")
  (users (cons* (user-account
                 (name "b")
                 (password (crypt "b" "$6$abc")) ;; password "b"
                 (comment "Brendan")
                 (group "users")
                 (home-directory "/home/b")
                 (supplementary-groups
                  '("wheel" "netdev" "audio" "video" "kvm")))
                %base-user-accounts))
  (packages
   (append
    (map specification->package '("nss-certs"
                                  "gnome-themes-standard"))
    %base-packages))
  (services
   (append
    (list (set-xorg-configuration
           (xorg-configuration
            (keyboard-layout keyboard-layout)))

          (service xfce-desktop-service-type))

    (modify-services %desktop-services
      (gdm-service-type
       config => (gdm-configuration
                  (default-user "b")
                  (auto-login? #t)))))))




^ permalink raw reply	[flat|nested] 5+ messages in thread

* bug#47863: [PATCH] gnu: xfce4-settings: Add gsettings-desktop-schemas.
  2021-04-29  5:53   ` Brendan Tildesley
@ 2021-04-30 16:20     ` Ludovic Courtès
  0 siblings, 0 replies; 5+ messages in thread
From: Ludovic Courtès @ 2021-04-30 16:20 UTC (permalink / raw)
  To: Brendan Tildesley; +Cc: 47863-done

Hi,

Brendan Tildesley <mail@brendan.scot> skribis:

>> On 04/29/2021 1:23 AM Ludovic Courtès <ludo@gnu.org> wrote:

[...]

>> The patch LGTM but I can’t seem to reproduce the issue here.  Namely, if
>> I go to Settings → Appearance and switch from “GNOME Theme” to
>> “Adwaita”, it just works.
>> 
>> Am I missing something?
>> 
> If you also have GNOME installed then it will work. GNOME provides them via propagated inputs in many packages.
> For me, the theme changes, but then the settings window crashes.

OK.  So actually what happens is that changing themes works, but the
thing crashes right after changing themes (which I didn’t notice when
spawning xfce4-appearance-settings by clicking in the menu).

Applied, thanks!

> BTW do you think the way the gnome package is made with propagated inputs is better than how the xfce is made by union-ing everything?

No strong opinion, either way is fine with me.

Ludo’.




^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2021-04-30 16:33 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-18  6:23 [bug#47863] [PATCH] gnu: xfce4-settings: Add gsettings-desktop-schemas Brendan Tildesley
2021-04-28 23:23 ` Ludovic Courtès
2021-04-29  5:53   ` Brendan Tildesley
2021-04-30 16:20     ` bug#47863: " Ludovic Courtès
2021-04-29  7:58   ` [bug#47863] " Brendan Tildesley

unofficial mirror of guix-patches@gnu.org 

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://yhetil.org/guix-patches/1 guix-patches/git/1.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 guix-patches guix-patches/ https://yhetil.org/guix-patches \
		guix-patches@gnu.org
	public-inbox-index guix-patches

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://news.yhetil.org/yhetil.gnu.guix.patches


AGPL code for this site: git clone http://ou63pmih66umazou.onion/public-inbox.git