From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id sMAMDxbpHmSZ0AAASxT56A (envelope-from ) for ; Sat, 25 Mar 2023 13:29:10 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id yBLVDhbpHmQeSQAAauVa8A (envelope-from ) for ; Sat, 25 Mar 2023 13:29:10 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id ACCC664F4 for ; Sat, 25 Mar 2023 13:29:09 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pg319-0008He-0C; Sat, 25 Mar 2023 08:29:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pg316-0008HF-DQ for guix-patches@gnu.org; Sat, 25 Mar 2023 08:29:04 -0400 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pg315-0005af-RQ for guix-patches@gnu.org; Sat, 25 Mar 2023 08:29:04 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pg314-0004xy-N3 for guix-patches@gnu.org; Sat, 25 Mar 2023 08:29:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#62298] [PATCH v2 8/8] services: mympd: Use user-account (resp. user-group) for user (resp. group) fields. Resent-From: Liliana Marie Prikler Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 25 Mar 2023 12:29:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62298 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Bruno Victal , Maxim Cournoyer Cc: 62298@debbugs.gnu.org, ludo@gnu.org Received: via spool by 62298-submit@debbugs.gnu.org id=B62298.167974732119047 (code B ref 62298); Sat, 25 Mar 2023 12:29:02 +0000 Received: (at 62298) by debbugs.gnu.org; 25 Mar 2023 12:28:41 +0000 Received: from localhost ([127.0.0.1]:42025 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pg30i-0004x8-Jb for submit@debbugs.gnu.org; Sat, 25 Mar 2023 08:28:40 -0400 Received: from mail-ed1-f66.google.com ([209.85.208.66]:45029) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pg30g-0004wu-4d for 62298@debbugs.gnu.org; Sat, 25 Mar 2023 08:28:38 -0400 Received: by mail-ed1-f66.google.com with SMTP id eh3so17789446edb.11 for <62298@debbugs.gnu.org>; Sat, 25 Mar 2023 05:28:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679747312; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=qxb135tMfV97L34ZNSW1NXEWJUFIe5744xrzQdNprzI=; b=Lc6Rag4qffUF8xWB3TxtXPGmyrGPijDMZXIu2BD37Ulcgva8tj4WJgt6jxg/dEW038 7SzCuwca/Zd2ZqxWvIyVe1fTNmoSxIMgi8Q55WqGurivVIziI5oXPhK2W1qnzFTnnQus +GoiydBA1V3Ve7xukzMGacXtt3xTC4vpls45MxpDmwGA8IrviZdTzn8CDgWOnT5OYaTb t0r68JyAReGQfJKGLCrG13MbGwX4nMJpZh93Jvlw5D2ehdE6xXXJx1FSR45f4asyuV63 BqgDexSXZRr275n1jt3sWzknjv2ZGrpwWUSZNUYV4IU/15oP82dUv1/nOfeOSqDeyBFl TpQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679747312; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=qxb135tMfV97L34ZNSW1NXEWJUFIe5744xrzQdNprzI=; b=A9gymBLL350yJ2vkimCfYdUz+w+J5FCj1KfCmBodWGf0ALnBzsYl7FGXtgQTwRDLwq hMgP0AhNTYNALd1AwWHOMW3tFd96T/Ma9Wpd4NeUfJfngjDhlALynJvpS/6+0jqyYBt2 1wA8gRpmhM+rzxikRqvWaY8e1kqEH3viawCkqeSWvqY9WH4WhLDv6jBQFBLHwJOrc4Ud +z33zGGmknziU1mxVD6juAUdSyclNeF6+/K0v/ItNxpkkojvA7TwzsdRvOfhSTBiGRf7 E3sM8xebO9CoPOSIJur6I6nfLJhNqPBh1OqwpvgQUyp7eOgfaigu0WW32fqfNiwN/XL9 9mTA== X-Gm-Message-State: AAQBX9fauGTOKqytHO+B5Q/0LRXhOKAW0WQ9zKQQEMoQU5uaZ9DhLbUx Ynix9i5zCpNmOrZgQj9O59GLeha45sNE1Q== X-Google-Smtp-Source: AKy350YH9soGsEaDyF2CdC4nG71qqcs7LYsgUbDjEvz58jAA2USEFdkMVxSdBtVRHINnyGX5Rmn15A== X-Received: by 2002:a17:906:f193:b0:92b:eca6:43fc with SMTP id gs19-20020a170906f19300b0092beca643fcmr5380517ejb.64.1679721721593; Fri, 24 Mar 2023 22:22:01 -0700 (PDT) Received: from lumine.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id b1-20020a1709065e4100b008ca52f7fbcbsm11251325eju.1.2023.03.24.22.22.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Mar 2023 22:22:01 -0700 (PDT) Message-ID: <164d0aafa0f598f742ed4a3b9d2c2cdac102f398.camel@gmail.com> From: Liliana Marie Prikler Date: Sat, 25 Mar 2023 06:21:59 +0100 In-Reply-To: <6adedff0-30d3-c1c4-7b10-ece811f517ab@makinata.eu> References: <364a2fe961ddce2c4668c0c8b78f46bffe2c2096.1679583701.git.mirai@makinata.eu> <877cv6yw5e.fsf@gmail.com> <6adedff0-30d3-c1c4-7b10-ece811f517ab@makinata.eu> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.0 MIME-Version: 1.0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Seal: i=1; s=key1; d=yhetil.org; t=1679747349; a=rsa-sha256; cv=none; b=eJp6ezDQpCo6p2nfTJtRS9tCTV3J7nnuL5D1ff4a37r4ptBOrflknPQ/FInjUGooKV+84L eNijZZ59KRLqTA9PzjFA0C/F+8KWneasqNtGlHnnoSj1obr38mzn8OzPO0puY8OkwoVXza +khR24JXJdjHy5nJ8mRvv7nQeVzs2UyMqKOsNQRU/sLiAGIfMh4Us/zwkrAQS8cEQsHhoe K1nW3jrXN7YqCHn4VuBnJAaPrdVUgOwf4vivRHanvturd1ScxruW5XTh1D93+dE5o5SCot JQdqb/WxDVuzRugdaw2YMnqY2hLywFd9BmuspC5DtPbGt6/CSh/EZiNr9h6U9A== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=Lc6Rag4q; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1679747349; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=qxb135tMfV97L34ZNSW1NXEWJUFIe5744xrzQdNprzI=; b=adsbRzAmi+CGfwJ4x+y3aRBRgkgu8aOwdYYdkw57YNCcwnqIM3OIvnzoGcspQkFOsRx2QE ikoR/y9xoAlyitoUHd5mjrYOy8uORzKs6czzq057lisSHUJvdMkIKognCWn1iJeoWiXpZx gUbiNpKltI2xHRzNWd45OkUp9akguHVbFfL2qoynsFGLvhWXhdQYKgdPlhiX9OsPMqFO4Z 15PEaB1C379oXQde97Lp3FbjxQxTfM11Bnab8YzrA7I8UUhygWskRXPx9r38UfRP93JYz0 0StEonCBUtTl2muCu+jbjD5lsQpuUtdmiSZYswVat4fDcLJXeVlJbUsejBQgnw== Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=Lc6Rag4q; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Scanner: scn1.migadu.com X-Migadu-Spam-Score: -0.63 X-Spam-Score: -0.63 X-Migadu-Queue-Id: ACCC664F4 X-TUID: bbOhmq65ZBpy Am Samstag, dem 25.03.2023 um 00:33 +0000 schrieb Bruno Victal: > On 2023-03-24 16:03, Maxim Cournoyer wrote:> Bruno Victal > writes: > > > =C2=A0 > > > +;; XXX: These will shadow the previous definition used by mpd > > > +;;=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 and cause warnings to be shown. May= be split the file > > > +;;=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 into audio/mpd.scm and audio/mympd.= scm ? > > > +#;(define-maybe/no-serialization user-account) > > > +#;(define-maybe/no-serialization user-group) > >=20 > > I'd rather keeping them together if possible; could the prefix > > trick be > > used with them?=C2=A0 No need for a hanging indent for continued text, > > here > > and for the other occurrences. >=20 > The prefix trick is unlikely to help since the previous ones already > use it. > --8<---------------cut here---------------start------------->8--- > (define-maybe user-account (prefix mpd-)) > (define-maybe user-group (prefix mpd-)) > --8<---------------cut here---------------end--------------->8--- >=20 > I'm using define-maybe as a =E2=80=9Ccheat=E2=80=9D here for prettier doc= umentation > generation. > Without define-maybe, the documentation is rendered as: >=20 > --8<---------------cut here---------------start------------->8--- > @item @code{user} (type: user-account) > The user to run mpd as. > --8<---------------cut here---------------end--------------->8--- >=20 > =E2=80=A6 which is the documentation format for a field that requires an > explicit value, even though we are setting a default one using %mpd- > account. >=20 > On the other hand, using define-maybe yields: >=20 > --8<---------------cut here---------------start------------->8--- > @item @code{user} (type: maybe-user-account) > The user to run mpd as. > --8<---------------cut here---------------end--------------->8--- >=20 > =E2=80=A6 which is the format for fields that do not require any manual > intervention. This is a slight abuse of define-maybe, though. define-maybe communicates, that the field having no value, i.e. not even a default value, is acceptable. Since we always need a user to run MPD with, this makes no sense semantically. > > The expressions commented; should they be?=C2=A0 On another note, '#;' > > appears undocumented, I'd avoid it until it is (and it's not > > necessary > > here). >=20 > They're commented because the =E2=80=9Cright way of things=E2=80=9D would= have that > the first maybe-user-account is mpd-configuration specific due to > (prefix mpd-) and that we should have another maybe-user-account that > is unrelated. Since we require "explicit" users in both cases, I think we can work around this by dropping the maybe, no? Cheers