From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id WNKtJ0u5QmL8GgEAgWs5BA (envelope-from ) for ; Tue, 29 Mar 2022 09:46:19 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id 4Ku3IEu5QmK7ZAAAG6o9tA (envelope-from ) for ; Tue, 29 Mar 2022 09:46:19 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 4057E2903A for ; Tue, 29 Mar 2022 09:46:19 +0200 (CEST) Received: from localhost ([::1]:56156 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nZ6YT-0004U6-Gg for larch@yhetil.org; Tue, 29 Mar 2022 03:46:17 -0400 Received: from eggs.gnu.org ([209.51.188.92]:35726) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nZ6YE-0004Ry-Sp for guix-patches@gnu.org; Tue, 29 Mar 2022 03:46:04 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:37540) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nZ6YE-0006yN-Jc for guix-patches@gnu.org; Tue, 29 Mar 2022 03:46:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nZ6YE-0004PF-E8 for guix-patches@gnu.org; Tue, 29 Mar 2022 03:46:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#54090] [PATCH v3] gnu: Add tessen. Resent-From: Tanguy LE CARROUR Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 29 Mar 2022 07:46:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54090 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 54090@debbugs.gnu.org, Andrew Tropin Cc: ludo@gnu.org, maximedevos@telenet.be, mail@nicolasgoaziou.fr Received: via spool by 54090-submit@debbugs.gnu.org id=B54090.164853996016927 (code B ref 54090); Tue, 29 Mar 2022 07:46:02 +0000 Received: (at 54090) by debbugs.gnu.org; 29 Mar 2022 07:46:00 +0000 Received: from localhost ([127.0.0.1]:59670 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nZ6YC-0004Ox-46 for submit@debbugs.gnu.org; Tue, 29 Mar 2022 03:46:00 -0400 Received: from relay3-d.mail.gandi.net ([217.70.183.195]:43491) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nZ6YA-0004Oe-9L for 54090@debbugs.gnu.org; Tue, 29 Mar 2022 03:45:58 -0400 Received: (Authenticated sender: tanguy@bioneland.org) by mail.gandi.net (Postfix) with ESMTPSA id 9922F60011; Tue, 29 Mar 2022 07:45:50 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable References: <20220221174340.2287-1-tanguy@bioneland.org> <20220311075412.17869-1-tanguy@bioneland.org> <87y20y2hlq.fsf@trop.in> <164822534548.5280.15088787905790996561@localhost> <87r16q2bva.fsf@trop.in> From: Tanguy LE CARROUR In-Reply-To: <87r16q2bva.fsf@trop.in> Date: Tue, 29 Mar 2022 09:45:49 +0200 Message-ID: <164853994977.10199.12301788225779739759@localhost> User-Agent: alot/0.10 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1648539979; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=adezWuzlgY1VeHYsGjpaM6GopGKjTCW8Z2JOipzrAxE=; b=WQkAbtL82hcIgyfLOhR5C2ma5Nufql0tNyvYH40GhHrAj7IZINGwW5b8JvnIHvk4iQPjBC 0hjnI2jiO5sKuUXf8toqh6//EvAe8kqOZXTBw8PJS8y06XJ4Rqji4kACq1BaGfTAEcOuV4 WCwT/4+oimTqVvmwVrjsxbRfSvy71T2qb3ODxTFIg0lKF5N1fRR4I4LurATiSVTqPldUkK ubJggnT9WebIFI5WTyWg+gR76Wxg5yVOD3CusG3bvPaNZ340dafq1KS/qSB08KH7FXGN4m RXAA49aODsGpQBf0sC/5Dy5rAwJ6OYbAedMEVccdCtNvboemj+xg2zWK1KKtdg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1648539979; a=rsa-sha256; cv=none; b=UZ15ucQOgupmsQbINOgD/K6z6ZG/cu4QahCe/JcXSrmKbA6TngrMqMPtn/aVRtXDSsGbtO 7deaSDpmbOZh6rOFzLYK0ueGzvUXIf+OrCUT08MMNVmfc8reVp1skbdbIeL2Ur0FPguifL jENgnnb8S7+0EPej2yXdUtUiQpJ+MG9R7KrXRKNPHcJCl2opb0vzHgF/QlSLgcz2Y0M515 vCoCIpg7DfFFyO+xlY5s7biZuvdfAZFd8NoTSXve6hU3VpL2xlO5uBd2f32X0CT8FL5syy cg1d6zDlKKgHH7mPaNTtiWkgMFrKCjQZLcjPKpyZLNGzHWXYFpZzJpbRi2Ru3w== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -3.37 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 4057E2903A X-Spam-Score: -3.37 X-Migadu-Scanner: scn0.migadu.com X-TUID: QpSuSjiHo8mj Hi Andrew, Quoting Andrew Tropin (2022-03-25 18:14:17) > > Quoting Andrew Tropin (2022-03-25 16:10:25) > >> On 2022-03-11 08:54, Tanguy Le Carrour wrote: > >>=20 > >> > * gnu/packages/password-utils.scm (tessen): New variable. > >> > [=E2=80=A6] > >> > + (arguments > >> > + (list #:tests? > >> > + #f ;no tests > >> > + #:phases > >> > + #~(modify-phases %standard-phases > >> > + (add-after 'unpack 'patch-wtype-path > >> > + (lambda* (#:key inputs #:allow-other-keys) > >> > + (substitute* "tessen" > >> > + (("wtype") (search-input-file inputs "/bin/wty= pe"))))) > >> > + (delete 'configure)) ;no configure script > >> > + #:make-flags > >> > + #~(list (string-append "PREFIX=3D" > >> > [=E2=80=A6] > >>=20 > >> Sorry, for comming up late, but the path to wl-copy binary should be > >> hardcoded as well. > >>=20 > >> /gnu/store/f48prcjwpw8wrfz0srjf096a9s8fja2w-profile/bin/tessen: line 4= 76: wl-copy: command not found > > > > Oh, my bad! I'm not using the "copy to clipboard" feature. Fortunatly, > > the patch is trivial. But, before submitting it, I have a question!=E2= =80=A6 > > > > Why not also add as inputs and substitute `pass`, `gopass`, `wofi`, >=20 > We can't hardcode pass, because it's an optional dependency with > explicit alternative and user can prefer gopass, so we keep tessen to > use the first option available in $PATH and fail if there is no pass or > gopass available. >=20 > The same for rofi, fuzzel, bemenu, wofi, dmenu. Due to design of tessen > we can't know "compile time", which one will be used. >=20 > > `notify-send`, `xdg-open`=E2=80=A6 that are also used by tessen?! >=20 > IMO, notify-send and xdg-open are good candidates for inclusion to > inputs. It would make sense, indeed! I'm submitting a patch using the same bug ID. Cheers, --=20 Tanguy