From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id 6HdiJGAAJWJkCwEAgWs5BA (envelope-from ) for ; Sun, 06 Mar 2022 19:41:36 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id aNIcIWAAJWJ2ZQAAauVa8A (envelope-from ) for ; Sun, 06 Mar 2022 19:41:36 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 03A5343B05 for ; Sun, 6 Mar 2022 19:41:36 +0100 (CET) Received: from localhost ([::1]:42356 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nQvoz-0001Mn-EX for larch@yhetil.org; Sun, 06 Mar 2022 13:41:35 -0500 Received: from eggs.gnu.org ([209.51.188.92]:40146) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nQvoU-0001Lu-3e for guix-patches@gnu.org; Sun, 06 Mar 2022 13:41:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:57831) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nQvoT-0002KJ-Qz for guix-patches@gnu.org; Sun, 06 Mar 2022 13:41:01 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nQvoT-0005P7-Ot for guix-patches@gnu.org; Sun, 06 Mar 2022 13:41:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#54090] [PATCH 0/2] gnu: Add tessen. Resent-From: Tanguy LE CARROUR Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 06 Mar 2022 18:41:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54090 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 54090@debbugs.gnu.org Received: via spool by 54090-submit@debbugs.gnu.org id=B54090.164659205420752 (code B ref 54090); Sun, 06 Mar 2022 18:41:01 +0000 Received: (at 54090) by debbugs.gnu.org; 6 Mar 2022 18:40:54 +0000 Received: from localhost ([127.0.0.1]:51728 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nQvoM-0005Od-65 for submit@debbugs.gnu.org; Sun, 06 Mar 2022 13:40:54 -0500 Received: from relay5-d.mail.gandi.net ([217.70.183.197]:33507) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nQvoK-0005OR-RT for 54090@debbugs.gnu.org; Sun, 06 Mar 2022 13:40:53 -0500 Received: (Authenticated sender: tanguy@bioneland.org) by mail.gandi.net (Postfix) with ESMTPSA id 69C531C0005; Sun, 6 Mar 2022 18:40:46 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable References: <20220221183304.5051-1-tanguy@bioneland.org> <20220221183304.5051-2-tanguy@bioneland.org> <87czj2vfcw.fsf_-_@gnu.org> From: Tanguy LE CARROUR In-Reply-To: <87czj2vfcw.fsf_-_@gnu.org> Date: Sun, 06 Mar 2022 19:40:45 +0100 Message-ID: <164659204547.2630.278024400267167099@localhost> User-Agent: alot/0.10 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1646592096; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=8sbDhLxL4b72Rs7/+jeNpcZFLnD7daOqhwQu44yszs8=; b=JXfu8WWkWj9M91Bf3zdI3o68P9AKyWrtBvPUSLX0IQqleIROSg/3hw5e6x41jxMfCDJaA9 thtROGnP+ztIMNrpTiE5q9/83yBzx7iP4AMZ7PsRcBpisZjy1hlZ0NBhownWkd4pe1R0lR xdYGPM4H1r2+gR0jSKEZO29xU7bJrvRF0sG7tNKuxiZNYz/+1CG9JRyWDKw64QHW5UvEOj ZYwK+sz/Rpo0YCnyoNFkB6Q/6Q3FLa51chyjY38wRIK3tl3m4TJL1X0BHRy7gL/PUTzXWI F7/rnYld65I7fqSv36/goIuA8q7Il/dSiWunsqJ3InLOtg+zvHlOzatcs1Q4/w== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1646592096; a=rsa-sha256; cv=none; b=RsNNvFX9hPut96MAeK0vSPl4CDDuqB/elgrHYUAi1W9p4WiYBSiQzipxxZkpr9v5X/vHrX L+E1ioCqBrbvM81okSKzJBQD4taGAaN9Eexh0KyNpEduRfo5lsxWrKcbFZVmqThb69i1Il 9zhpq+s0O/tz8sH74lZ3BMxT6CcJtOXjS1Y//HDU54prznUYP/6TjOiGzR67RlQPOasjil ZMFWXD6b17llNmW9CUYicCqQDICR6eUXexovPxjDTdFl1l+qI1dtcdXD/UL+SujNqI5cir NZG5R7WqvMuG1Q+5QHfHmkxjT+9PAb0U3BMcC+cRpattjTg4+V1JqwFGEQGCQQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -3.53 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 03A5343B05 X-Spam-Score: -3.53 X-Migadu-Scanner: scn0.migadu.com X-TUID: VrMXDvoW48cx Hi Ludo=E2=80=99 Thanks for reviewing! Quoting Ludovic Court=C3=A8s (2022-03-03 23:30:23) > Tanguy Le Carrour skribis: >=20 > > * gnu/packages/password-utils.scm (tessen): New variable. >=20 > [...] >=20 > > + (origin > > + (method url-fetch) > > + (uri > > + (string-append "https://raw.githubusercontent.com/ayushnix/tes= sen/" > > + "v" version "/tessen")) >=20 > Is this a stable URL? As stable as it can get, nowadays?! ^_^' Anyway, might not be a problem any more once you've reached the end of this email=E2=80=A6 > > + #:builder > > + (begin > > + (use-modules (guix build utils)) > > + (let ((source (string-append (assoc-ref %build-inputs "source= "))) > > + (script "tessen") > > + (out (assoc-ref %outputs "out"))) >=20 > Could you change that to use a gexp, along these lines: >=20 > #:builder #~(begin > =E2=80=A6 > (let ((source #$(package-source this-package)) > (out #$output) > =E2=80=A6) > =E2=80=A6)) Mmmm=E2=80=A6 I tried, but could not get anything to work! I ended up with: ``` #:builder #~(begin (use-modules (guix build utils)) (let ((source #$(package-source this-package)) (out #$output) (wtype #$(this-package-input "wtype")) (script "tessen")) (copy-file source script) (chmod script #o555) (substitute* script (("wtype") (string-append wtype "/bin/wtype"))) (install-file script (string-append out "/bin")))) ``` But it failed with: ``` ERROR: In procedure %resolve-variable: Unbound variable: gexp ``` > > + (propagated-inputs > > + (list wtype)) >=20 > Could you substitute* the absolute file name of =E2=80=98wtype=E2=80=99 i= n the script > instead of propagating? This, at least, I think I did properly! Without the Gexp, I wrote something that works: ``` (begin (use-modules (guix build utils)) (let ((source (string-append (assoc-ref %build-inputs "source"))) (script "tessen") (out (assoc-ref %outputs "out"))) (out (assoc-ref %outputs "out")) (wtype (assoc-ref %build-inputs "wtype")) (script "tessen")) (copy-file source script) (chmod script #o555) (install-file script (string-append out "/bin")))))) ``` But actually, I figured out that Tessen was not "just" a Bash script and could be "properly" `make install`-ed. So, I'll try to rewrite a proper package definition, fetching the source from Git and installing it the good old way! I can then use a more familiar `modify-phases` to substitute `wtype` in the script. Sounds like a plan to you?! Regards, --=20 Tanguy