From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id wHVgGSLo22GadwAAgWs5BA (envelope-from ) for ; Mon, 10 Jan 2022 09:02:42 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id QJ38ESLo22Gm7QAAG6o9tA (envelope-from ) for ; Mon, 10 Jan 2022 09:02:42 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 08B9711124 for ; Mon, 10 Jan 2022 09:02:42 +0100 (CET) Received: from localhost ([::1]:47378 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n6pdY-0002PW-OP for larch@yhetil.org; Mon, 10 Jan 2022 03:02:40 -0500 Received: from eggs.gnu.org ([209.51.188.92]:38814) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n6pOQ-0003fA-Hg for guix-patches@gnu.org; Mon, 10 Jan 2022 02:47:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:58819) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n6pOQ-0005qM-8A for guix-patches@gnu.org; Mon, 10 Jan 2022 02:47:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1n6pOP-0005Tk-US for guix-patches@gnu.org; Mon, 10 Jan 2022 02:47:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#53046] [PATCH] gnu: python-args: Patch reference to basestring. Resent-From: Tanguy LE CARROUR Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 10 Jan 2022 07:47:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53046 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxime Devos Cc: 53046@debbugs.gnu.org Received: via spool by 53046-submit@debbugs.gnu.org id=B53046.164180078721000 (code B ref 53046); Mon, 10 Jan 2022 07:47:01 +0000 Received: (at 53046) by debbugs.gnu.org; 10 Jan 2022 07:46:27 +0000 Received: from localhost ([127.0.0.1]:51722 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n6pNq-0005Se-Qq for submit@debbugs.gnu.org; Mon, 10 Jan 2022 02:46:26 -0500 Received: from relay1-d.mail.gandi.net ([217.70.183.193]:39811) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n6pNo-0005SM-Dd for 53046@debbugs.gnu.org; Mon, 10 Jan 2022 02:46:26 -0500 Received: (Authenticated sender: tanguy@bioneland.org) by relay1-d.mail.gandi.net (Postfix) with ESMTPSA id 00B23240007; Mon, 10 Jan 2022 07:46:16 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable References: From: Tanguy LE CARROUR In-Reply-To: Date: Mon, 10 Jan 2022 08:46:16 +0100 Message-ID: <164180077632.2244.9328700620299997460@localhost> User-Agent: alot/0.10 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1641801762; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=x9WQmZcFZ/w6AmujVHhj+zOG8LzsJHezd3DsCPikG34=; b=lmvAcVPdWgDdmPYPTJTcY/vllkQFL83gODotqlJVYNgDMQqvGYOkwSzTYSh3xvN3jQfmD4 JWKhQnjiJrZY8VfWss5qwmVF+ttMpLlPlxnGc7Zsn89vd23APkxS5qnMuOUqnTgT+esfxh GYvXZDBKkKeyREJWOTfTURgrVKomC3wk9Blu05joAnFKxxzDiOBb1tfXXPM/1eOe/IEzgG QWSNqjnnrWKx82sFi7C3DZRM+rQ+E6Y+twtiUF4Y6oe3uR+4nLb6lKZew4pPZ7+fXWCpmZ sMC1urGf0SsOpeXvdWvjoZJweTMF2GDrrucjsJnhAAQDvumhgqix68QbCZjdyQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1641801762; a=rsa-sha256; cv=none; b=ae4Z1Z3qji9aKHdG9b0/fanOW8q6dF+WYhIbyu9jm0oDXlniZpnIGM1xIyaaYd4C7UCfMy SyOdYrbSmNTCPrQBKRaX9FXdh6fVrkzTNzNOSDyOXQd2ZUcfFSbFuNBolISiSlQdYDvmfx r5ARGRikIs1FVQuCgKUBLrie+xU2ZVOKCe3GBxG9kWFC0tElS9scUiB6Xgr2CHD6W6OkOD nGjQdh1OpmHa6yL6UX8potPwEhA9e+reaZfJ7hTagl/o2U6QfTAYdjaZO/iZ68LHnqdygL 28mXw6FE7h2X0FYwVj6vwBmbyEEh0qzH3eK6uoCsF4Ig1SvjyVFPyf2zMQ20fg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -3.71 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 08B9711124 X-Spam-Score: -3.71 X-Migadu-Scanner: scn0.migadu.com X-TUID: 6AKJeLr8hv36 Hi Maxime, Quoting Maxime Devos (2022-01-09 22:15:41) > > This fixes a build failure in the 'sanity-check' phase. > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0 (substitute* "args.py" > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0 (("basestring") "str")) >=20 > Does it actually fix the build failure, or is it only suppressed? >=20 > Looking at >=20 > , > line 15--18, it appears that basestring should actually be basestring, > at least for Python 2 (python2-args). Believe it or not, I had totally forgotten about Python 2 when I wrote that! ^_^' > Also, returning #true isn't necessary anymore, and this seems better > fit for a snippet. OK, I'll fix it. Thanks for reviewing, --=20 Tanguy