From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id oIkfL1W9o2GDpQAAgWs5BA (envelope-from ) for ; Sun, 28 Nov 2021 18:33:09 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id cPa+KlW9o2G3GQAA1q6Kng (envelope-from ) for ; Sun, 28 Nov 2021 17:33:09 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 835428286 for ; Sun, 28 Nov 2021 18:33:09 +0100 (CET) Received: from localhost ([::1]:49280 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mrO32-0003Wr-K6 for larch@yhetil.org; Sun, 28 Nov 2021 12:33:08 -0500 Received: from eggs.gnu.org ([209.51.188.92]:33692) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mrO2x-0003TV-4t for guix-patches@gnu.org; Sun, 28 Nov 2021 12:33:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:53004) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mrO2w-0006ah-SZ for guix-patches@gnu.org; Sun, 28 Nov 2021 12:33:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mrO2w-0007W2-Ch for guix-patches@gnu.org; Sun, 28 Nov 2021 12:33:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#52075] [PATCH 3/4] gnu: Add python-notmuch2. Resent-From: Tanguy LE CARROUR Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 28 Nov 2021 17:33:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52075 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Jack Hill , Nicolas Goaziou Cc: 52075-done@debbugs.gnu.org Received: via spool by 52075-done@debbugs.gnu.org id=D52075.163812075028850 (code D ref 52075); Sun, 28 Nov 2021 17:33:02 +0000 Received: (at 52075-done) by debbugs.gnu.org; 28 Nov 2021 17:32:30 +0000 Received: from localhost ([127.0.0.1]:36317 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mrO2Q-0007VG-7c for submit@debbugs.gnu.org; Sun, 28 Nov 2021 12:32:30 -0500 Received: from relay2-d.mail.gandi.net ([217.70.183.194]:42025) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mrO2O-0007V1-7j for 52075-done@debbugs.gnu.org; Sun, 28 Nov 2021 12:32:29 -0500 Received: (Authenticated sender: tanguy@bioneland.org) by relay2-d.mail.gandi.net (Postfix) with ESMTPSA id 4F1E040005; Sun, 28 Nov 2021 17:32:20 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable References: <20211124100016.21905-1-tanguy@bioneland.org> <20211124100016.21905-3-tanguy@bioneland.org> <87fsrlsv81.fsf@nicolasgoaziou.fr> <163775787053.3163.3334445524894222634@localhost> <87y25dqy08.fsf@nicolasgoaziou.fr> <87r1b2ot7p.fsf@nicolasgoaziou.fr> From: Tanguy LE CARROUR In-Reply-To: <87r1b2ot7p.fsf@nicolasgoaziou.fr> Date: Sun, 28 Nov 2021 18:32:20 +0100 Message-ID: <163812074047.4714.14334259292132064805@localhost> User-Agent: alot/0.10 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1638120789; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=kf7Bq80BcuKnQl/NfloyZFHO+R7PA5y0OJamS6/Dww0=; b=mk6XR86dEzHbiPgRHvs8KKWzDU4dPUQ/1b2cFa9C8fZEPEPBjvTlrvCtYs4y3PtxAQf7Ww 0+kqxbxYCE9p+v5fxuMgwRdNcub1PcA00VhAJZ7o43e9o4NV6y9v9sayIXXjMvxv4lXaCI Eeln24GwNYL2qf5+e0128SCvhEY5fsxOYXyEZYUDn2yFtmpdYdrIzv9BmlkwlMZhhnTAGw ROYxqyTafLU53qzApbYfsdMppfNHMhFbXull36QNw5/i2LuYWawRTbxYgQQOIiLsITuIXq pgrDqq6BqbhzA2305TBNXNV6o8LXNWfdAJ+4Z9uabJeI/8bXfMdvc1iM1pwcbg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1638120789; a=rsa-sha256; cv=none; b=Dji+5roJwRvR5UQIzWXYvCU4rG8d16SP/EsoQC4i1I038D9zjktuqSB3XxsXE77GS0QwmF /tK+JIMI/H4EJ1CTzSBu1UdX8poRrDyOEYWpIxuxZ/KkMmX5wYKzgG5MSbNr94yu/ejvUR 8qlF8EjGWNwFLND7AFQ3rIjzDst2WtZLB7rfbxnhJC1RMt8l4i1XsaqZ8Rz3E2r8nuCswH ogWIJAY4QucsqePP5JsPzFuF80MO47SfF8Itd6tNSQDxVEmZHmyuRfkRtNOdxoIQ2b6NP3 Hn25igiA8rnsmoDT7rboSY6+xWS5EY9q1ZXrN1ilL85vR0TPVR8RSw7tGe+qfA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -2.51 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 835428286 X-Spam-Score: -2.51 X-Migadu-Scanner: scn1.migadu.com X-TUID: ho85oddbC6GC Hi, Quoting Nicolas Goaziou (2021-11-27 10:15:06) > Jack Hill writes: > [=E2=80=A6] > > I don't have an objection to the version using inheritance. >=20 > I applied the patch set. Thanks to Tanguy for it, and to you for the > feedback! Thanks! > > I am still curious in learning about the differences between the two > > packages if only for my own edification. >=20 > I cannot help here, unfortunately. `python-notmuch2` contains the new binding that uses CFFI. `python-notmuch` contains the "old" binding which, I guess, will be deprecated at some point. There's not much in the documentation or the mailing list about why they decided to work on the new binding, though. > > Hopefully that clarifies, and sorry for adding noise to this review. >=20 > No problem! I think you raise an interesting question: does inheritance > in Guix imply strong internal dependency between the project inheriting > and the one being inherited? Actually, I have to admit that I have the same reserve about using inheritance. But it's totally fine with me to use it as a mechanism to reduce code duplication. Regards, --=20 Tanguy