From: Tanguy LE CARROUR <tanguy@bioneland.org>
To: Jack Hill <jackhill@jackhill.us>,
Nicolas Goaziou <mail@nicolasgoaziou.fr>
Cc: 52075-done@debbugs.gnu.org
Subject: [bug#52075] [PATCH 3/4] gnu: Add python-notmuch2.
Date: Sun, 28 Nov 2021 18:32:20 +0100 [thread overview]
Message-ID: <163812074047.4714.14334259292132064805@localhost> (raw)
In-Reply-To: <87r1b2ot7p.fsf@nicolasgoaziou.fr>
Hi,
Quoting Nicolas Goaziou (2021-11-27 10:15:06)
> Jack Hill <jackhill@jackhill.us> writes:
> […]
> > I don't have an objection to the version using inheritance.
>
> I applied the patch set. Thanks to Tanguy for it, and to you for the
> feedback!
Thanks!
> > I am still curious in learning about the differences between the two
> > packages if only for my own edification.
>
> I cannot help here, unfortunately.
`python-notmuch2` contains the new binding that uses CFFI.
`python-notmuch` contains the "old" binding which, I guess, will be
deprecated at some point.
There's not much in the documentation or the mailing list about why they
decided to work on the new binding, though.
> > Hopefully that clarifies, and sorry for adding noise to this review.
>
> No problem! I think you raise an interesting question: does inheritance
> in Guix imply strong internal dependency between the project inheriting
> and the one being inherited?
Actually, I have to admit that I have the same reserve about using
inheritance. But it's totally fine with me to use it as a mechanism
to reduce code duplication.
Regards,
--
Tanguy
next prev parent reply other threads:[~2021-11-28 17:33 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-24 9:57 [bug#52075] [PATCH 0/4] gnu: alot: Update to 0.10 Tanguy Le Carrour
2021-11-24 10:00 ` [bug#52075] [PATCH 1/4] gnu: python-urwidtrees: Update to 1.0.3 Tanguy Le Carrour
2021-11-24 10:00 ` [bug#52075] [PATCH 2/4] gnu: notmuch: Update to 0.34.1 Tanguy Le Carrour
2021-11-24 10:00 ` [bug#52075] [PATCH 3/4] gnu: Add python-notmuch2 Tanguy Le Carrour
2021-11-24 10:29 ` Nicolas Goaziou
2021-11-24 12:44 ` Tanguy LE CARROUR
2021-11-24 13:21 ` Nicolas Goaziou
2021-11-24 16:53 ` Jack Hill
2021-11-24 17:11 ` Nicolas Goaziou
2021-11-24 17:41 ` Jack Hill
2021-11-27 9:15 ` bug#52075: " Nicolas Goaziou
2021-11-28 17:32 ` Tanguy LE CARROUR [this message]
2021-11-24 10:00 ` [bug#52075] [PATCH 4/4] gnu: alot: Update to 0.10 Tanguy Le Carrour
2021-11-24 14:00 ` [bug#52075] [PATCH v2 1/4] gnu: python-urwidtrees: Update to 1.0.3 Tanguy Le Carrour
2021-11-24 14:00 ` [bug#52075] [PATCH v2 2/4] gnu: notmuch: Update to 0.34.1 Tanguy Le Carrour
2021-11-24 14:00 ` [bug#52075] [PATCH v2 3/4] gnu: Add python-notmuch2 Tanguy Le Carrour
2021-11-24 14:00 ` [bug#52075] [PATCH v2 4/4] gnu: alot: Update to 0.10 Tanguy Le Carrour
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=163812074047.4714.14334259292132064805@localhost \
--to=tanguy@bioneland.org \
--cc=52075-done@debbugs.gnu.org \
--cc=jackhill@jackhill.us \
--cc=mail@nicolasgoaziou.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).