From: Tanguy LE CARROUR <tanguy@bioneland.org>
To: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Cc: 52075@debbugs.gnu.org
Subject: [bug#52075] [PATCH 3/4] gnu: Add python-notmuch2.
Date: Wed, 24 Nov 2021 13:44:30 +0100 [thread overview]
Message-ID: <163775787053.3163.3334445524894222634@localhost> (raw)
In-Reply-To: <87fsrlsv81.fsf@nicolasgoaziou.fr>
Hi Nicolas,
Thanks for reviewing!
Quoting Nicolas Goaziou (2021-11-24 11:29:02)
> Tanguy Le Carrour <tanguy@bioneland.org> writes:
>
> > * gnu/packages/mail.scm (python-notmuch2): New variable.
>
> Thanks.
>
> Would it be possible (or appropriate) to inherit from python-notmuch
> instead?
Possible? Yes! Thanks for suggesting.
```
diff --git a/gnu/packages/mail.scm b/gnu/packages/mail.scm
index 1069aac16c..e1e199c656 100644
--- a/gnu/packages/mail.scm
+++ b/gnu/packages/mail.scm
@@ -1514,12 +1514,8 @@ (define-public python2-notmuch
(define-public python-notmuch2
(package
+ (inherit python-notmuch)
(name "python-notmuch2")
- (version (package-version notmuch))
- ;; The bindings are distributed via the notmuch release tarball.
- (source (package-source notmuch))
- (build-system python-build-system)
- (inputs `(("notmuch" ,notmuch)))
(propagated-inputs `(("python-cffi" ,python-cffi)))
(arguments
`(#:phases
@@ -1528,11 +1524,7 @@ (define-public python-notmuch2
;; tree, so chdir into it before building.
(add-after 'unpack 'enter-python-dir
(lambda _ (chdir "bindings/python-cffi") #t)))))
- (home-page (package-home-page notmuch))
(synopsis "Pythonic bindings for the notmuch mail database using CFFI")
- (description
- "This package provides Python bindings to use the Notmuch mail indexing
-and search library.")
(license license:gpl3+)))
```
Appropriate? I have no idea!
If this version is OK with you, I can submit a V2 of the patch set.
Regards,
--
Tanguy
next prev parent reply other threads:[~2021-11-24 12:45 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-24 9:57 [bug#52075] [PATCH 0/4] gnu: alot: Update to 0.10 Tanguy Le Carrour
2021-11-24 10:00 ` [bug#52075] [PATCH 1/4] gnu: python-urwidtrees: Update to 1.0.3 Tanguy Le Carrour
2021-11-24 10:00 ` [bug#52075] [PATCH 2/4] gnu: notmuch: Update to 0.34.1 Tanguy Le Carrour
2021-11-24 10:00 ` [bug#52075] [PATCH 3/4] gnu: Add python-notmuch2 Tanguy Le Carrour
2021-11-24 10:29 ` Nicolas Goaziou
2021-11-24 12:44 ` Tanguy LE CARROUR [this message]
2021-11-24 13:21 ` Nicolas Goaziou
2021-11-24 16:53 ` Jack Hill
2021-11-24 17:11 ` Nicolas Goaziou
2021-11-24 17:41 ` Jack Hill
2021-11-27 9:15 ` bug#52075: " Nicolas Goaziou
2021-11-28 17:32 ` [bug#52075] " Tanguy LE CARROUR
2021-11-24 10:00 ` [bug#52075] [PATCH 4/4] gnu: alot: Update to 0.10 Tanguy Le Carrour
2021-11-24 14:00 ` [bug#52075] [PATCH v2 1/4] gnu: python-urwidtrees: Update to 1.0.3 Tanguy Le Carrour
2021-11-24 14:00 ` [bug#52075] [PATCH v2 2/4] gnu: notmuch: Update to 0.34.1 Tanguy Le Carrour
2021-11-24 14:00 ` [bug#52075] [PATCH v2 3/4] gnu: Add python-notmuch2 Tanguy Le Carrour
2021-11-24 14:00 ` [bug#52075] [PATCH v2 4/4] gnu: alot: Update to 0.10 Tanguy Le Carrour
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=163775787053.3163.3334445524894222634@localhost \
--to=tanguy@bioneland.org \
--cc=52075@debbugs.gnu.org \
--cc=mail@nicolasgoaziou.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).