From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id 3OC/NXDYvGACewAAgWs5BA (envelope-from ) for ; Sun, 06 Jun 2021 16:15:12 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id yD1qMHDYvGCzAgAAbx9fmQ (envelope-from ) for ; Sun, 06 Jun 2021 14:15:12 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 4D910A618 for ; Sun, 6 Jun 2021 16:15:12 +0200 (CEST) Received: from localhost ([::1]:43698 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lptYV-0007Dk-3d for larch@yhetil.org; Sun, 06 Jun 2021 10:15:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44738) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lptYM-0007DJ-QB for guix-patches@gnu.org; Sun, 06 Jun 2021 10:15:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:42132) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lptYM-0000p5-Du for guix-patches@gnu.org; Sun, 06 Jun 2021 10:15:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lptYM-0001vU-8M for guix-patches@gnu.org; Sun, 06 Jun 2021 10:15:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#46616] [PATCH] gnu: Add python-tldr. Resent-From: Tanguy LE CARROUR Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 06 Jun 2021 14:15:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46616 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Vinicius Monego Cc: 46616@debbugs.gnu.org Received: via spool by 46616-submit@debbugs.gnu.org id=B46616.16229888597331 (code B ref 46616); Sun, 06 Jun 2021 14:15:02 +0000 Received: (at 46616) by debbugs.gnu.org; 6 Jun 2021 14:14:19 +0000 Received: from localhost ([127.0.0.1]:53677 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lptXf-0001uB-HN for submit@debbugs.gnu.org; Sun, 06 Jun 2021 10:14:19 -0400 Received: from relay5-d.mail.gandi.net ([217.70.183.197]:52835) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lptXc-0001tq-NS for 46616@debbugs.gnu.org; Sun, 06 Jun 2021 10:14:18 -0400 Received: (Authenticated sender: tanguy@bioneland.org) by relay5-d.mail.gandi.net (Postfix) with ESMTPSA id 8D68D1C0002; Sun, 6 Jun 2021 14:14:09 +0000 (UTC) Date: Sun, 06 Jun 2021 16:14:06 +0200 From: Tanguy LE CARROUR References: <20210218140620.15816-1-tanguy@bioneland.org> <05b49dc60b6a7c24ffd269293b9f9536abda14f2.camel@posteo.net> In-Reply-To: <05b49dc60b6a7c24ffd269293b9f9536abda14f2.camel@posteo.net> MIME-Version: 1.0 User-Agent: astroid/0.15.0 (https://github.com/astroidmail/astroid) Message-Id: <1622988617.5jhzwoy3iq.astroid@melmoth.none> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1622988912; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=GXcVoCdyhAUmRqpFUdSVjEEwjdgrvGjFh65KB4JPZBU=; b=RkBs8qYGWPhQcuKHbUjBPdJ9EhNRIlhW+DlUlMpjE4YafRqSsB8tJQpBpCjmJ174A78PIO nJOvQmm6i5eksEQmx8UMQ1MCRdDoxBCUMepR8So13y6har4bQE/cn6jMRtDL26K0mlwR4b REqyl6m/+hx5lykt72lsauDQ+H6dNRAGhuAby6AU6DtVEsI41sO3+6EHMNmhwEtFVbaJzj 1vIm6HiHDUTeMn2DU3z8n2nF6H71WrbLC3ONfwq2PTkkWDxYvi41lGRNsSVtw8t8y//Gbd 2AoIPvM7MTJKgkxW0xFiLQwyDdmNXfQVrFx9uYTxyBBllXOvjEkUFdA2srY+XA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1622988912; a=rsa-sha256; cv=none; b=MJHnzypNwfr/o9EQ56Cdbs9NVh6Zm8N0jNCy9wDzVQjEtHo7y08cxBy9O9RRKyCLb6cG8m 5cwmMEtWTkZFdZHLQR4Qta+ZzXpQ0bkcP1rhjxgY+buNl5bp2uq2PPo2IzNOS1QOYXn+5q dVYdAQxkYfTfqGKLz+zNKfFcpMBpA/Yu96Dn6GPlL/ylH00D4YAOhbe6h6mf5AQpanG4vb TpyaU6ATTuWb0AKjxjSrLyH/CWKhQ5kEeK+DzUxZV0cCkxkjNqaFJDvHBnDJlzq3U/zxSL 4PEbavzBZRyPynclJBwmCSmpCMUoY/VtRvFcfzl4mwGUA+SgAFtFm58XmllZZA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -2.43 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 4D910A618 X-Spam-Score: -2.43 X-Migadu-Scanner: scn1.migadu.com X-TUID: ge58e5uK2SQ2 Hi Vinicius, Thanks for reviewing this patch, and sorry for the late answer! Excerpts from Vinicius Monego's message of May 23, 2021 11:15 pm: > Em qui, 2021-02-18 =C3=A0s 15:06 +0100, Tanguy Le Carrour escreveu: >> * gnu/packages/python-xyz.scm (python-tldr): New variable. >> --- >> =C2=A0gnu/packages/python-xyz.scm | 28 +++++++++++++++++++++++++++- >=20 > [...] >=20 >> +(define-public python-tldr >> +=C2=A0 (package >> +=C2=A0=C2=A0=C2=A0 (name "python-tldr") >=20 > I noticed that this program is a command line tool. It should be named > 'tldr' only and be moved to another file. Perhaps to man.scm? Your suggestions make sense, but there's another `tldr` client. Namely `ghc-tldr`. It's defined in `gnu/packages/haskell-xyz.scm`. If it's okay with you, I'll leave `python-tldr` in `gnu/packages/python-xyz= .scm`. >> +=C2=A0=C2=A0=C2=A0 (source >> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (origin >> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (method url-fetch) >> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (uri (pypi-uri "tldr" versio= n)) >> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (sha256 >> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (base32 >> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 "00h43xjrzrayy1g= ysvmql5kfabk2d8xraih68d41616brdvb1xvf")))) >> +=C2=A0=C2=A0=C2=A0 (build-system python-build-system) >> +=C2=A0=C2=A0=C2=A0 (native-inputs >> +=C2=A0=C2=A0=C2=A0=C2=A0 `(("python-pytest" ,python-pytest) >> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ("python-pytest-runner" ,python-py= test-runner))) >=20 > The tests for this one are not distributed in the PyPI release. Could > you source from the homepage instead? >=20 > There is one test that tries to open a network connection, it will have > to be skipped. Done. >=20 >> +=C2=A0=C2=A0=C2=A0 (propagated-inputs >> +=C2=A0=C2=A0=C2=A0=C2=A0 `(("python-argcomplete" ,python-argcomplete) >> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ("python-colorama" ,python-coloram= a) >> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ("python-termcolor" ,python-termco= lor))) >=20 > If it is only a command line tool, inputs should be normal inputs here. Done. >> +=C2=A0=C2=A0=C2=A0 (description "This package provides the `tldr' comma= nd allowing >> users >> +to view `tldr' pages from a shell.=C2=A0 The `tldr' pages are a communi= ty >> effort >> +to simplify the man pages with practical examples.") >=20 > The linter made this complaint for the description: "use @code or > similar ornament instead of quotes". Done. The new patch is following in another email=E2=80=A6 Regards, --=20 Tanguy