unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Tanguy LE CARROUR <tanguy@bioneland.org>
To: 45003-done@debbugs.gnu.org, Marius Bakke <marius@gnu.org>
Subject: [bug#45003] [PATCH] gnu: poetry: Fix a problem with a dependency.
Date: Fri, 04 Dec 2020 08:35:57 +0100	[thread overview]
Message-ID: <1607066633.9zez5fcynx.astroid@melmoth.none> (raw)
In-Reply-To: <87o8jaimtw.fsf@gnu.org>

*Oups*, I sent my message to quickly…


Excerpts from Marius Bakke's message of December 3, 2020 10:47 pm:
> Updating packaging alone is also a staging-level change, so I did not
> dig much further.  But there is some room for improvement here.  Maybe
> by (setenv "PYTHONPATH" (string-append ".:" (getenv "PYTHONPATH"))) ?

Actually, I noticed some weird things when using Poetry, that might be
related to PYTHONPATH. Even if it was installed in its own profile, it
was using python packages installed outside of it. Can't remember for
sure, but I think it was `virtualenv`.
I had to unset my PYTHONPATH to make it use the ones installed in the profile.
But, now that the versions are the same in the default profile and in
this dedicated Poetry profile, everything seems to be working just fine.


> I also wonder whether pytest needs to propagate packaging at all, or if
> wrapping is enough.  Do you know how common it is to "import pytest" or
> "from pytest import foo", and whether those code paths would need
> 'packaging'?

Usually, one would only do this in the test suite, or in a package that
extends pytest behaviour. At least it's what I see from the 450,942 results
I've found on Github. But I have to confess that I did not go through
all of them! ^_^'

Regards

-- 
Tanguy




      parent reply	other threads:[~2020-12-04  7:37 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-02  8:33 [bug#45003] [PATCH] gnu: poetry: Fix a problem with a dependency Tanguy Le Carrour
2020-12-03 21:47 ` bug#45003: " Marius Bakke
2020-12-04  7:23   ` [bug#45003] " Tanguy LE CARROUR
2020-12-04  7:35   ` Tanguy LE CARROUR [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1607066633.9zez5fcynx.astroid@melmoth.none \
    --to=tanguy@bioneland.org \
    --cc=45003-done@debbugs.gnu.org \
    --cc=marius@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).