From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id CJPsBDLatF+iPwAA0tVLHw (envelope-from ) for ; Wed, 18 Nov 2020 08:24:18 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id 6CS2ADLatF/PMQAAbx9fmQ (envelope-from ) for ; Wed, 18 Nov 2020 08:24:18 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 014CF9400D3 for ; Wed, 18 Nov 2020 08:24:17 +0000 (UTC) Received: from localhost ([::1]:54180 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kfIlD-0005si-Jg for larch@yhetil.org; Wed, 18 Nov 2020 03:24:15 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:48728) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kfIl0-0005sY-VL for guix-patches@gnu.org; Wed, 18 Nov 2020 03:24:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:50590) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kfIl0-0003g8-Ky for guix-patches@gnu.org; Wed, 18 Nov 2020 03:24:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kfIl0-0004Sx-HD for guix-patches@gnu.org; Wed, 18 Nov 2020 03:24:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#44628] [PATCH 2/2] gnu: Add astroid. Resent-From: Tanguy LE CARROUR Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 18 Nov 2020 08:24:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44628 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Efraim Flashner Cc: 44628-done@debbugs.gnu.org Received: via spool by 44628-done@debbugs.gnu.org id=D44628.160568781317130 (code D ref 44628); Wed, 18 Nov 2020 08:24:02 +0000 Received: (at 44628-done) by debbugs.gnu.org; 18 Nov 2020 08:23:33 +0000 Received: from localhost ([127.0.0.1]:33903 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kfIkX-0004SD-5m for submit@debbugs.gnu.org; Wed, 18 Nov 2020 03:23:33 -0500 Received: from relay10.mail.gandi.net ([217.70.178.230]:56795) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kfIkT-0004Rw-CU for 44628-done@debbugs.gnu.org; Wed, 18 Nov 2020 03:23:31 -0500 Received: from localhost (static-176-185-184-238.ftth.abo.bbox.fr [176.185.184.238]) (Authenticated sender: tanguy@bioneland.org) by relay10.mail.gandi.net (Postfix) with ESMTPSA id 284E224001B; Wed, 18 Nov 2020 08:23:21 +0000 (UTC) Date: Wed, 18 Nov 2020 09:23:19 +0100 From: Tanguy LE CARROUR References: <20201114092611.6225-1-tanguy@bioneland.org> <20201114092611.6225-2-tanguy@bioneland.org> <20201117193755.GX987@E5400> In-Reply-To: <20201117193755.GX987@E5400> MIME-Version: 1.0 User-Agent: astroid/0.15.0 (https://github.com/astroidmail/astroid) Message-Id: <1605687026.i9n46bask7.astroid@melmoth.none> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -1.7 (-) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: ns3122888.ip-94-23-21.eu Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -1.01 X-TUID: 1tRD8Cx2kWps Hi Efraim, Thanks for the time and efforts you put into reviewing my patch! I really appreciate it! Excerpts from Efraim Flashner's message of November 17, 2020 8:37 pm: > This patch I went down a rabbit hole touching it up. >=20 > On Sat, Nov 14, 2020 at 10:26:11AM +0100, Tanguy Le Carrour wrote: >> * gnu/packages/mail.scm (astroid): New variable. >> --- >> gnu/packages/mail.scm | 60 +++++++++++++++++++++++++++++++++++++++++++ >> 1 file changed, 60 insertions(+) >>=20 >> diff --git a/gnu/packages/mail.scm b/gnu/packages/mail.scm >> index fcd593c356..d2af1ce10c 100644 >> --- a/gnu/packages/mail.scm >> +++ b/gnu/packages/mail.scm >> @@ -63,6 +63,7 @@ >> #:use-module (gnu packages base) >> #:use-module (gnu packages bash) >> #:use-module (gnu packages bison) >> + #:use-module (gnu packages boost) >> #:use-module (gnu packages calendar) >> #:use-module (gnu packages check) >> #:use-module (gnu packages compression) >> @@ -107,6 +108,7 @@ >> #:use-module (gnu packages man) >> #:use-module (gnu packages ncurses) >> #:use-module (gnu packages networking) >> + #:use-module (gnu packages ninja) >> #:use-module (gnu packages openldap) >> #:use-module (gnu packages onc-rpc) >> #:use-module (gnu packages pcre) >> @@ -114,6 +116,7 @@ >> #:use-module (gnu packages perl-check) >> #:use-module (gnu packages perl-web) >> #:use-module (gnu packages pkg-config) >> + #:use-module (gnu packages protobuf) >> #:use-module (gnu packages python) >> #:use-module (gnu packages python-check) >> #:use-module (gnu packages python-crypto) >> @@ -703,6 +706,63 @@ mailpack. What can alterMIME do? >> (license (list (license:non-copyleft "file://LICENSE") >> license:bsd-3)))) >> =20 >> +(define-public astroid >> + (package >> + (name "astroid") >> + (version "0.15") >> + (source >> + (origin >> + (method git-fetch) >> + (uri (git-reference >> + (url "https://github.com/astroidmail/astroid") >> + (commit (string-append "v" version)))) >> + (file-name (git-file-name name version)) >> + (sha256 >> + (base32 "11cxbva9ni98gii59xmbxh4c6idcg3mg0pgdsp1c3j0yg7ix0lj3")= ))) >=20 > I added a snippet for the test suite to adjust for gmime@3.2.3+ > https://github.com/astroidmail/astroid/pull/685 This has been merged, but there's been no release yet. Is it a case where I could do a "version release", with a commit number, like for instance what is done for `emacs-atom-one-dark-theme`, to make the latest code available? If yes, should it be a different variable name, like `astroid-latest`? >> + (build-system cmake-build-system) >> + (arguments >> + `(#:configure-flags (list "-GNinja") >> + #:phases >> + (modify-phases %standard-phases >> + (replace 'build >> + (lambda _ >> + (invoke "ninja" "-j" (number->string (parallel-job-count))= ))) >> + (replace 'check >> + (lambda _ >> + (invoke "echo" "ninja" "test"))) >=20 > This just echos "ninja test" but doesn't actually run anything. I > changed it to run (invoke "ctest" ".") Then I added a phase to start the > xorg display for the tests and another phase to work around not getting > the test suite to recognize the plugin modules. Shame on me!! :-( I added the "echo" to save some time, and forgot to remove it! Next time, I'll put a comment alongside it! But I thought `ninja test` was successfully running all the tests! Strange. >=20 >> + (replace 'install >> + (lambda _ >> + (invoke "ninja" "install")))))) >=20 > The native-inputs should have a bunch moved to regular inputs. It was > also missing gnupg and w3m, needed for the test suite. I removed > adwaita-icon-theme from propagated inputs, we try not to propagate icon > sets. I also sorted them alphabetically. The problem is that=E2=80=A6 the software is built, but does not work! I had to put back `gsettings-desktop-schemas` and `adwaita-icon-theme` back into the propagated inputs to make it work. Without the first one, it does not event start. Without the second, one cannot switch to the thread view. I'll submit a new patch for that. >> + (native-inputs >> + `(("gtkmm" ,gtkmm) >> + ("gmime" ,gmime) >> + ("gobject-introspection" ,gobject-introspection) >> + ("webkitgtk" ,webkitgtk) >> + ("pkg-config" ,pkg-config) >> + ("ninja" ,ninja) >> + ("ronn" ,ronn) >> + ("libsass" ,libsass) >> + ("libpeas" ,libpeas) >> + ("boost" ,boost) >> + ("glib-networking" ,glib-networking) >> + ("protobuf" ,protobuf))) >> + (inputs >> + `(("python" ,python) >> + ("notmuch" ,notmuch))) >> + (propagated-inputs >> + `(("gsettings-desktop-schemas" ,gsettings-desktop-schemas) >> + ("adwaita-icon-theme" ,adwaita-icon-theme))) >> + (home-page "https://astroidmail.github.io/") >> + (synopsis "GTK frontend to the notmuch mail system") >> + (description >> + "Astroid is a lightweight and fast Mail User Agent that provides >> +a graphical interface to searching, display and composing email, >> +organized in thread and tags. Astroid uses the notmuch backend for bla= zingly >> +fast searches through tons of email. Astroid searches, displays and >> +compose emails =E2=80=94 and relies on other programs for fetching, >> +syncing and sending email. ") >> + (license license:gpl3+))) >=20 > There's also a bit of borrowed code from geary and gmime, under the > lgpl2.1+, so I added that to the license list. It is true that the > entire work is under the gpl3+ but we try to be more specific if > possible. Thaaaaaanks again for your time and effort! --=20 Tanguy