From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id KHKcCjEMo2MtxAAAbAwnHQ (envelope-from ) for ; Wed, 21 Dec 2022 14:37:53 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id QHuFCjEMo2Oi3AAAauVa8A (envelope-from ) for ; Wed, 21 Dec 2022 14:37:53 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id C37F8D5DA for ; Wed, 21 Dec 2022 14:37:52 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p7z2q-0006Ay-TX; Wed, 21 Dec 2022 08:22:05 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p7z2o-00068G-R4 for guix-patches@gnu.org; Wed, 21 Dec 2022 08:22:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p7z2o-0007Dr-JV for guix-patches@gnu.org; Wed, 21 Dec 2022 08:22:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p7z2o-0003dI-Ef for guix-patches@gnu.org; Wed, 21 Dec 2022 08:22:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#60014] [PATCH] activation: make install-special-file match against pairs as well. Resent-From: mirai Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 21 Dec 2022 13:22:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60014 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= , Josselin Poiret Cc: 60014@debbugs.gnu.org Received: via spool by 60014-submit@debbugs.gnu.org id=B60014.167162886913948 (code B ref 60014); Wed, 21 Dec 2022 13:22:02 +0000 Received: (at 60014) by debbugs.gnu.org; 21 Dec 2022 13:21:09 +0000 Received: from localhost ([127.0.0.1]:51850 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p7z1x-0003cu-42 for submit@debbugs.gnu.org; Wed, 21 Dec 2022 08:21:09 -0500 Received: from smtpm3.myservices.hosting ([185.26.105.234]:46270) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p7z1r-0003co-KM for 60014@debbugs.gnu.org; Wed, 21 Dec 2022 08:21:07 -0500 Received: from mail1.netim.hosting (unknown [185.26.106.172]) by smtpm3.myservices.hosting (Postfix) with ESMTP id D0A1420DD4; Wed, 21 Dec 2022 14:20:58 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by mail1.netim.hosting (Postfix) with ESMTP id 4586780096; Wed, 21 Dec 2022 14:20:58 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at mail1.netim.hosting Received: from mail1.netim.hosting ([127.0.0.1]) by localhost (mail1-1.netim.hosting [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id Zo6O-6mUsb2C; Wed, 21 Dec 2022 14:20:57 +0100 (CET) Received: from [192.168.1.239] (unknown [10.192.1.83]) (Authenticated sender: lumen@makinata.eu) by mail1.netim.hosting (Postfix) with ESMTPSA id 7B72680093; Wed, 21 Dec 2022 14:20:57 +0100 (CET) Message-ID: <15a36fc9-05ce-d599-5539-166de64e9f04@makinata.eu> Date: Wed, 21 Dec 2022 13:20:51 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Content-Language: en-US References: <43e937e1625b47a80887e68847fb8a8811d3f39f.1670867103.git.mirai@makinata.eu> <87k02wfjk5.fsf@jpoiret.xyz> <87ili66sk1.fsf_-_@gnu.org> From: mirai In-Reply-To: <87ili66sk1.fsf_-_@gnu.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1671629872; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=wXaM+OzYofVOOHH6A2BJiZ8sZxjvcsvlMlSoK8I1tL8=; b=CKTiARQ4mL0TcSes8p+7YGftsWjpCWqLN7aHddCzKWscgZAJzTc5iYrbeF3PHTanCRQXqp kldNRT4RaSAkNPSk+ywL3bmMZRqCjmZwC+KyN+JoZUgrW3KQzkkGfgmRZi8I8Dmd/xmxIf ZV2+2EiyS1ot4m5KLxqZD5XCHBb3A1cJn3PM/JjzSmGKTlFiv5C5Sjpv5nbcBZ+xC5ykfr xtCTnyEDL9O28yNIhPwtsJI5WHo5+a3BfctF0DGAwDma7sX+3ZDHUSJssWwlF451P2+ytc 3xN7/LG4bgnSX9wSP36YTg40boNTNlluCH5YFRRFHgQWWlFSB/iDcJDL6r+4WA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Seal: i=1; s=key1; d=yhetil.org; t=1671629872; a=rsa-sha256; cv=none; b=L4x+6ms/8XQV8Ndp+MTeWRnGBnSHEgh9GF+eeqAJRFFTPEqmIlTea8P7CPfYt5zndX6rT5 a7mcPXYX1uRcMBzkHbEwjSExdczPIUi4JRAjviPZt6Sd3lYWRW+XgHFrLCEwfvQNKiiR2O 70VD5aMtvnbzDO84SBRCKvQHWb8Am7yjP4wV/rzJvv5/0G1oSLudZFPZcmZGa4LRQ0WdMH H4l8q4Ca6+Hs/wtCs5tPm5dw2VLC5C3bWXxtKq3e92IpZ0+3qrML2Q7UeAZGOJnMGL5l8l R7H7qSoJMJ+R0RnHiM1lDPAsc6sg5YK+xKfs8Kb/aS5xR4TrtNG5NzD7SUHP0g== X-Spam-Score: -2.99 X-Migadu-Queue-Id: C37F8D5DA Authentication-Results: aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=none X-Migadu-Scanner: scn1.migadu.com X-Migadu-Spam-Score: -2.99 X-TUID: /qDzgJDxuRQG Hi, While thinking about this, I've noticed that using lists as "pairs" is a pattern that is common in the existing guix code, with openssh-service-type 'authorized-keys' field and G-Expressions 'file-union' as examples. Given the "entrenched" list usage, I don't think it's worth the effort to change the whole system to use pairs at this point (or maybe allow it as it probably just creates more confusion). I will amend the special-files-service-type doc entry to clarify that it expects two-element lists instead. Bruno On 2022-12-20 14:47, Ludovic Courtès wrote: > Hi, > > Josselin Poiret skribis: > >> Is this patch related to some specific problem you're running into? I >> personally would prefer keeping the special file interface as-is, and >> not mix two different kinds of entries: lists with 2 elements, and >> pairs. That would avoid having to manage even more edge-cases down the >> line if some more processing is needed. > > I agree. This is a public-facing interface so we should keep it as-is; > extending it to support pairs in addition to two-list elements would > likely bring confusion and bugs. > > I’m not entirely sure why we settled on two-list elements rather than > pairs back then, but I think it’s OK. > > Closing? > > Ludo’.