From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:403:478a::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id wBsgO5bxJ2UCIwEA9RJhRA:P1 (envelope-from ) for ; Thu, 12 Oct 2023 15:16:07 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:478a::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id wBsgO5bxJ2UCIwEA9RJhRA (envelope-from ) for ; Thu, 12 Oct 2023 15:16:07 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 72BCE60D6C for ; Thu, 12 Oct 2023 15:16:06 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1697116566; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=Mf2IUvUJCmONgk2VqHLzwTIQ9jfWDymKv8bZrUtEI60=; b=uGswB4Lj27vMj2cPtk/Inxtw5tGyIcWT7C2Yc77zT8vSLpxuevyLpQDQUzfxItlSKB057d E3dimaUhJ9ZA4cmYXpFrO4L05yoZWxOuDWph4xJeA+PG9W20Oa/8R4ad0rAvbbP5VcgFv2 wW44mp8U51z2eoQc3oIL5mY0AcSpf92eeBIoU3lXvOJwiOo2at4AZpWQ5LKFfBlN5tH6Vk W58sAF4PKweoV6N9hhTch0tZnrbB+s8HjUnUcLlQhulPU4smAkmhlsyR2QMb2FndyRdyAj 3CexpOH0LWeENTe39ZAvTwGFDyX8UKnlYkBacanYmXHCTWk2JP6aiWVL5BgXRw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1697116566; a=rsa-sha256; cv=none; b=k8pvM0Tf/xUsR+ASih8QtjjCt5fm6hLKVLfULtLKodes763Du3gLTwipi2Bya0FA3o9LsJ 7mgE905IoOv3IjcduYGMmGgJIFgHwbr8kbayYXLISDLN8vYAOc+6CwLax5bKXC08+hilrn /2Z10sZNNCfJBmCXXpEzefeGK2/ju6wd76RSQuIhra1Tq4+ajf7Kz1XKFfxkn7TjKpiED+ 23nwePGbqlttZk5Zq9nFt6GHd4Bqer4lXbfRPFvdcv0o2QCD9PoBOgSr/d46UxUyae1g9A JsY44zyonJAnIiUz6EynR2du6eYMfd8xjiGw4dc7++nt6Z7cyQRs+KzUvp+Uyw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=none Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qqvXY-0000s0-Rz; Thu, 12 Oct 2023 09:15:49 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qqvXT-0000r3-1F for guix-patches@gnu.org; Thu, 12 Oct 2023 09:15:43 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qqvXQ-0006l3-Jh for guix-patches@gnu.org; Thu, 12 Oct 2023 09:15:40 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qqvXm-0004cB-W1 for guix-patches@gnu.org; Thu, 12 Oct 2023 09:16:03 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#65479] [PATCH core-updates v3 02/63] search-paths: Add $XML_CATALOG_FILES and $SGML_CATALOG_FILES. Resent-From: Bruno Victal Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 12 Oct 2023 13:16:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65479 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: Josselin Poiret , Simon Tournier , Mathieu Othacehe , Tobias Geerinckx-Rice , Ricardo Wurmus , 65479@debbugs.gnu.org, Christopher Baines Received: via spool by 65479-submit@debbugs.gnu.org id=B65479.169711654717686 (code B ref 65479); Thu, 12 Oct 2023 13:16:02 +0000 Received: (at 65479) by debbugs.gnu.org; 12 Oct 2023 13:15:47 +0000 Received: from localhost ([127.0.0.1]:41390 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qqvXW-0004bB-PG for submit@debbugs.gnu.org; Thu, 12 Oct 2023 09:15:47 -0400 Received: from smtpmciv3.myservices.hosting ([185.26.107.239]:37638) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qqvXR-0004aw-Cn for 65479@debbugs.gnu.org; Thu, 12 Oct 2023 09:15:45 -0400 Received: from mail1.netim.hosting (unknown [185.26.106.173]) by smtpmciv3.myservices.hosting (Postfix) with ESMTP id BF81320386; Thu, 12 Oct 2023 15:15:00 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by mail1.netim.hosting (Postfix) with ESMTP id 249B080098; Thu, 12 Oct 2023 15:14:57 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at mail1.netim.hosting Received: from mail1.netim.hosting ([127.0.0.1]) by localhost (mail1-2.netim.hosting [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id sYQMIVT9Xvr8; Thu, 12 Oct 2023 15:14:56 +0200 (CEST) Received: from [192.168.1.116] (unknown [10.192.1.83]) (Authenticated sender: lumen@makinata.eu) by mail1.netim.hosting (Postfix) with ESMTPSA id 66D1B80099; Thu, 12 Oct 2023 15:14:53 +0200 (CEST) Message-ID: <159d7932-dfea-43fd-9a7d-a15a3021869a@makinata.eu> Date: Thu, 12 Oct 2023 14:14:52 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Bruno Victal References: <6cb2e86fb52e37573db40d9de435f64f48cac90b.1696881354.git.mirai@makinata.eu> <87bkd4paxo.fsf@gnu.org> Content-Language: en-US In-Reply-To: <87bkd4paxo.fsf@gnu.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Spam-Score: -3.69 X-Migadu-Queue-Id: 72BCE60D6C X-Migadu-Scanner: mx0.migadu.com X-Migadu-Spam-Score: -3.69 X-TUID: HVrICuHZ72wx Hi Ludo’, On 2023-10-12 08:16, Ludovic Courtès wrote: > Hi Bruno, > > Bruno Victal skribis: > >> These variables are used by some packages for XML/SGML catalog lookups. >> >> * guix/search-paths ($XML_CATALOG_FILES, $SGML_CATALOG_FILES): New variable, >> extracted from … >> * gnu/packages/xml.scm (libxml2, opensp)[native-search-paths]: … here. Refer >> to the variables from (guix search-paths) respectively. >> * gnu/packages/perl.scm >> (perl-app-xml-docbook-builder)[native-search-paths]: Use $XML_CATALOG_FILES. >> * doc/guix.texi (Search Paths): Update documentation to reflect changes. > > The way I see it, we’d define in (guix search-paths) only search paths > that are repeated in several different places, like $SSL_CERT_DIR. I didn't do an exhaustive search of what applications under the sun make use of the XML_CATALOG_FILES and SGML_CATALOG_FILES environment variables but I can say that we were missing them in a few crucial packages. In the packages where I added these search-paths (spans across various patches) I went through their manpages and in some occasions had to grep through their source code to confirm this. […] > $XML_CATALOG_FILES has 2 users, one of which looks dubious and should > probably be audited, and $SGML_CATALOG_FILES has only 1 user. Thus, the > status quo seems good to me. Which package are you finding its use dubious? By 2 users I presume the ones within the commit which isn't the end of the tale, see patches 03-04, 15, 18 and 24-25. In v1/v2 their use was much more pronounced until Maxims suggestion of introducing %libxslt-search-paths [1] to avoid top-level import cycles. (whilst also being a more concise way to convey this information without manually duplicating it when cycles did occur in v2) $SGML_CATALOG_FILES actually has other users, opensp [2], libxml2 and libxslt come to mind and are used in subsequent patches within the series. [1]: Message-Id: <87a5swmxhn.fsf@gmail.com> Link: [2]: Message-Id: Link: -- Furthermore, I consider that nonfree software must be eradicated. Cheers, Bruno.