From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36191) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gMEgJ-0002wy-9r for guix-patches@gnu.org; Mon, 12 Nov 2018 11:03:24 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gMEg5-00047D-7p for guix-patches@gnu.org; Mon, 12 Nov 2018 11:03:12 -0500 Received: from debbugs.gnu.org ([208.118.235.43]:43974) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gMEg2-000461-Hr for guix-patches@gnu.org; Mon, 12 Nov 2018 11:03:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gMEg2-0000vm-BP for guix-patches@gnu.org; Mon, 12 Nov 2018 11:03:02 -0500 Subject: [bug#33059] [PATCH v2 0/9] Add the FEniCS Project, v2 patches Resent-Message-ID: From: Paul Garlick Date: Mon, 12 Nov 2018 16:00:32 +0000 Message-Id: <1542038441-5738-1-git-send-email-pgarlick@tourbillion-technology.com> In-Reply-To: <87k1m7vvjp.fsf@gnu.org> References: <87k1m7vvjp.fsf@gnu.org> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: 33059@debbugs.gnu.org, Efraim Flashner , Eric Bavier , Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: Paul Garlick Hi Efraim, Hi Eric, Hi Ludo, Thank you for your comments on the patch series for the FEniCS Project packages. I have been able to make changes to address all of the suggestions with one exception, noted below. The main differences between the original and v2 patches are: i) python-mpi4py is now part of (gnu packages mpi) ii) python-petsc4py is now part of (gnu packages maths) iii) python-slepc4py is now part of (gnu packages maths) iv) temporary directory changes use 'with-directory-excursion' v) 'substitute*' is used in preference to 'with-atomic-file-replacement' vi) the Guix 'catch' package is used in preference to the bundled version vii) the 'python-fenics-dolfin' package has been renamed 'fenics' viii) the 'fenics' package has an updated home-page and synopsis The remaining suggestion was in the 'fenics-dolfin' package: > + (string-append > + "set(CTEST_CUSTOM_TESTS_IGNORE " > + "demo_bcs_serial " > + "demo_bcs_mpi " > + "demo_eigenvalue_serial " > + "demo_eigenvalue_mpi " > + "demo_navier-stokes_serial " > Could we avoid listing all the files here? I tried a few ideas to avoid listing the demos to ignore. These are the ones with the 'git-lfs' links. However, this proved to be awkward. The source code lists the demos that cmake expects to be present. So, one may either make a list of demos to ignore (as in the original patch) or delete the same members from a list to include (plus delete the subdirectories themselves). Simply deleting the subdirectories from the build directory does not work. Since they exist as Makefile targets they are re-created by the 'make demos' step. I think the original method is preferable. An advantage is that users may readily access the demos if they are using Guix on a host system that has a git-lfs package available. Best regards, Paul. Paul Garlick (9): gnu: Add python-mpi4py. gnu: Add python-petsc4py. gnu: Add python-slepc4py. gnu: Add python-fenics-dijitso. gnu: Add python-fenics-ufl. gnu: Add python-fenics-fiat. gnu: Add python-fenics-ffc. gnu: Add fenics-dolfin. gnu: Add fenics. gnu/packages/maths.scm | 72 +++++++ gnu/packages/mpi.scm | 42 ++++ gnu/packages/simulation.scm | 490 +++++++++++++++++++++++++++++++++++++++++++- 3 files changed, 603 insertions(+), 1 deletion(-) -- 1.8.3.1