From: Eric Bavier <ericbavier@centurylink.net>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 37434-done@debbugs.gnu.org, 37435-done@debbugs.gnu.org
Subject: bug#37435: [bug#37434] [PATCH 1/2] gnu: ghc-megaparsec: Update to 7.0.5.
Date: Tue, 24 Sep 2019 22:20:28 -0400 (EDT) [thread overview]
Message-ID: <1530026973.36474811.1569378028367.JavaMail.zimbra@centurylink.net> (raw)
In-Reply-To: <87d0fpoc5o.fsf@gnu.org>
----- On Sep 24, 2019, at 12:08 PM, Ludovic Courtès ludo@gnu.org wrote:
> Hi Eric,
>
> Eric Bavier <ericbavier@centurylink.net> skribis:
>
>> From 832529b71c2c5c7e6aa6e88a206c0db65e8a0c2e Mon Sep 17 00:00:00 2001
>> From: Eric Bavier <bavier@member.fsf.org>
>> Date: Mon, 16 Sep 2019 22:20:23 -0500
>> Subject: [PATCH] gnu: idris: Update to 1.3.2.
>>
>> * gnu/packages/idris.scm (ghc-network-2.8, ghc-megaparsec-7): New variables.
>> (idris): Update to 1.3.2.
>> [source]: Remove patch.
>> [inputs]: Use ghc-network-2.8 and ghc-megaparsec-7.
>> * gnu/packages/patches/idris-test-no-node.patch: Delete.
>> * gnu/local.mk (dist_patch_DATA): Remove it.
>
> [...]
>> +;;; Until we update our default GHC to >=8.6 we cannot update our ghc-network
>> +;;; package, since the 'cabal-install' package that supports the current
>> +;;; 'Cabal' module requires 'network==2.6.*'. Providing a local ghc-network
>> +;;; works in this case since we use it only for a standalone program.
>> +(define ghc-network-2.8
>> + (package
>> + (inherit ghc-network)
>
> You should only inherit from packages defined in the same module,
> otherwise we risk hitting the dreaded circular dependency mess (actually
> this particular case is fine because idris.scm is a “leaf”, but still,
> let’s not take this risk.)
>
> So I recommend moving these two ghc-* packages next to their friends.
Makes sense. Done.
> With this change the patch LGTM.
Pushed with that change and other small adjustments for latest master in commit 4780db2c93.
--
`~Eric
next prev parent reply other threads:[~2019-09-25 2:21 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-17 3:37 [bug#37434] [PATCH 1/2] gnu: ghc-megaparsec: Update to 7.0.5 ericbavier
2019-09-17 3:37 ` [bug#37435] [PATCH 2/2] gnu: idris: Update to 1.3.2 ericbavier
2019-09-20 20:32 ` [bug#37434] [PATCH 1/2] gnu: ghc-megaparsec: Update to 7.0.5 Ludovic Courtès
2019-09-20 22:21 ` Timothy Sample
2019-09-20 22:25 ` Timothy Sample
2019-09-23 8:25 ` Ludovic Courtès
2019-09-24 1:59 ` Eric Bavier
2019-09-24 7:16 ` Ludovic Courtès
2019-09-24 14:06 ` Eric Bavier
2019-09-24 17:08 ` Ludovic Courtès
2019-09-25 2:20 ` Eric Bavier [this message]
2019-09-25 17:49 ` Timothy Sample
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1530026973.36474811.1569378028367.JavaMail.zimbra@centurylink.net \
--to=ericbavier@centurylink.net \
--cc=37434-done@debbugs.gnu.org \
--cc=37435-done@debbugs.gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).