[bug#29574] Fwd: [PATCH] Add Krita to guix

[bug#29574] Fwd: [PATCH] Add Krita to guix

[Mark Meyer]

[-- Attachment #1: Type: text/plain, Size: 492 bytes --]



On Tue, Dec 5, 2017, at 02:26, Mark Meyer wrote:
> Second  try.
> 
> I disabled all tests, since these required an X11 display to be present.
> It's running now. I created a new file and saved the output. Looks good.
> 
> Please find the patch attached.
> 
> Lints fine, but I didn't test if this is reproducible, since the build
> is taking a very long time (even with all tests disabled).
> 
> Cheers, Mark
> 
> -- 
>   Mark Meyer
>   mark@ofosos.org


-- 
  Mark Meyer
  mark@ofosos.org

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnu-packages-kde.scm-krita-Add-new-variable.patch --]
[-- Type: text/x-patch; name="0001-gnu-packages-kde.scm-krita-Add-new-variable.patch", Size: 4844 bytes --]

From ed263ddc7b084c362165688bc1d1012e3978d9b8 Mon Sep 17 00:00:00 2001
From: Mark Meyer <mark@ofosos.org>
Date: Tue, 5 Dec 2017 00:52:42 +0100
Subject: [PATCH] * gnu/packages/kde.scm (krita): Add new variable.

---
 gnu/packages/kde.scm | 90 +++++++++++++++++++++++++++++++++++++++++++++++++++-
 1 file changed, 89 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/kde.scm b/gnu/packages/kde.scm
index 59271ebee..af182a033 100644
--- a/gnu/packages/kde.scm
+++ b/gnu/packages/kde.scm
@@ -1,6 +1,7 @@
 ;;; GNU Guix --- Functional package management for GNU
 ;;; Copyright © 2016, 2017 Efraim Flashner <efraim@flashner.co.il>
 ;;; Copyright © 2016, 2017 Thomas Danckaert <post@thomasdanckaert.be>
+;;; Copyright © 2017 Mark Meyer <mark@ofosos.org>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -23,18 +24,29 @@
   #:use-module ((guix licenses) #:prefix license:)
   #:use-module (guix packages)
   #:use-module (guix utils)
+  #:use-module (gnu packages algebra)
   #:use-module (gnu packages apr)
   #:use-module (gnu packages boost)
   #:use-module (gnu packages compression)
+  #:use-module (gnu packages curl)
   #:use-module (gnu packages documentation)
+  #:use-module (gnu packages gettext)
+  #:use-module (gnu packages ghostscript)
   #:use-module (gnu packages gl)
   #:use-module (gnu packages gnome)
+  #:use-module (gnu packages graphics)
+  #:use-module (gnu packages image)
   #:use-module (gnu packages kde-frameworks)
   #:use-module (gnu packages llvm)
+  #:use-module (gnu packages maths)
+  #:use-module (gnu packages pdf)
+  #:use-module (gnu packages perl)
+  #:use-module (gnu packages photo)
   #:use-module (gnu packages pkg-config)
   #:use-module (gnu packages tls)
   #:use-module (gnu packages qt)
-  #:use-module (gnu packages version-control))
+  #:use-module (gnu packages version-control)
+  #:use-module (gnu packages xorg))
 
 (define-public kdevelop
   (package
@@ -220,6 +232,82 @@ for some KDevelop language plugins (Ruby, PHP, CSS...).")
 plugins, as well as code to create plugins, or complete applications.")
     (license license:gpl3+)))
 
+(define-public krita
+  (package
+    (name "krita")
+    (version "3.3.2.1")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append
+                    "mirror://kde/stable/krita/"
+                    "3.3.2/" name "-" version ".tar.xz"))
+              (sha256
+               (base32
+                "0i3l27cfi1h486m74xf4ynk0pwx32xaqraa91a0g1bpj1jxf2mg5"))))
+    (build-system cmake-build-system)
+    (arguments
+     `(#:tests? #f
+       #:configure-flags
+       (list "-DBUILD_TESTING=OFF" "-DKDE4_BUILD_TESTS=OFF"
+             (string-append "-DWITH_FFTW3="
+                            (assoc-ref %build-inputs "fftw"))
+             (string-append "-DWITH_GSL="
+                            (assoc-ref %build-inputs "gsl"))
+             (string-append "-DWITH_LibRaw="
+                            (assoc-ref %build-inputs "libraw"))
+             (string-append "-DWITH_JPEG="
+                            (assoc-ref %build-inputs "openjpeg"))
+             (string-append "-DWITH_Poppler="
+                            (assoc-ref %build-inputs "poppler"))
+             (string-append "-DWITH_TIFF="
+                            (assoc-ref %build-inputs "libtiff")))))
+    (native-inputs
+     `(("extra-cmake-modules" ,extra-cmake-modules)))
+    (inputs
+     `(("qtbase" ,qtbase)
+       ("qtdeclarative" ,qtdeclarative)
+       ("qtmultimedia" ,qtmultimedia)
+       ("qtx11extras" ,qtx11extras)
+       ("qtsvg" ,qtsvg)
+       ("qwt" ,qwt)
+       ("karchive" ,karchive)
+       ("kcompletion" ,kcompletion)
+       ("kconfig" ,kconfig)
+       ("kcoreaddons" ,kcoreaddons)
+       ("kcrash" ,kcrash)
+       ("kguiaddons" ,kguiaddons)
+       ("ki18n" ,ki18n)
+       ("kiconthemes" ,kiconthemes)
+       ("kio" ,kio)
+       ("kitemmodels" ,kitemmodels)
+       ("kitemviews" ,kitemviews)
+       ("kwidgetsaddons" ,kwidgetsaddons)
+       ("kwindowsystem" ,kwindowsystem)
+       ("kxmlgui" ,kxmlgui)
+       ("boost" ,boost)
+       ("exiv2" ,exiv2)
+       ("lcms" ,lcms)
+       ("libpng" ,libpng)
+       ("curl" ,curl)
+       ("zlib" ,zlib)
+       ("libx11" ,libx11)
+       ("libxcb" ,libxcb)
+       ("libxi" ,libxi)
+       ("fftw" ,fftw)
+       ("gsl" ,gsl)
+       ("openjpeg" ,openjpeg)
+       ("poppler" ,poppler)
+       ("libraw" ,libraw)
+       ("libtiff" ,libtiff)
+       ("eigen" ,eigen)
+       ("perl" ,perl)
+       ("gettext-minimal" ,gettext-minimal)))
+    (home-page "https://krita.org")
+    (synopsis "Digital painting application")
+    (description
+     "A digital image editor, primarily aimed at digital painting and animation.")
+    (license license:gpl2+)))
+
 (define-public libkomparediff2
   (package
     (name "libkomparediff2")
-- 
2.15.0

[bug#29574] Fwd: [PATCH] Add Krita to guix

[Kei Kebreau]

[-- Attachment #1.1: Type: text/plain, Size: 879 bytes --]

Mark Meyer <mark@ofosos.org> writes:

> On Tue, Dec 5, 2017, at 02:26, Mark Meyer wrote:
>> Second  try.
>> 
>> I disabled all tests, since these required an X11 display to be present.
>> It's running now. I created a new file and saved the output. Looks good.
>> 
>> Please find the patch attached.
>> 
>> Lints fine, but I didn't test if this is reproducible, since the build
>> is taking a very long time (even with all tests disabled).
>> 
>> Cheers, Mark
>> 
>> -- 
>>   Mark Meyer
>>   mark@ofosos.org

Hi Mark,

I built this package twice and it is reproducible! I've moved some
inputs to native-inputs in the attached patch because they didn't show
up as requisites for krita (i.e. I ran 'guix gc -R /gnu/store/...-krita-3.3.2.1'
to find this out).

Please tell me if this build works properly for you as it seems to for
me.

Thanks,
Kei


[-- Attachment #1.2: 0001-gnu-Add-krita.patch --]
[-- Type: text/plain, Size: 5051 bytes --]

From 0f977a7444445753aaa48b65d8c84d6db16b8368 Mon Sep 17 00:00:00 2001
From: Mark Meyer <mark@ofosos.org>
Date: Tue, 5 Dec 2017 00:52:42 +0100
Subject: [PATCH] gnu: Add krita.

* gnu/packages/kde.scm (krita): Add new variable.

Signed-off-by: Kei Kebreau <kkebreau@posteo.net>
---
 gnu/packages/kde.scm | 90 +++++++++++++++++++++++++++++++++++++++++++++++++++-
 1 file changed, 89 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/kde.scm b/gnu/packages/kde.scm
index 59271ebee..39a137397 100644
--- a/gnu/packages/kde.scm
+++ b/gnu/packages/kde.scm
@@ -1,6 +1,7 @@
 ;;; GNU Guix --- Functional package management for GNU
 ;;; Copyright © 2016, 2017 Efraim Flashner <efraim@flashner.co.il>
 ;;; Copyright © 2016, 2017 Thomas Danckaert <post@thomasdanckaert.be>
+;;; Copyright © 2017 Mark Meyer <mark@ofosos.org>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -23,18 +24,29 @@
   #:use-module ((guix licenses) #:prefix license:)
   #:use-module (guix packages)
   #:use-module (guix utils)
+  #:use-module (gnu packages algebra)
   #:use-module (gnu packages apr)
   #:use-module (gnu packages boost)
   #:use-module (gnu packages compression)
+  #:use-module (gnu packages curl)
   #:use-module (gnu packages documentation)
+  #:use-module (gnu packages gettext)
+  #:use-module (gnu packages ghostscript)
   #:use-module (gnu packages gl)
   #:use-module (gnu packages gnome)
+  #:use-module (gnu packages graphics)
+  #:use-module (gnu packages image)
   #:use-module (gnu packages kde-frameworks)
   #:use-module (gnu packages llvm)
+  #:use-module (gnu packages maths)
+  #:use-module (gnu packages pdf)
+  #:use-module (gnu packages perl)
+  #:use-module (gnu packages photo)
   #:use-module (gnu packages pkg-config)
   #:use-module (gnu packages tls)
   #:use-module (gnu packages qt)
-  #:use-module (gnu packages version-control))
+  #:use-module (gnu packages version-control)
+  #:use-module (gnu packages xorg))
 
 (define-public kdevelop
   (package
@@ -220,6 +232,82 @@ for some KDevelop language plugins (Ruby, PHP, CSS...).")
 plugins, as well as code to create plugins, or complete applications.")
     (license license:gpl3+)))
 
+(define-public krita
+  (package
+    (name "krita")
+    (version "3.3.2.1")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append
+                    "mirror://kde/stable/krita/"
+                    "3.3.2/" name "-" version ".tar.xz"))
+              (sha256
+               (base32
+                "0i3l27cfi1h486m74xf4ynk0pwx32xaqraa91a0g1bpj1jxf2mg5"))))
+    (build-system cmake-build-system)
+    (arguments
+     `(#:tests? #f
+       #:configure-flags
+       (list "-DBUILD_TESTING=OFF" "-DKDE4_BUILD_TESTS=OFF"
+             (string-append "-DWITH_FFTW3="
+                            (assoc-ref %build-inputs "fftw"))
+             (string-append "-DWITH_GSL="
+                            (assoc-ref %build-inputs "gsl"))
+             (string-append "-DWITH_LibRaw="
+                            (assoc-ref %build-inputs "libraw"))
+             (string-append "-DWITH_JPEG="
+                            (assoc-ref %build-inputs "openjpeg"))
+             (string-append "-DWITH_Poppler="
+                            (assoc-ref %build-inputs "poppler"))
+             (string-append "-DWITH_TIFF="
+                            (assoc-ref %build-inputs "libtiff")))))
+    (native-inputs
+     `(("curl" ,curl)
+       ("eigen" ,eigen)
+       ("extra-cmake-modules" ,extra-cmake-modules)
+       ("gettext-minimal" ,gettext-minimal)
+       ("kitemmodels" ,kitemmodels)
+       ("qwt" ,qwt)))
+    (inputs
+     `(("qtbase" ,qtbase)
+       ("qtdeclarative" ,qtdeclarative)
+       ("qtmultimedia" ,qtmultimedia)
+       ("qtx11extras" ,qtx11extras)
+       ("qtsvg" ,qtsvg)
+       ("karchive" ,karchive)
+       ("kcompletion" ,kcompletion)
+       ("kconfig" ,kconfig)
+       ("kcoreaddons" ,kcoreaddons)
+       ("kcrash" ,kcrash)
+       ("kguiaddons" ,kguiaddons)
+       ("ki18n" ,ki18n)
+       ("kiconthemes" ,kiconthemes)
+       ("kio" ,kio)
+       ("kitemviews" ,kitemviews)
+       ("kwidgetsaddons" ,kwidgetsaddons)
+       ("kwindowsystem" ,kwindowsystem)
+       ("kxmlgui" ,kxmlgui)
+       ("boost" ,boost)
+       ("exiv2" ,exiv2)
+       ("lcms" ,lcms)
+       ("libpng" ,libpng)
+       ("zlib" ,zlib)
+       ("libx11" ,libx11)
+       ("libxcb" ,libxcb)
+       ("libxi" ,libxi)
+       ("fftw" ,fftw)
+       ("gsl" ,gsl)
+       ("openjpeg" ,openjpeg)
+       ("poppler" ,poppler)
+       ("libraw" ,libraw)
+       ("libtiff" ,libtiff)
+       ("perl" ,perl)))
+    (home-page "https://krita.org")
+    (synopsis "Digital painting application")
+    (description
+     "A digital image editor, primarily aimed at digital painting and animation.")
+    (license license:gpl2+)))
+
 (define-public libkomparediff2
   (package
     (name "libkomparediff2")
-- 
2.15.0


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

[bug#29574] Fwd: [PATCH] Add Krita to guix

[Mark Meyer]

Hi Kei,
I want to double check the output tomorrow morning. I think my copy
lacks JPG support, but I'm not sure. I'll check tomorrow.

Cheers, Mark

On Sun, Dec 10, 2017, at 20:32, Kei Kebreau wrote:
> Mark Meyer <mark@ofosos.org> writes:
> 
> > On Tue, Dec 5, 2017, at 02:26, Mark Meyer wrote:
> >> Second  try.
> >> 
> >> I disabled all tests, since these required an X11 display to be present.
> >> It's running now. I created a new file and saved the output. Looks good.
> >> 
> >> Please find the patch attached.
> >> 
> >> Lints fine, but I didn't test if this is reproducible, since the build
> >> is taking a very long time (even with all tests disabled).
> >> 
> >> Cheers, Mark
> >> 
> >> -- 
> >>   Mark Meyer
> >>   mark@ofosos.org
> 
> Hi Mark,
> 
> I built this package twice and it is reproducible! I've moved some
> inputs to native-inputs in the attached patch because they didn't show
> up as requisites for krita (i.e. I ran 'guix gc -R
> /gnu/store/...-krita-3.3.2.1'
> to find this out).
> 
> Please tell me if this build works properly for you as it seems to for
> me.
> 
> Thanks,
> Kei
> 
> Email had 2 attachments:
> + 0001-gnu-Add-krita.patch
>   5k (text/plain)
> + signature.asc
>   1k (application/pgp-signature)


-- 
  Mark Meyer
  mark@ofosos.org

[bug#29574] Fwd: [PATCH] Add Krita to guix

[Mark Meyer]

Hey Kei,
JPEG does not work and PDF also doesn't seem to work, we might as well
remove both dependencies, I think they're nice but not essential.

When I do `guix environment krita` and start a manual build I get:

-- The following OPTIONAL packages have not been found:

 * XCB , X protocol C-language Binding , <http://xcb.freedesktop.org>
 * OpenEXR , High dynamic-range (HDR) image file format ,
 <http://www.openexr.com>
   Required by the Krita OpenEXR filter
 * JPEG , Free library for JPEG image compression. Note: libjpeg8 is NOT
 supported. , <http://www.libjpeg-turbo.org>
   Required by the Krita JPEG filter
 * OCIO , The OpenColorIO Library , <http://www.opencolorio.org>
   Required by the Krita LUT docker
 * Vc (required version >= 1.1.0) , Portable, zero-overhead SIMD library
 for C++ , <https://github.com/VcDevel/Vc>
   Required by the Krita for vectorization
 * Poppler , A PDF rendering library , <http://poppler.freedesktop.org>
   Required by the Krita PDF filter.

I intend to enable OpenEXR JPEG and Poppler in a later patch.

So: looks good to me.

Cheers, Mark

On Sun, Dec 10, 2017, at 20:32, Kei Kebreau wrote:
> Mark Meyer <mark@ofosos.org> writes:
> 
> > On Tue, Dec 5, 2017, at 02:26, Mark Meyer wrote:
> >> Second  try.
> >> 
> >> I disabled all tests, since these required an X11 display to be present.
> >> It's running now. I created a new file and saved the output. Looks good.
> >> 
> >> Please find the patch attached.
> >> 
> >> Lints fine, but I didn't test if this is reproducible, since the build
> >> is taking a very long time (even with all tests disabled).
> >> 
> >> Cheers, Mark
> >> 
> >> -- 
> >>   Mark Meyer
> >>   mark@ofosos.org
> 
> Hi Mark,
> 
> I built this package twice and it is reproducible! I've moved some
> inputs to native-inputs in the attached patch because they didn't show
> up as requisites for krita (i.e. I ran 'guix gc -R
> /gnu/store/...-krita-3.3.2.1'
> to find this out).
> 
> Please tell me if this build works properly for you as it seems to for
> me.
> 
> Thanks,
> Kei
> 
> Email had 2 attachments:
> + 0001-gnu-Add-krita.patch
>   5k (text/plain)
> + signature.asc
>   1k (application/pgp-signature)


-- 
  Mark Meyer
  mark@ofosos.org

[bug#29574] Fwd: [PATCH] Add Krita to guix

[Mark Meyer]

[-- Attachment #1: Type: text/plain, Size: 1318 bytes --]

Hi Kei,
Poppler was an easy target, it just pointed to the wrong package. JPEG
requires some more packaging and EXR some thought. Meanwhile the
attached patch should be ok.

Cheers, Mark

On Sun, Dec 10, 2017, at 20:32, Kei Kebreau wrote:
> Mark Meyer <mark@ofosos.org> writes:
> 
> > On Tue, Dec 5, 2017, at 02:26, Mark Meyer wrote:
> >> Second  try.
> >> 
> >> I disabled all tests, since these required an X11 display to be present.
> >> It's running now. I created a new file and saved the output. Looks good.
> >> 
> >> Please find the patch attached.
> >> 
> >> Lints fine, but I didn't test if this is reproducible, since the build
> >> is taking a very long time (even with all tests disabled).
> >> 
> >> Cheers, Mark
> >> 
> >> -- 
> >>   Mark Meyer
> >>   mark@ofosos.org
> 
> Hi Mark,
> 
> I built this package twice and it is reproducible! I've moved some
> inputs to native-inputs in the attached patch because they didn't show
> up as requisites for krita (i.e. I ran 'guix gc -R
> /gnu/store/...-krita-3.3.2.1'
> to find this out).
> 
> Please tell me if this build works properly for you as it seems to for
> me.
> 
> Thanks,
> Kei
> 
> Email had 2 attachments:
> + 0001-gnu-Add-krita.patch
>   5k (text/plain)
> + signature.asc
>   1k (application/pgp-signature)


-- 
  Mark Meyer
  mark@ofosos.org

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnu-packages-kde.scm-krita-Add-new-variable.patch --]
[-- Type: text/x-patch; name="0001-gnu-packages-kde.scm-krita-Add-new-variable.patch", Size: 4597 bytes --]

From 341c2de5b922e6062e9a65ea88cdfcc6062819e6 Mon Sep 17 00:00:00 2001
From: Mark Meyer <mark@ofosos.org>
Date: Tue, 5 Dec 2017 00:52:42 +0100
Subject: [PATCH] * gnu/packages/kde.scm (krita): Add new variable.

---
 gnu/packages/kde.scm | 85 +++++++++++++++++++++++++++++++++++++++++++++++++++-
 1 file changed, 84 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/kde.scm b/gnu/packages/kde.scm
index 59271ebee..a384626c0 100644
--- a/gnu/packages/kde.scm
+++ b/gnu/packages/kde.scm
@@ -1,6 +1,7 @@
 ;;; GNU Guix --- Functional package management for GNU
 ;;; Copyright © 2016, 2017 Efraim Flashner <efraim@flashner.co.il>
 ;;; Copyright © 2016, 2017 Thomas Danckaert <post@thomasdanckaert.be>
+;;; Copyright © 2017 Mark Meyer <mark@ofosos.org>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -23,18 +24,29 @@
   #:use-module ((guix licenses) #:prefix license:)
   #:use-module (guix packages)
   #:use-module (guix utils)
+  #:use-module (gnu packages algebra)
   #:use-module (gnu packages apr)
   #:use-module (gnu packages boost)
   #:use-module (gnu packages compression)
+  #:use-module (gnu packages curl)
   #:use-module (gnu packages documentation)
+  #:use-module (gnu packages gettext)
+  #:use-module (gnu packages ghostscript)
   #:use-module (gnu packages gl)
   #:use-module (gnu packages gnome)
+  #:use-module (gnu packages graphics)
+  #:use-module (gnu packages image)
   #:use-module (gnu packages kde-frameworks)
   #:use-module (gnu packages llvm)
+  #:use-module (gnu packages maths)
+  #:use-module (gnu packages pdf)
+  #:use-module (gnu packages perl)
+  #:use-module (gnu packages photo)
   #:use-module (gnu packages pkg-config)
   #:use-module (gnu packages tls)
   #:use-module (gnu packages qt)
-  #:use-module (gnu packages version-control))
+  #:use-module (gnu packages version-control)
+  #:use-module (gnu packages xorg))
 
 (define-public kdevelop
   (package
@@ -220,6 +232,77 @@ for some KDevelop language plugins (Ruby, PHP, CSS...).")
 plugins, as well as code to create plugins, or complete applications.")
     (license license:gpl3+)))
 
+(define-public krita
+  (package
+    (name "krita")
+    (version "3.3.2.1")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append
+                    "mirror://kde/stable/krita/"
+                    "3.3.2/" name "-" version ".tar.xz"))
+              (sha256
+               (base32
+                "0i3l27cfi1h486m74xf4ynk0pwx32xaqraa91a0g1bpj1jxf2mg5"))))
+    (build-system cmake-build-system)
+    (arguments
+     `(#:tests? #f
+       #:configure-flags
+       (list "-DBUILD_TESTING=OFF" "-DKDE4_BUILD_TESTS=OFF"
+             (string-append "-DWITH_FFTW3="
+                            (assoc-ref %build-inputs "fftw"))
+             (string-append "-DWITH_GSL="
+                            (assoc-ref %build-inputs "gsl"))
+             (string-append "-DWITH_LibRaw="
+                            (assoc-ref %build-inputs "libraw"))
+             (string-append "-DWITH_TIFF="
+                            (assoc-ref %build-inputs "libtiff")))))
+    (native-inputs
+     `(("curl" ,curl)
+       ("eigen" ,eigen)
+       ("extra-cmake-modules" ,extra-cmake-modules)
+       ("gettext-minimal" ,gettext-minimal)
+       ("kitemmodels" ,kitemmodels)
+       ("qwt" ,qwt)))
+    (inputs
+     `(("qtbase" ,qtbase)
+       ("qtdeclarative" ,qtdeclarative)
+       ("qtmultimedia" ,qtmultimedia)
+       ("qtx11extras" ,qtx11extras)
+       ("qtsvg" ,qtsvg)
+       ("karchive" ,karchive)
+       ("kcompletion" ,kcompletion)
+       ("kconfig" ,kconfig)
+       ("kcoreaddons" ,kcoreaddons)
+       ("kcrash" ,kcrash)
+       ("kguiaddons" ,kguiaddons)
+       ("ki18n" ,ki18n)
+       ("kiconthemes" ,kiconthemes)
+       ("kio" ,kio)
+       ("kitemviews" ,kitemviews)
+       ("kwidgetsaddons" ,kwidgetsaddons)
+       ("kwindowsystem" ,kwindowsystem)
+       ("kxmlgui" ,kxmlgui)
+       ("boost" ,boost)
+       ("exiv2" ,exiv2)
+       ("lcms" ,lcms)
+       ("libpng" ,libpng)
+       ("zlib" ,zlib)
+       ("libx11" ,libx11)
+       ("libxcb" ,libxcb)
+       ("libxi" ,libxi)
+       ("fftw" ,fftw)
+       ("gsl" ,gsl)
+       ("poppler-qt5" ,poppler-qt5)
+       ("libraw" ,libraw)
+       ("libtiff" ,libtiff)
+       ("perl" ,perl)))
+    (home-page "https://krita.org")
+    (synopsis "Digital painting application")
+    (description
+     "A digital image editor, primarily aimed at digital painting and animation.")
+    (license license:gpl2+)))
+
 (define-public libkomparediff2
   (package
     (name "libkomparediff2")
-- 
2.15.0

[bug#29574] Fwd: [PATCH] Add Krita to guix

[Kei Kebreau]

[-- Attachment #1: Type: text/plain, Size: 1858 bytes --]

Mark Meyer <mark@ofosos.org> writes:

> Hi Kei,
> Poppler was an easy target, it just pointed to the wrong package. JPEG
> requires some more packaging and EXR some thought. Meanwhile the
> attached patch should be ok.
>
> Cheers, Mark
>
> On Sun, Dec 10, 2017, at 20:32, Kei Kebreau wrote:
>> Mark Meyer <mark@ofosos.org> writes:
>> 
>> > On Tue, Dec 5, 2017, at 02:26, Mark Meyer wrote:
>> >> Second  try.
>> >> 
>> >> I disabled all tests, since these required an X11 display to be present.
>> >> It's running now. I created a new file and saved the output. Looks good.
>> >> 
>> >> Please find the patch attached.
>> >> 
>> >> Lints fine, but I didn't test if this is reproducible, since the build
>> >> is taking a very long time (even with all tests disabled).
>> >> 
>> >> Cheers, Mark
>> >> 
>> >> -- 
>> >>   Mark Meyer
>> >>   mark@ofosos.org
>> 
>> Hi Mark,
>> 
>> I built this package twice and it is reproducible! I've moved some
>> inputs to native-inputs in the attached patch because they didn't show
>> up as requisites for krita (i.e. I ran 'guix gc -R
>> /gnu/store/...-krita-3.3.2.1'
>> to find this out).
>> 
>> Please tell me if this build works properly for you as it seems to for
>> me.
>> 
>> Thanks,
>> Kei
>> 
>> Email had 2 attachments:
>> + 0001-gnu-Add-krita.patch
>>   5k (text/plain)
>> + signature.asc
>>   1k (application/pgp-signature)

Great, LGTM. I added some detail to the description and pushed it to master, so you can close this bug.

Also, please be sure to follow our change log conventions, which are
something like these[0]. When in doubt, copy from a recent change log
for a change similar to yours from our repo. Most of the time this works
without a problem.

Thanks,
Kei

[0]: https://www.gnu.org/prep/standards/html_node/Style-of-Change-Logs.html

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

bug#29574: Fixed

[Mark Meyer]

Fixed.

-- 
  Mark Meyer
  mark@ofosos.org

[bug#29574] Fixed

[ng0]

[-- Attachment #1: Type: text/plain, Size: 553 bytes --]

Mark Meyer transcribed 0.1K bytes:
> Fixed.
> 
> -- 
>   Mark Meyer
>   mark@ofosos.org

If XXXX-close@debbugs.gnu.org does something, I think it could be similar to
"disregard, closing as not working on it, dropping this".
XXXX-done@debbugs.gnu.org is what we use for tickets that have been resolved.
There are notes in HACKING and in the chapter 'contributing' about this I
think
Please use this next time

Thanks
-- 
GnuPG: A88C8ADD129828D7EAC02E52E22F9BBFEE348588
GnuPG: https://c.n0.is/ng0_pubkeys/tree/keys
  WWW: https://n0.is

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]