From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49373) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e6eDz-0001lK-Un for guix-patches@gnu.org; Mon, 23 Oct 2017 11:01:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e6eDu-0003By-Du for guix-patches@gnu.org; Mon, 23 Oct 2017 11:01:08 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:49178) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1e6eDu-0003BA-BG for guix-patches@gnu.org; Mon, 23 Oct 2017 11:01:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1e6eDt-0004Gn-Rk for guix-patches@gnu.org; Mon, 23 Oct 2017 11:01:01 -0400 Subject: [bug#28593] [PATCH] gnu: openfoam: Clean up to reduce closure. Resent-Message-ID: Message-ID: <1508770811.11712.19.camel@tourbillion-technology.com> From: Paul Garlick Date: Mon, 23 Oct 2017 16:00:11 +0100 In-Reply-To: <874lqrjh0y.fsf@albion.it.manchester.ac.uk> References: <20170925104459.17798-1-fx@gnu.org> <87fubbj5yr.fsf@gnu.org> <1506426036.2423.32.camel@tourbillion-technology.com> <873779hdci.fsf@gnu.org> <87o9piit59.fsf@gnu.org> <1507547167.17241.18.camel@tourbillion-technology.com> <874lqrjh0y.fsf@albion.it.manchester.ac.uk> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 8bit List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Dave Love Cc: 28593@debbugs.gnu.org On Sun, 2017-10-22 at 17:15 +0100, Dave Love wrote: > > I successfully rebuilt pisoFoam following the example in the current > documentation.  Is that good enough? Yes, that is a good example case.  Thank you for doing the check. > Here's a modified patch to change the comment and avoid an empty > directory. Fine, with a caveat on the FIXME comment: i) 'wmake' will fail to find headers in subdirectories of 'src' if they are not installed.  So, a re-compilation as you did above would not be possible without installing the extra output.  This is perhaps confusing for a new user, who may not know the details of the dependency structure. ii) OpenFOAM would be difficult to use without the 'tutorials' directory, as these are often used as the starting point for new development.  I think it is helpful for these files to be installed by default. My own preference would be to not fix the FIXME (or, in fact, to omit the comment at this stage). Best, Paul.