* [bug#28558] [PATCH] gnu: Add atool.
@ 2017-09-22 21:49 Stefan Reichör
2017-09-23 8:43 ` Ben Woodcroft
0 siblings, 1 reply; 6+ messages in thread
From: Stefan Reichör @ 2017-09-22 21:49 UTC (permalink / raw)
To: 28558
* gnu/packages/compression.scm (atool): New variable.
---
gnu/packages/compression.scm | 27 +++++++++++++++++++++++++++
1 file changed, 27 insertions(+)
diff --git a/gnu/packages/compression.scm b/gnu/packages/compression.scm
index 7eeeaf3..76cca5f 100644
--- a/gnu/packages/compression.scm
+++ b/gnu/packages/compression.scm
@@ -17,6 +17,7 @@
;;; Copyright © 2017 ng0 <contact.ng0@cryptolab.net>
;;; Copyright © 2017 Manolis Fragkiskos Ragkousis <manolis837@gmail.com>
;;; Copyright © 2017 Theodoros Foradis <theodoros.for@openmailbox.org>
+;;; Copyright © 2017 Stefan Reichör <stefan@xsteve.at>
;;;
;;; This file is part of GNU Guix.
;;;
@@ -1572,3 +1573,29 @@ zip archives. Files can be added from data buffers, files, or compressed data
copied directly from other zip archives. Changes made without closing the
archive can be reverted.")
(license license:bsd-3)))
+
+(define-public atool
+ (package
+ (name "atool")
+ (version "0.39.0")
+ (source
+ (origin
+ (method url-fetch)
+ (uri (string-append
+ "http://savannah.nongnu.org/download/atool/atool-"
+ version ".tar.gz"))
+ (sha256
+ (base32
+ "0fvhzip2v08jgnlfpyj6rapan39xlsl1ksgq4lp8gfsai2ah1xma"))))
+ (inputs
+ `(("perl" ,perl)))
+ (build-system gnu-build-system)
+ (synopsis "Universal tool to manage file archives of various types")
+ (description "The main command is @command{aunpack} which extracts files
+from an archive. The other commands provided are @command{apack} (to create
+archives), @command{als} (to list files in archives), and @command{acat} (to
+extract files to standard out). As @command{atool} invokes external programs
+to handle the archives, not all commands may be supported for a certain type
+of archives.")
+ (home-page "http://www.nongnu.org/atool/")
+ (license license:gpl2+)))
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [bug#28558] [PATCH] gnu: Add atool.
2017-09-22 21:49 [bug#28558] [PATCH] gnu: Add atool Stefan Reichör
@ 2017-09-23 8:43 ` Ben Woodcroft
2017-09-23 18:16 ` Stefan Reichör
0 siblings, 1 reply; 6+ messages in thread
From: Ben Woodcroft @ 2017-09-23 8:43 UTC (permalink / raw)
To: Stefan Reichör, 28558
On 23/09/17 07:49, Stefan Reichör wrote:
> * gnu/packages/compression.scm (atool): New variable.
Thanks for the patch. While adding all compression programs supported
(e.g. tar) as inputs is probably too much given their large number, I
think it would be good to add "file" and patch in the path to "file" in
bin/atool. WDYT?
Otherwise LGTM.
ben
^ permalink raw reply [flat|nested] 6+ messages in thread
* [bug#28558] [PATCH] gnu: Add atool.
2017-09-23 8:43 ` Ben Woodcroft
@ 2017-09-23 18:16 ` Stefan Reichör
2017-10-07 20:47 ` Ludovic Courtès
0 siblings, 1 reply; 6+ messages in thread
From: Stefan Reichör @ 2017-09-23 18:16 UTC (permalink / raw)
To: 28558
Hi Ben,
> On 23/09/17 07:49, Stefan Reichör wrote:
>> * gnu/packages/compression.scm (atool): New variable.
> Thanks for the patch. While adding all compression programs supported
> (e.g. tar) as inputs is probably too much given their large number, I
> think it would be good to add "file" and patch in the path to "file"
> in bin/atool. WDYT?
Thanks for your feedback. I don't think that file is an important tool
for atool. At least I use only archives with the correct file extension.
And all the archives that I remember that I downloaded from some site
also provided the correct file extension. In that case file is not needed to
detect the archive type.
However, if you think that hard coding the full path to file is a good
thing I will update my patch. It should be doable for me...
> Otherwise LGTM.
> ben
Stefan.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [bug#28558] [PATCH] gnu: Add atool.
2017-09-23 18:16 ` Stefan Reichör
@ 2017-10-07 20:47 ` Ludovic Courtès
2017-10-08 9:25 ` Stefan Reichör
0 siblings, 1 reply; 6+ messages in thread
From: Ludovic Courtès @ 2017-10-07 20:47 UTC (permalink / raw)
To: Stefan Reichör; +Cc: 28558
Hi Stefan,
Stefan Reichör <stefan@xsteve.at> skribis:
>> On 23/09/17 07:49, Stefan Reichör wrote:
>>> * gnu/packages/compression.scm (atool): New variable.
>> Thanks for the patch. While adding all compression programs supported
>> (e.g. tar) as inputs is probably too much given their large number, I
>> think it would be good to add "file" and patch in the path to "file"
>> in bin/atool. WDYT?
>
> Thanks for your feedback. I don't think that file is an important tool
> for atool. At least I use only archives with the correct file extension.
> And all the archives that I remember that I downloaded from some site
> also provided the correct file extension. In that case file is not needed to
> detect the archive type.
>
> However, if you think that hard coding the full path to file is a good
> thing I will update my patch. It should be doable for me...
As discussed earlier in another thread, I think it’s a good idea to
hard-code absolute file names. Could you update the patch accordingly?
TIA,
Ludo’.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [bug#28558] [PATCH] gnu: Add atool.
2017-10-07 20:47 ` Ludovic Courtès
@ 2017-10-08 9:25 ` Stefan Reichör
2017-10-18 21:10 ` bug#28558: " Ricardo Wurmus
0 siblings, 1 reply; 6+ messages in thread
From: Stefan Reichör @ 2017-10-08 9:25 UTC (permalink / raw)
To: Ludovic Courtès; +Cc: 28558
> Hi Stefan,
>
> Stefan Reichör <stefan@xsteve.at> skribis:
>
>>> On 23/09/17 07:49, Stefan Reichör wrote:
>>>> * gnu/packages/compression.scm (atool): New variable.
>>> Thanks for the patch. While adding all compression programs supported
>>> (e.g. tar) as inputs is probably too much given their large number, I
>>> think it would be good to add "file" and patch in the path to "file"
>>> in bin/atool. WDYT?
>>
>> Thanks for your feedback. I don't think that file is an important tool
>> for atool. At least I use only archives with the correct file extension.
>> And all the archives that I remember that I downloaded from some site
>> also provided the correct file extension. In that case file is not needed to
>> detect the archive type.
>>
>> However, if you think that hard coding the full path to file is a good
>> thing I will update my patch. It should be doable for me...
>
> As discussed earlier in another thread, I think it’s a good idea to
> hard-code absolute file names. Could you update the patch accordingly?
>
> TIA,
> Ludo’.
Hi Ludo!
I am really busy for the next weeks. So I won't have time to do some
work for Guix. I will try to improve my patches when I find the time.
Stefan.
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#28558: [PATCH] gnu: Add atool.
2017-10-08 9:25 ` Stefan Reichör
@ 2017-10-18 21:10 ` Ricardo Wurmus
0 siblings, 0 replies; 6+ messages in thread
From: Ricardo Wurmus @ 2017-10-18 21:10 UTC (permalink / raw)
To: Stefan Reichör; +Cc: 28558-done
Hi Stefan,
I took the liberty to patch the path to file in the executable, add a
copyright line for you, and push the patch to master with commit
ef5c40aa2.
Thanks for your contribution!
--
Ricardo
GPG: BCA6 89B6 3655 3801 C3C6 2150 197A 5888 235F ACAC
https://elephly.net
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-10-20 17:04 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-09-22 21:49 [bug#28558] [PATCH] gnu: Add atool Stefan Reichör
2017-09-23 8:43 ` Ben Woodcroft
2017-09-23 18:16 ` Stefan Reichör
2017-10-07 20:47 ` Ludovic Courtès
2017-10-08 9:25 ` Stefan Reichör
2017-10-18 21:10 ` bug#28558: " Ricardo Wurmus
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).