unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
* [bug#71687] [PATCH] doc: Fix Reviewed-by format
@ 2024-06-20 21:40 Tomas Volf
  2024-06-24  1:45 ` bug#71687: " Maxim Cournoyer
  0 siblings, 1 reply; 2+ messages in thread
From: Tomas Volf @ 2024-06-20 21:40 UTC (permalink / raw)
  To: 71687
  Cc: Tomas Volf, Florian Pelz, Ludovic Courtès, Matthew Trzcinski,
	Maxim Cournoyer

The documentation does not have a space between `e' and `<', which is not how
people use it, as can be seen from git log.  So adjust the format to match the
reality.

* doc/contributing.texi (Reviewing the Work of Others): Fix format for
Reviewed-by.

Change-Id: Ib863536db72b885cf34927323cb4ebc52a8db2ed
---
 doc/contributing.texi | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/doc/contributing.texi b/doc/contributing.texi
index 938c8bfdb1..92bab5b694 100644
--- a/doc/contributing.texi
+++ b/doc/contributing.texi
@@ -2946,7 +2946,7 @@ Reviewing the Work of Others
 @cindex Reviewed-by, git trailer
 When you deem the proposed change adequate and ready for inclusion
 within Guix, the following well understood/codified
-@samp{Reviewed-by:@tie{}Your@tie{}Name<your-email@@example.com>}
+@samp{Reviewed-by:@tie{}Your@tie{}Name@tie{}<your-email@@example.com>}
 @footnote{The @samp{Reviewed-by} Git trailer is used by other projects
 such as Linux, and is understood by third-party tools such as the
 @samp{b4 am} sub-command, which is able to retrieve the complete
@@ -2958,7 +2958,8 @@ Reviewing the Work of Others
 @itemize
 @item
 If the @emph{whole} series (containing multiple commits) looks good to
-you, reply with @samp{Reviewed-by:@tie{}Your@tie{}Name<your-email@@example.com>}
+you, reply with
+@samp{Reviewed-by:@tie{}Your@tie{}Name@tie{}<your-email@@example.com>}
 to the cover page if it has one, or to the last patch of the series
 otherwise, adding another @samp{(for the whole series)} comment on the
 line below to explicit this fact.
@@ -2966,8 +2967,8 @@ Reviewing the Work of Others
 @item
 If you instead want to mark a @emph{single commit} as reviewed (but not
 the whole series), simply reply with
-@samp{Reviewed-by:@tie{}Your@tie{}Name<your-email@@example.com>} to that
-commit message.
+@samp{Reviewed-by:@tie{}Your@tie{}Name@tie{}<your-email@@example.com>}
+to that commit message.
 @end itemize
 
 If you are not a committer, you can help others find a @emph{series} you
-- 
2.45.1





^ permalink raw reply related	[flat|nested] 2+ messages in thread

* bug#71687: [PATCH] doc: Fix Reviewed-by format
  2024-06-20 21:40 [bug#71687] [PATCH] doc: Fix Reviewed-by format Tomas Volf
@ 2024-06-24  1:45 ` Maxim Cournoyer
  0 siblings, 0 replies; 2+ messages in thread
From: Maxim Cournoyer @ 2024-06-24  1:45 UTC (permalink / raw)
  To: Tomas Volf
  Cc: 71687-done, Ludovic Courtès, Florian Pelz, Matthew Trzcinski

Hello!

Tomas Volf <~@wolfsden.cz> writes:

> The documentation does not have a space between `e' and `<', which is not how
> people use it, as can be seen from git log.  So adjust the format to match the
> reality.
>
> * doc/contributing.texi (Reviewing the Work of Others): Fix format for
> Reviewed-by.
>
> Change-Id: Ib863536db72b885cf34927323cb4ebc52a8db2ed

Note that unlike in the Linux project, we punctuate our commit summaries
(with a trailing dot and capitalized first letter).

Applied, closing.

-- 
Thanks,
Maxim




^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-06-24  1:47 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-06-20 21:40 [bug#71687] [PATCH] doc: Fix Reviewed-by format Tomas Volf
2024-06-24  1:45 ` bug#71687: " Maxim Cournoyer

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).