From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id 2D8yKeaiXV/TUgAA0tVLHw (envelope-from ) for ; Sun, 13 Sep 2020 04:41:10 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id UAhcI+aiXV81BgAAB5/wlQ (envelope-from ) for ; Sun, 13 Sep 2020 04:41:10 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id CB31494071A for ; Sun, 13 Sep 2020 04:41:09 +0000 (UTC) Received: from localhost ([::1]:48326 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kHJp6-0000L0-Mf for larch@yhetil.org; Sun, 13 Sep 2020 00:41:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53296) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kHJp0-0000Kg-AW for guix-patches@gnu.org; Sun, 13 Sep 2020 00:41:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:37778) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kHJp0-0004PE-1K for guix-patches@gnu.org; Sun, 13 Sep 2020 00:41:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kHJoz-0007dd-Tx for guix-patches@gnu.org; Sun, 13 Sep 2020 00:41:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#43348] Profanity Resent-From: Raghav Gururajan Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 13 Sep 2020 04:41:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43348 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: Danny Milosavljevic Cc: 43348@debbugs.gnu.org Received: via spool by 43348-submit@debbugs.gnu.org id=B43348.159997203429321 (code B ref 43348); Sun, 13 Sep 2020 04:41:01 +0000 Received: (at 43348) by debbugs.gnu.org; 13 Sep 2020 04:40:34 +0000 Received: from localhost ([127.0.0.1]:49324 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kHJoX-0007cr-Iy for submit@debbugs.gnu.org; Sun, 13 Sep 2020 00:40:34 -0400 Received: from knopi.disroot.org ([178.21.23.139]:46896) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kHJoV-0007ci-G9 for 43348@debbugs.gnu.org; Sun, 13 Sep 2020 00:40:32 -0400 Received: from localhost (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id B79EF51B1C; Sun, 13 Sep 2020 06:40:29 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at disroot.org Received: from knopi.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id mKcs2Jghi9tI; Sun, 13 Sep 2020 06:40:27 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1599972027; bh=FD7Lumz9BRnjZZqmuac9WNAuq9zkv5IQP4NGi8hZ3kI=; h=Subject:To:Cc:References:From:Date:In-Reply-To; b=fWEm1t9iDpd9b4mgLB+Xl+aDsPrL6ib6qWKHwfAL0yoW16zMl1P2DtOHOGkZ100Bv ec8SNbkqDH8y3mARa82VnJ63pW7CCeN3z1w/SG4KF3pJ2vOhAP+WbcnWE26NyE/WTL eMUGA3dG7krcXJXjCk4Y8diaAJshm7nkyS6Iv59gmoIz7GtpWUvd4NUoD7Lh2WVuQ5 eJH5VObUTh8GkQKPIKOYJ13YyZBw7oEZUW4gRsdkB2yHZaknVxPD3D+kpMUwapn4FT U9sqPK9Q+2b3QFxmXbHjX9eh8lN/xx5xxtSFm4gV43U6SZ6YLZwltaw18+K0fe6FGb L9YkFwZXp8XTg== References: <20200912025125.7540e02a@scratchpost.org> From: Raghav Gururajan Autocrypt: addr=raghavgururajan@disroot.org; prefer-encrypt=mutual; keydata= mQENBF9bXH8BCAC7baQP1wbhQBWr5vUKUs2iVJaSGpKcjUMij7xWpfhLKIVBwqrktbrQZ/2D OTvnoGi0oBxamFZ0JIdwKygD50azPiKQtgEewXoZxx+Q5amZMPCm49hJmxuun4QUWwm2UzXe qf03/P1CA1XvJ399pGOjzmbEZKfrP5k/9JMRWYMde9+mPnOo0f1UY0plgbgC6AeQINx+N/Da RcAyqKBd3eMhbK82ZGtoVVjzhQwhs7XxWOevTFyRxFdjqgOKGf5GEXPE4V9xcCxD2NN6ukk6 4ZPXGdTXsdURmWRpZPfSetGS0E4EoGd/y1hrn2SSk4rpzp/Ygn+zEj0PZVa+aYfKjk6jABEB AAG0LlJhZ2hhdiBHdXJ1cmFqYW4gPHJhZ2hhdmd1cnVyYWphbkBkaXNyb290Lm9yZz6JAU4E EwEIADgWIQSMM/Sm4O2cGgqRyauneFo59CKMnAUCX1tcfwIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAAKCRCneFo59CKMnAQDCACwmNH4amCI1fn5tuaTeFnMKK6e4vNYeYI7KuvTCadF ZgttKdrw6l4tOLHh97J3fUKksgk+Fh9uzqyv+NFeLnkbmwT+f7mzQalMRX42eaEbKn2JRoZk navjnJe0QxjxSYqIltbm360K8OIlaE5G90oaSZU4bvCkslVM1BMWi+vjWrL5jHwTPvOLtMLk 19+XN/eOzzJkXFSti6qsOqx1CUj6Ffmz8OG1ttOAGt2ZPX+QJtMOxbdcNtlqhEbH2HS1VBuC g6jgkgpCqxXdc8QXboQ4hxoSqoFkW64aq/ydkr+6e3JafKfY9rPc9yU5/k7wv6wmgNaMp+ZN aICDu8/fFkY+uQENBF9bXH8BCADGvjSiktvmm8Yswgli/e83Zq9Kxv/2adB+9Dhyz2jX2k4w 1wCMNrmg1Ld951CpukC9uW7V6aVbmv8WEdwE4IBe1kqlxGI9PFhAKT4i9fvEaun1b6grcS1t QC1rFwXiHiEUnJE7LLNcXbn0bBi810nSvuYv42kKLG7TwUuxWAIiPj+I5v4zwyyJ2+4jzPdR PuLFBG4YEX6ECqjeGBZq58cmOWL5u6Dm8IynXiv+vCgUGd5mnIAmzxXtP2P033n7+cwEuTz8 4IdWZZBY679RnLAz/LDNxZKGUjAINvEDCrvu9iNreuOu//cMYWdSCNYLh/N8LS/g+aFR4LHH mRiWslLvABEBAAGJATYEGAEIACAWIQSMM/Sm4O2cGgqRyauneFo59CKMnAUCX1tcfwIbDAAK CRCneFo59CKMnIWiCACuKyJOqA0C6tI94eAeBfy1UMC7CvfSBOwRyrzVMOF9B/YxnrvBmhk3 e8tMwwWNctsTwyPR3fZM1SgBghjGFzVZ4xMRjlN+lrTSu2sxdQgXfjWjmBYO9LsnfvwBLi7L +WoftGgLzHk/fdLF0DdZnt9Mfrx6dG0p1GSGyvvukHs4veGDUdDfc8ZnevtM+mJx7TSQN6Zd 1bFe4W7Xqy1Gfwy29Na3inl370Qwa9Hm7thk6ai4J59gN1MPyWhbSy+tXkGiYHMxHR3JOZmV gaD1lEQw1uvPsropMEKHQz6Qqr9ryVFkeSEbDv0PZwdMGGzdn+GBFxCxa2rloGEUKYUbVQGO Message-ID: <13b0be17-7d6d-dc37-c5d7-44171301f477@disroot.org> Date: Sun, 13 Sep 2020 00:38:02 -0400 Mime-Version: 1.0 In-Reply-To: <20200912025125.7540e02a@scratchpost.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="trGnOsbbjZQ24yrDFSr0bc5wZzZCXgJcV" X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -1.0 (-) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=fail (rsa verify failed) header.d=disroot.org header.s=mail header.b=fWEm1t9i; dmarc=fail reason="SPF not aligned (relaxed)" header.from=disroot.org (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -0.01 X-TUID: YVtrsC9/NPiB This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --trGnOsbbjZQ24yrDFSr0bc5wZzZCXgJcV Content-Type: multipart/mixed; boundary="I1jlNRvFYHZk9D7pfGyiLyGyW65YGveN0" --I1jlNRvFYHZk9D7pfGyiLyGyW65YGveN0 Content-Type: multipart/mixed; boundary="------------B008D67E8C44FD2879163F15" Content-Language: en-US This is a multi-part message in MIME format. --------------B008D67E8C44FD2879163F15 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable Hi Danny! > please, for existing packages, try to be as clear as possible in the co= mmit > messages in what is changed (only one related set of things should be c= hanged > per commit). >=20 > In this case the commit confounds things: >=20 > * Changing the build-system reference. This does not enable runtime > features--which is what the commit message's topic stated that the comm= it does. > * Changing the autoconf method. This does not enable runtime features-= -which > is what the commit message's topic stated that the commit does. > * Adding Python as a NATIVE input. What is that about? Is profanity u= sing > a Python program as a compiler only? > * I think that moving those native-inputs to inputs, while correct, doe= s not > enable runtime features--which is what the commit message's topic state= d that > the commit does. > * Please use two spaces (after the period) in order to separate sentenc= es. > * Moving blocks around makes review much harder for users. >=20 > The goal of those commit messages, and of the commit rules, is to make = it > easy for each user to see at a glance what topic each commit changes. You are correct. I always do these in a hurry, sorry about that. Please find the attached patches. Regards, RG. --------------B008D67E8C44FD2879163F15 Content-Type: text/x-patch; charset=UTF-8; name="0001-gnu-profanity-Make-some-cosmetic-changes.patch" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="0001-gnu-profanity-Make-some-cosmetic-changes.patch" =46rom 45c296918fbaa8b6f6e5d8d89616683e2934292b Mon Sep 17 00:00:00 2001 From: Raghav Gururajan Date: Sun, 13 Sep 2020 00:19:38 -0400 Subject: [PATCH 1/4] gnu: profanity: Make some cosmetic changes. * gnu/packages/messaging.scm (profanity): Make some cosmetic changes. --- gnu/packages/messaging.scm | 51 ++++++++++++++++++++------------------ 1 file changed, 27 insertions(+), 24 deletions(-) diff --git a/gnu/packages/messaging.scm b/gnu/packages/messaging.scm index 1f41f0cb8b..18919341f4 100644 --- a/gnu/packages/messaging.scm +++ b/gnu/packages/messaging.scm @@ -1774,22 +1774,35 @@ are both supported).") (package (name "profanity") (version "0.9.5") - (source (origin - (method url-fetch) - (uri (string-append "https://profanity-im.github.io/profan= ity-" - version ".tar.gz")) - (sha256 - (base32 - "00j9l9v62rz9hprgiy1vrz8v3v59ph18h8kskqxr31fgqvjv5xr3"))= )) + (source + (origin + (method url-fetch) + (uri + (string-append "https://profanity-im.github.io/profanity-" + version ".tar.gz")) + (sha256 + (base32 + "00j9l9v62rz9hprgiy1vrz8v3v59ph18h8kskqxr31fgqvjv5xr3")))) (build-system gnu-build-system) (arguments - '(#:configure-flags - (list "--enable-c-plugins" - "--enable-otr" - "--enable-omemo" - "--enable-pgp" - "--enable-icons" - "--enable-notifications"))) + `(#:configure-flags + (list + "--enable-notifications" + "--enable-c-plugins" + "--enable-otr" + "--enable-pgp" + "--enable-omemo" + "--enable-icons"))) + (native-inputs + `(("autoconf" ,autoconf) + ("autoconf-archive" ,autoconf-archive) + ("automake" ,automake) + ("cmocka" ,cmocka) + ("gtk+" ,gtk+-2) + ("libnotify" ,libnotify) + ("libtool" ,libtool) + ("libsignal-protocol-c" ,libsignal-protocol-c) + ("pkg-config" ,pkg-config))) (inputs `(("curl" ,curl) ("expat" ,expat) @@ -1801,16 +1814,6 @@ are both supported).") ("openssl" ,openssl) ("readline" ,readline) ("sqlite" ,sqlite))) - (native-inputs - `(("autoconf" ,autoconf) - ("autoconf-archive" ,autoconf-archive) - ("automake" ,automake) - ("cmocka" ,cmocka) - ("gtk+" ,gtk+-2) - ("libnotify" ,libnotify) - ("libtool" ,libtool) - ("libsignal-protocol-c" ,libsignal-protocol-c) - ("pkg-config" ,pkg-config))) (synopsis "Console-based XMPP client") (description "Profanity is a console based XMPP client written in C using ncurses and libmesode, inspired by Irssi.") --=20 2.28.0 --------------B008D67E8C44FD2879163F15 Content-Type: text/x-patch; charset=UTF-8; name="0002-gnu-profanity-Move-some-dependencies.patch" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="0002-gnu-profanity-Move-some-dependencies.patch" =46rom 564fd2546244744d32fe22461406b23ba6e84f0d Mon Sep 17 00:00:00 2001 From: Raghav Gururajan Date: Sun, 13 Sep 2020 00:22:25 -0400 Subject: [PATCH 2/4] gnu: profanity: Move some dependencies. * gnu/packages/messaging.scm (profanity) [native-inputs]: Move gtk-2, libnotify and libsignal-protocol-c to ... [inputs]: ... here. The above dependencies should have been added as inputs, instead of native-inputs. --- gnu/packages/messaging.scm | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/gnu/packages/messaging.scm b/gnu/packages/messaging.scm index 18919341f4..13ed7b489c 100644 --- a/gnu/packages/messaging.scm +++ b/gnu/packages/messaging.scm @@ -1798,18 +1798,18 @@ are both supported).") ("autoconf-archive" ,autoconf-archive) ("automake" ,automake) ("cmocka" ,cmocka) - ("gtk+" ,gtk+-2) - ("libnotify" ,libnotify) ("libtool" ,libtool) - ("libsignal-protocol-c" ,libsignal-protocol-c) ("pkg-config" ,pkg-config))) (inputs `(("curl" ,curl) ("expat" ,expat) ("glib" ,glib) ("gpgme" ,gpgme) + ("gtk+" ,gtk+-2) ("libmesode" ,libmesode) + ("libnotify" ,libnotify) ("libotr" ,libotr) + ("libsignal-protocol-c" ,libsignal-protocol-c) ("ncurses" ,ncurses) ("openssl" ,openssl) ("readline" ,readline) --=20 2.28.0 --------------B008D67E8C44FD2879163F15 Content-Type: text/x-patch; charset=UTF-8; name="0003-gnu-profanity-Enable-missing-features.patch" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="0003-gnu-profanity-Enable-missing-features.patch" =46rom 0207fce7eae5b41c5f4df32ffeddeb3bba3e25cd Mon Sep 17 00:00:00 2001 From: Raghav Gururajan Date: Sun, 13 Sep 2020 00:27:19 -0400 Subject: [PATCH 3/4] gnu: profanity: Enable missing features. * gnu/packages/messaging.scm (profanity) [arguments]<#:configure-flags> [--enable-python-plugins]: New flag. [--enable-plugins]: New flag. [--enable-icons-and-clipboard]: New flag. [--enable-icons]: Remove flag. [native-inputs]: Add python-wrapper. The above changes enables support for general-plugins, python-plugins, icons and clipboard. The python-wrapper is required to enable python-plu= gins. --- gnu/packages/messaging.scm | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/gnu/packages/messaging.scm b/gnu/packages/messaging.scm index 13ed7b489c..232d80a5fc 100644 --- a/gnu/packages/messaging.scm +++ b/gnu/packages/messaging.scm @@ -1788,18 +1788,21 @@ are both supported).") `(#:configure-flags (list "--enable-notifications" + "--enable-python-plugins" "--enable-c-plugins" + "--enable-plugins" "--enable-otr" "--enable-pgp" "--enable-omemo" - "--enable-icons"))) + "--enable-icons-and-clipboard"))) (native-inputs `(("autoconf" ,autoconf) ("autoconf-archive" ,autoconf-archive) ("automake" ,automake) ("cmocka" ,cmocka) ("libtool" ,libtool) - ("pkg-config" ,pkg-config))) + ("pkg-config" ,pkg-config) + ("python" ,python-wrapper))) (inputs `(("curl" ,curl) ("expat" ,expat) --=20 2.28.0 --------------B008D67E8C44FD2879163F15 Content-Type: text/x-patch; charset=UTF-8; name="0004-gnu-profanity-Change-build-system.patch" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="0004-gnu-profanity-Change-build-system.patch" =46rom 1c777d5bd598f97bf6978f863d6752e0942ab236 Mon Sep 17 00:00:00 2001 From: Raghav Gururajan Date: Sun, 13 Sep 2020 00:30:10 -0400 Subject: [PATCH 4/4] gnu: profanity: Change build system. * gnu/package/messaging.scm (profanity) [build-system]: Change from gnu to glib-or-gtk. Glib-or-gtk is the appropriate build system, as the package depends on glib and gtk+. --- gnu/packages/messaging.scm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gnu/packages/messaging.scm b/gnu/packages/messaging.scm index 232d80a5fc..ef553e2acb 100644 --- a/gnu/packages/messaging.scm +++ b/gnu/packages/messaging.scm @@ -1783,7 +1783,7 @@ are both supported).") (sha256 (base32 "00j9l9v62rz9hprgiy1vrz8v3v59ph18h8kskqxr31fgqvjv5xr3")))) - (build-system gnu-build-system) + (build-system glib-or-gtk-build-system) (arguments `(#:configure-flags (list --=20 2.28.0 --------------B008D67E8C44FD2879163F15-- --I1jlNRvFYHZk9D7pfGyiLyGyW65YGveN0-- --trGnOsbbjZQ24yrDFSr0bc5wZzZCXgJcV Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEjDP0puDtnBoKkcmrp3haOfQijJwFAl9doisACgkQp3haOfQi jJywTgf/QdA0jKwE6VWuiDe176CkzJjo+BhG8B7mrjAlPJvwvir1/rN+O1siauGT YpJbH6xuUAK9u8TJ7lgYy9Hi/KTIoMG8MV6gC5t6R9pDDswsTihgufH2S6Md1usx NSAF26UUzl11cnlhNe9Y5OXrOHovl8Oq1TQwqjV4UOrCSRTlsA6r2KqqnbQogTQY iOBqLBAPk6bGZGJggXcT9vqhYzMx3l4L4HX+WKlPF7w28v2Molsrn8Q71VPQugz6 yqCbb603ewpcoYxk4WX/LRxDS5lxV2hVBldC+Yoh5erHZzN9pUgyF5Np21OhM3sV AejfknAkc7kmQWTmSeEgxpWpNmeICw== =kMCB -----END PGP SIGNATURE----- --trGnOsbbjZQ24yrDFSr0bc5wZzZCXgJcV--