From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id IGUbKKmKD2B5JwAA0tVLHw (envelope-from ) for ; Tue, 26 Jan 2021 03:21:13 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id gD6lI6mKD2D5cgAAbx9fmQ (envelope-from ) for ; Tue, 26 Jan 2021 03:21:13 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 02432940480 for ; Tue, 26 Jan 2021 03:21:09 +0000 (UTC) Received: from localhost ([::1]:33952 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l4Eui-0001L8-NS for larch@yhetil.org; Mon, 25 Jan 2021 22:21:08 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:52580) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l4Eub-0001Kw-Uy for guix-patches@gnu.org; Mon, 25 Jan 2021 22:21:01 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:57212) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l4Eub-0002Rb-NW for guix-patches@gnu.org; Mon, 25 Jan 2021 22:21:01 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1l4Eub-00081G-IH for guix-patches@gnu.org; Mon, 25 Jan 2021 22:21:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#46107] [PATCH 1/6] gnu: Add spglib. Resent-From: Kei Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 26 Jan 2021 03:21:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46107 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Leo Famulari Received: via spool by 46107-submit@debbugs.gnu.org id=B46107.161163123730787 (code B ref 46107); Tue, 26 Jan 2021 03:21:01 +0000 Received: (at 46107) by debbugs.gnu.org; 26 Jan 2021 03:20:37 +0000 Received: from localhost ([127.0.0.1]:40525 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l4EuC-00080V-Rl for submit@debbugs.gnu.org; Mon, 25 Jan 2021 22:20:37 -0500 Received: from mout02.posteo.de ([185.67.36.66]:32899) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l4EuA-00080G-Gd for 46107@debbugs.gnu.org; Mon, 25 Jan 2021 22:20:35 -0500 Received: from submission (posteo.de [89.146.220.130]) by mout02.posteo.de (Postfix) with ESMTPS id DBD2E2400FB for <46107@debbugs.gnu.org>; Tue, 26 Jan 2021 04:20:27 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1611631227; bh=Xa97hUWlrhzO0Tp/gzo2w00RES3FMFBe0652BQF4u0E=; h=Subject:From:To:Cc:Date:From; b=fMzl84yk1cT/8Or6jiT1J54sy+eNXSmxhmsf0vGkyaML9AJm03FdxDRUEAffuNt03 6xJZ2nCdznfNFF+D317BDaDVWdTqPaNYZ0eeL1rtP4gvn9OgTBadLDp9OwMdSJwmBd QvQoCM4eVRW1H5yqKVVvKHk8p/Fl69EP7UBULV0bhEpKMxjnpQBUYHOafQDIU58OEX hsQaMGfzf3MS1watBVEbPXfpwq73Iv1525QpoO5jlggkZQztYmbcj/BBEys87ipjTN /yJQRJw99fkZUI9K5wS63eVLXlxXh2/fve1GX0ZDxbwloC4JD9SM58tPXE3SMMh+qF zJoXNVDfO1VBA== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4DPsS90T2tz9rxK; Tue, 26 Jan 2021 04:20:24 +0100 (CET) Message-ID: <1368650a601118e624c5dec06f7c35214de3a453.camel@posteo.net> From: Kei Date: Mon, 25 Jan 2021 22:20:19 -0500 In-Reply-To: References: <20210125212042.4358-1-kkebreau@posteo.net> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 46107@debbugs.gnu.org Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -1.25 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=posteo.net header.s=2017 header.b=fMzl84yk; dmarc=fail reason="SPF not aligned (strict)" header.from=posteo.net (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 02432940480 X-Spam-Score: -1.25 X-Migadu-Scanner: scn1.migadu.com X-TUID: rg9Z6tTkFQLU On Mon, 2021-01-25 at 17:17 -0500, Leo Famulari wrote: > On Mon, Jan 25, 2021 at 04:20:42PM -0500, Kei Kebreau wrote: > > * gnu/packages/chemistry.scm (spglib): New variable. > > Thanks! LGTM > > > + #:phases > > + (modify-phases %standard-phases > > + (replace 'bootstrap > > + (lambda _ > > + ;; These files are required by the Makefile, but not provided > > by > > + ;; the developers. > > + (for-each (lambda (file) (invoke "touch" file)) > > + '("NEWS" "README" "AUTHORS")) > > + (invoke "autoreconf" "-vi")))))) > > Can you file a bug upstream about this? On closer inspection, it seems that the developer is moving to make CMake the main build system. Using the CMake build system, I ran into a known [0] inconsistency [1] between the GNU and CMake build systems used by spglib. I've patched spglib to deal with this for now, with links added in the comments. [0]: https://github.com/spglib/spglib/issues/75 [1]: https://github.com/OpenChemistry/avogadroapp/issues/97