From: Kei <kkebreau@posteo.net>
To: Leo Famulari <leo@famulari.name>
Cc: 46107@debbugs.gnu.org
Subject: [bug#46107] [PATCH 1/6] gnu: Add spglib.
Date: Mon, 25 Jan 2021 22:20:19 -0500 [thread overview]
Message-ID: <1368650a601118e624c5dec06f7c35214de3a453.camel@posteo.net> (raw)
In-Reply-To: <YA9Dk9wdYLAV7OAk@jasmine.lan>
On Mon, 2021-01-25 at 17:17 -0500, Leo Famulari wrote:
> On Mon, Jan 25, 2021 at 04:20:42PM -0500, Kei Kebreau wrote:
> > * gnu/packages/chemistry.scm (spglib): New variable.
>
> Thanks! LGTM
>
> > + #:phases
> > + (modify-phases %standard-phases
> > + (replace 'bootstrap
> > + (lambda _
> > + ;; These files are required by the Makefile, but not provided
> > by
> > + ;; the developers.
> > + (for-each (lambda (file) (invoke "touch" file))
> > + '("NEWS" "README" "AUTHORS"))
> > + (invoke "autoreconf" "-vi"))))))
>
> Can you file a bug upstream about this?
On closer inspection, it seems that the developer is moving to make CMake the
main build system. Using the CMake build system, I ran into a known [0]
inconsistency [1] between the GNU and CMake build systems used by spglib. I've
patched spglib to deal with this for now, with links added in the comments.
[0]: https://github.com/spglib/spglib/issues/75
[1]: https://github.com/OpenChemistry/avogadroapp/issues/97
prev parent reply other threads:[~2021-01-26 3:21 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-25 21:20 [bug#46107] [PATCH 1/6] gnu: Add spglib Kei Kebreau
2021-01-25 21:22 ` [bug#46107] [PATCH 2/6] gnu: Add mmtf-cpp Kei Kebreau
2021-01-25 21:22 ` [bug#46107] [PATCH 3/6] gnu: Add molequeue Kei Kebreau
2021-01-25 22:18 ` Leo Famulari
2021-01-26 3:21 ` Kei
2021-01-25 21:22 ` [bug#46107] [PATCH 4/6] gnu: Add libmsym Kei Kebreau
2021-01-25 21:22 ` [bug#46107] [PATCH 5/6] gnu: Add avogadrolibs Kei Kebreau
2021-01-25 21:22 ` [bug#46107] [PATCH 6/6] gnu: Add avogadro2 Kei Kebreau
2021-01-25 22:19 ` Leo Famulari
2021-01-26 3:24 ` bug#46107: " Kei
2021-01-29 1:05 ` [bug#46107] " Leo Famulari
2021-01-29 16:28 ` kkebreau
2021-01-29 20:20 ` Leo Famulari
2021-01-25 22:17 ` [bug#46107] [PATCH 1/6] gnu: Add spglib Leo Famulari
2021-01-26 3:20 ` Kei [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1368650a601118e624c5dec06f7c35214de3a453.camel@posteo.net \
--to=kkebreau@posteo.net \
--cc=46107@debbugs.gnu.org \
--cc=leo@famulari.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).