unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Philip McGrath <philip@philipmcgrath.com>
To: 62231@debbugs.gnu.org, Tim Johann <t1m@phrogstar.de>
Cc: ludo@gnu.org, liliana.prikler@gmail.com
Subject: [bug#62231] Chez Scheme for Racket build on aarch64 (patch attached)
Date: Sat, 25 Mar 2023 01:36:17 -0400	[thread overview]
Message-ID: <13237587.uLZWGnKmhe@bastet> (raw)
In-Reply-To: <87r0tdq51d.fsf@phrogstar.de>


[-- Attachment #1.1: Type: text/plain, Size: 538 bytes --]

On Friday, March 24, 2023 4:03:19 PM EDT Tim Johann wrote:
> Hi Philip,
> 
> Happy to be of help.
> 
> Thanks for the pointers, here's the amended patch.  I hope it is to your
> liking.
> 

Thanks, this addresses my concerns!

I'm not a Guix committer, so I'm cc'ing a couple of people who have applied 
recent patches to this file. They may want to review the commit message for 
style, also.

I expect the underlying issue would also affect riscv64, but I hit some network 
trouble when trying to look for a build log just now.

-Philip

[-- Attachment #1.2: chez-racket-aarch64-rev1.patch --]
[-- Type: text/x-patch, Size: 2110 bytes --]

commit e3c514db745d48e5ef7f7abb7b45037341298b17
Author: Tim Johann <t1m@phrogstar.de>
Date:   Fri Mar 24 21:09:52 2023 +0100

    gnu: chez-scheme-for-racket-bootstrap-bootfiles: change for aarch64.
    
    * gnu/packages/chez.scm (chez-scheme-for-racket-bootstrap-bootfiles):
      Temporary change for build on aarch64, making racket available on aarch64.
      Architecture autodetect in rktboot only addresses x86 archs, so far.
      This work-around sets the architecture, looked up in translation table,
      explicitly.  The long term solution should be to fix rktboot to include
      other natively supported architectures in the autodetect mechanism.
        cf. https://github.com/racket/racket/issues/3948
      [arguments] use --machine even when architecture is supported by Racket's
      fork of ChezScheme.

diff --git a/gnu/packages/chez.scm b/gnu/packages/chez.scm
index c6420a980e..ab6eaba6bd 100644
--- a/gnu/packages/chez.scm
+++ b/gnu/packages/chez.scm
@@ -692,10 +692,12 @@ (define-public chez-scheme-for-racket-bootstrap-bootfiles
                          (search-input-file (or native-inputs inputs)
                                             "/opt/racket-vm/bin/racket")
                          "../rktboot/main.rkt"
-                         #$@(if (racket-cs-native-supported-system?)
-                                #~()
-                                (let ((m (nix-system->pbarch-machine-type)))
-                                  #~("--machine" #$m)))))))))))))
+                         ;; Temporary handling of builds on non-x86 architectures,
+                         ;; see https://github.com/racket/racket/issues/3948
+                         ;; Autodetect in rktboot only addresses x86 archs, so far.
+                         #$@(let ((m (or (racket-cs-native-supported-system?)
+                                         (nix-system->pbarch-machine-type))))
+                              #~("--machine" #$m))))))))))))
     (supported-systems
      (package-supported-systems chez-scheme-for-racket))
     (home-page "https://github.com/racket/ChezScheme")

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2023-03-25 11:51 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-16 23:23 [bug#62231] Chez Scheme for Racket build on aarch64 (patch attached) Tim Johann
2023-03-24  1:36 ` Philip McGrath
2023-03-24 20:03   ` Tim Johann
2023-03-25  5:36     ` Philip McGrath [this message]
2023-03-26 14:26     ` bug#62231: " Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=13237587.uLZWGnKmhe@bastet \
    --to=philip@philipmcgrath.com \
    --cc=62231@debbugs.gnu.org \
    --cc=liliana.prikler@gmail.com \
    --cc=ludo@gnu.org \
    --cc=t1m@phrogstar.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).