From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id QJ2oH6Dn/2FGPAAAgWs5BA (envelope-from ) for ; Sun, 06 Feb 2022 16:22:08 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id cDZQGKDn/2FhIgAAG6o9tA (envelope-from ) for ; Sun, 06 Feb 2022 16:22:08 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 0012723775 for ; Sun, 6 Feb 2022 16:22:07 +0100 (CET) Received: from localhost ([::1]:33228 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nGjMd-0005cq-7I for larch@yhetil.org; Sun, 06 Feb 2022 10:22:07 -0500 Received: from eggs.gnu.org ([209.51.188.92]:40888) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nGjMX-0005bG-VS for guix-patches@gnu.org; Sun, 06 Feb 2022 10:22:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:45648) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nGjMX-0004Ss-LM for guix-patches@gnu.org; Sun, 06 Feb 2022 10:22:01 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nGjMX-0002ft-IV for guix-patches@gnu.org; Sun, 06 Feb 2022 10:22:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#53820] [PATCH] gnu: Add jtdx Resent-From: "Sheng Yang" Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 06 Feb 2022 15:22:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53820 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: "Maxime Devos" , 53820@debbugs.gnu.org Received: via spool by 53820-submit@debbugs.gnu.org id=B53820.164416088110212 (code B ref 53820); Sun, 06 Feb 2022 15:22:01 +0000 Received: (at 53820) by debbugs.gnu.org; 6 Feb 2022 15:21:21 +0000 Received: from localhost ([127.0.0.1]:39545 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nGjLs-0002ed-SN for submit@debbugs.gnu.org; Sun, 06 Feb 2022 10:21:21 -0500 Received: from out5-smtp.messagingengine.com ([66.111.4.29]:54213) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nGjLp-0002eO-R3 for 53820@debbugs.gnu.org; Sun, 06 Feb 2022 10:21:19 -0500 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 5F6AB5C00B4; Sun, 6 Feb 2022 10:21:12 -0500 (EST) Received: from imap48 ([10.202.2.98]) by compute4.internal (MEProxy); Sun, 06 Feb 2022 10:21:12 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.com; h= cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm2; bh=a0ZW3vtLooaAm0TiVVSMeGV/gCF/OMqiLAcZet lLJ08=; b=hHQeqgWGIk2saURciu2YLo6nyXVxZPvzpL6MmLtv33LBWoyMib3l3m IhHbw6Exn1R5yFkcHju2T4ht3Wr8REAzF5E+uLBnoKIIOMYEinF3slf+qLpk3ePV IVwk7EH20Rj+/dAknEdBfNxwP59sHGvLNnEeB+PFhmn+XgLlheyF6oapoBVcF3HY ADmWsUKYqfCTGXoV8aDrzQuEWU/dRL8ctoubokzaMsz6ZLccFGZg1Wrrsy9gGdFG 4PwWD9TYIklpLk4v5/9bVmesUTgOOMbpTf+z0EJf0/9YIq5r53y5wNMJh9H5JprF UPM0PAGDX+OfKemsZu0+Uxht0Uca86tg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=a0ZW3vtLooaAm0TiV VSMeGV/gCF/OMqiLAcZetlLJ08=; b=I0z+ktHfQRUJpGw1JDUqbUWI72K5/fYze 6j6+oxUzjsVcKqVeKkdsbL/Uuw4QIChUE0vJ76dqj/Qr40dzwJEANJavtTDsKXfb tGdtkZ5k3Ry54inkTsglYTQMGHoFhIiWwqIKJQF5rjWtwlu20/kfXrpUxsH7Cu3a xwtF4L8CoDWFAjBPSAndL4HKLI1RbNuGUN7GJPJrtK3oaQzpra8N0Xs1fsiBitQm mCvHzDtSmFcmzrFFmbTYEkZp7OadB9KyQ3AG9V3/xSWyRz9nfTdXkICgi/zZI+LX n2g2Fk9rdV8w+xnP/R+EWPEiKJsgUjvNzus3b6kvP/XMI06I4ih8g== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrheefgdejhecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefofgggkfgjfhffhffvufgtsegrtderreerredtnecuhfhrohhmpedfufhhvghn ghcujggrnhhgfdcuoehsthihrghnghesfhgrshhtmhgrihhlrdgtohhmqeenucggtffrrg htthgvrhhnpeeugeeuhfetueeiteduieeggfefjeegiedujeefhfdugfeivdegfeetgfdv tdejieenucffohhmrghinhepghhithhhuhgsrdgtohhmnecuvehluhhsthgvrhfuihiivg eptdenucfrrghrrghmpehmrghilhhfrhhomhepshhthigrnhhgsehfrghsthhmrghilhdr tghomh X-ME-Proxy: Received: by mailuser.nyi.internal (Postfix, from userid 501) id 23BC121E006E; Sun, 6 Feb 2022 10:21:12 -0500 (EST) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.5.0-alpha0-4586-g104bd556f9-fm-20220203.002-g104bd556 Mime-Version: 1.0 Message-Id: <12ff0a43-0756-4941-8713-49343ff23475@www.fastmail.com> In-Reply-To: <24e279ff1f4383c945c00eadba28810030c6e245.camel@telenet.be> References: <8d7a5134-a5c4-44b2-a99c-9ad3b1685075@www.fastmail.com> <24e279ff1f4383c945c00eadba28810030c6e245.camel@telenet.be> Date: Sun, 06 Feb 2022 09:20:51 -0600 From: "Sheng Yang" Content-Type: multipart/alternative; boundary=37c42ffd9d804a4cb78c2bd4e8d791c3 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1644160928; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=a0ZW3vtLooaAm0TiVVSMeGV/gCF/OMqiLAcZetlLJ08=; b=nDdLhHsgBqfP6sFkXNAinWaQVtqNug860aJSYASgfB0RNrQbKfmmbgrwcDX5h9+W8sRPgx AoSZsthFBSNlnw4+Kerv8UkMa2v2yQC5NE3qjeQYkVsoyIQRUigThWEpPbTEXhLUcP7EZi d5+BqEuxR9xWJOrjamiVgxa0jPy/uN9AYiMMIvD7Jm/mqa87pvGwXRzimGAnRslmQLsqWl EpncMCaesReo/fIncGMzXlxRvSSBJjSA1Fx8kR279R++Gil8FnRtcdDyTp1RtzZrQumozX OekSi5/pmwSPLkhD0BAiEJbSh8yWLShyWqX+8GnWzHVfpE3QCKO3kabqq/I/DQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1644160928; a=rsa-sha256; cv=none; b=fzgxngg7dBkxF9tLbUCMJbX+jQ0eQarvW7FH+VH4j+RJKIguWuW/VPzddiN/ad6kn/gIvZ ZGXYGJPjktPtxXYZTVbIrcQrtl322aKHymgZmMbBJjeeRYA+Ux2OCTeROHIOuJCToo5lTT 4XwR5tWyhbgpyOC3IHwjtiqssY73NN6ThiB9ijuHJUR0s6x4CUuuc5xe+Sh0vjpX8n+HRv 4arJ6Zvp/HqZ3gi1bnSwdMTHat83UMwMjI/oMEsQfTyB6MXm886L588j3MVRNQknobz/qO LnEjcHJ1/ezOt47We9wuZVabkThKfCy3SIGOuql9c/QPn+Truum000GeZMl98w== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=fastmail.com header.s=fm2 header.b=hHQeqgWG; dkim=fail ("headers rsa verify failed") header.d=messagingengine.com header.s=fm2 header.b=I0z+ktHf; dmarc=fail reason="SPF not aligned (relaxed)" header.from=fastmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -1.52 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=fastmail.com header.s=fm2 header.b=hHQeqgWG; dkim=fail ("headers rsa verify failed") header.d=messagingengine.com header.s=fm2 header.b=I0z+ktHf; dmarc=fail reason="SPF not aligned (relaxed)" header.from=fastmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 0012723775 X-Spam-Score: -1.52 X-Migadu-Scanner: scn0.migadu.com X-TUID: 2pRWNKQbMuM0 --37c42ffd9d804a4cb78c2bd4e8d791c3 Content-Type: text/plain > Have these patches been submitted upstream? If so, can we > add a link to a web page tracking upstreaming progress, > such that we can determine when 'jdtx-hamlib' can be removed > in favour of 'hamlib'? I don't think those patches are submitted upstream. I checked diff between jtdx-hamlib's master with commit 954d70c143a9a0293371d8def3a7300ce3ca68c4 , which has quite some differences. I am not a developer of either package, so I cannot tell which one/ones is necessary. As it turns out, the configure options seem a lot different from the official one. The following is in the README of jtdx-hamlib: > $ ../src/configure --prefix=$HOME/hamlib-prefix > --disable-shared --enable-static > --without-cxx-binding --disable-winradio > CFLAGS="-g -O2 -fdata-sections -ffunction-sections" > LDFLAGS="-Wl,--gc-sections" While in hamlib and wsjtx-hamlib, the build configuration is: > (arguments > `(#:configure-flags '("--disable-static" > "--with-lua-binding" > "--with-python-binding" > "--with-tcl-binding" > "--with-xml-support"))) > Given that it is a fork, doesn't the home page, synopsis and > description need to be tweaked? > > Why define and not define-public? I basically followed the existing package wsjtx-hamlib. --37c42ffd9d804a4cb78c2bd4e8d791c3 Content-Type: text/html Content-Transfer-Encoding: quoted-printable
Have these patches been submitted upstream?  If so, can = we
add a link to a web page tracking upstreaming prog= ress,
such that we can determine when 'jdtx-hamlib' can be= removed
in favour of 'hamlib'?
I don't think those patches are submitted upstream. I checked diff betw= een jtdx-hamlib's master with commit 954d70c143a9a0= 293371d8def3a7300ce3ca68c4, which has quite some differences. I am n= ot a developer of either package, so I cannot tell which one/ones is nec= essary. As it turns out, the configure options seem a lot different from= the official one. The following is in the README of jtdx-hamlib:
$ ../src/configure --prefix=3D$HOME/h= amlib-prefix
--disable-shared --enable-static
=
--without-cxx-binding --disable-winradio
CFLAGS=3D= "-g -O2 -fdata-sections -ffunction-sections"
LDFLAGS=3D"= -Wl,--gc-sections"
While in hamlib and wsjtx= -hamlib, the build configuration is:
=
(arguments
     `(#:configure-fla= gs '("--disable-static"
     &nbs= p;           &nbs= p;         "--with-lua-binding"<= br>
         &nbs= p;           &nbs= p;     "--with-python-binding"
 &= nbsp;           &= nbsp;           &= nbsp; "--with-tcl-binding"
     &= nbsp;           &= nbsp;         "--with-xml-suppor= t")))

Given that it is a fork, doesn't the home page, synop= sis and
description need to be tweaked?

=
Why define and not define-public?
= I basically followed the existing package wsjtx-hamlib.
= --37c42ffd9d804a4cb78c2bd4e8d791c3--