From: Leo Prikler <leo.prikler@student.tugraz.at>
To: Efraim Flashner <efraim@flashner.co.il>
Cc: 44640@debbugs.gnu.org
Subject: [bug#44640] [PATCH 3/3] gnu: Add python-git-hammer.
Date: Tue, 17 Nov 2020 12:01:04 +0100 [thread overview]
Message-ID: <12e66a141b28fcc6c4151b48928b25de1c8988a1.camel@student.tugraz.at> (raw)
In-Reply-To: <20201117105051.GV987@E5400>
Hello,
Am Dienstag, den 17.11.2020, 12:50 +0200 schrieb Efraim Flashner:
> Not a full review, building other packages atm
>
> On Sat, Nov 14, 2020 at 06:00:48PM +0100, Leo Prikler wrote:
> > * gnu/packages/python-xyz.scm (python-git-hammer): New variable.
> > ---
> > gnu/packages/python-xyz.scm | 31 +++++++++++++++++++++++++++++++
> > 1 file changed, 31 insertions(+)
> >
> > diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-
> > xyz.scm
> > index 7b9ab21671..c5da6b24d6 100644
> > --- a/gnu/packages/python-xyz.scm
> > +++ b/gnu/packages/python-xyz.scm
> > @@ -18296,6 +18296,37 @@ supports the globstar @code{**} operator
> > to match an arbitrary number of
> > path components.")
> > (license license:asl2.0)))
> >
>
> Does it make more sense to put this in version-control than in
> python-xyz? Can it be used as a library or is it really just a
> program
> run on its own?
I suppose it can. To begin with, there is not even an executable,
you're supposed to run it using `python -m githammer`.
> > +(define-public python-git-hammer
> > + (package
> > + (name "python-git-hammer")
> > + (version "0.3.1")
> > + (source
> > + (origin
> > + (method url-fetch)
> > + (uri (pypi-uri "git-hammer" version))
> > + (sha256
> > + (base32
> > + "16kcijngd3v6f0ym1j4qb6sp08cqb3iprqn080k3yqgd0b17dfc6")))
> > )
> > + (build-system python-build-system)
> > + (arguments
> > + `(#:tests? #f)) ; missing from distribution
>
> Let's build this one from git also, then we can run the tests
I'm on it, same for 2/3.
> > + (propagated-inputs
>
> These don't need to be propagated if this is an "application" and not
> a
> "library". They can just be regular inputs.
See my comment above.
> > + `(("python-beautifultable" ,python-beautifultable)
> > + ("python-dateutil" ,python-dateutil)
> > + ("python-gitpython" ,python-gitpython)
> > + ("python-globber" ,python-globber)
> > + ("python-matplotlib" ,python-matplotlib)
> > + ("python-sqlalchemy" ,python-sqlalchemy)
> > + ("python-sqlalchemy-utils"
> > + ,python-sqlalchemy-utils)))
> > + (home-page "https://github.com/asharov/git-hammer")
> > + (synopsis "Provide statistics for git repositories")
> > + (description
> > + "Git Hammer is a statistics tool for projects in git
> > repositories.
> > +Its major feature is tracking the number of lines authored by each
> > person for every
> > +commit, but it also includes some other useful statistics.")
> > + (license license:asl2.0)))
> > +
> > (define-public python-fusepy
> > (package
> > (name "python-fusepy")
> > --
> > 2.29.2
Regards, Leo
next prev parent reply other threads:[~2020-11-17 11:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-14 16:56 [bug#44640] [PATCH 0/3] Add python-git-hammer Leo Prikler
2020-11-14 17:00 ` [bug#44640] [PATCH 1/3] gnu: Add python-beautifultable Leo Prikler
2020-11-14 17:00 ` [bug#44640] [PATCH 2/3] gnu: Add python-globber Leo Prikler
2020-11-17 10:48 ` Efraim Flashner
2020-11-14 17:00 ` [bug#44640] [PATCH 3/3] gnu: Add python-git-hammer Leo Prikler
2020-11-17 10:50 ` Efraim Flashner
2020-11-17 11:01 ` Leo Prikler [this message]
2020-11-17 12:36 ` Leo Prikler
2020-11-18 8:40 ` bug#44640: " Efraim Flashner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=12e66a141b28fcc6c4151b48928b25de1c8988a1.camel@student.tugraz.at \
--to=leo.prikler@student.tugraz.at \
--cc=44640@debbugs.gnu.org \
--cc=efraim@flashner.co.il \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).