From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45664) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dOlq6-0006q1-Va for guix-patches@gnu.org; Sat, 24 Jun 2017 10:15:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dOlq2-0001Pn-Ss for guix-patches@gnu.org; Sat, 24 Jun 2017 10:15:06 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:33106) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dOlq2-0001PW-Jd for guix-patches@gnu.org; Sat, 24 Jun 2017 10:15:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dOlq2-000611-78 for guix-patches@gnu.org; Sat, 24 Jun 2017 10:15:02 -0400 Subject: [bug#27464] [PATCH] gnu: Add ht. Resent-Message-ID: References: <20170623161612.13783-1-boskovits@gmail.com> From: Tobias Geerinckx-Rice Message-ID: <12e5d4ca-bf4c-44b1-1f42-cc97fb7cce10@tobias.gr> Date: Sat, 24 Jun 2017 16:16:21 +0200 MIME-Version: 1.0 In-Reply-To: <20170623161612.13783-1-boskovits@gmail.com> Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="Hx2HV8m3vpax5V0rKoHnxQwlnh3qjNadq" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: boskovits@gmail.com, 27464@debbugs.gnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --Hx2HV8m3vpax5V0rKoHnxQwlnh3qjNadq Content-Type: multipart/mixed; boundary="j7HXTptxIPRTtdhm7ePxsO0DlCLH4Urwi"; protected-headers="v1" From: Tobias Geerinckx-Rice To: boskovits@gmail.com, 27464@debbugs.gnu.org Message-ID: <12e5d4ca-bf4c-44b1-1f42-cc97fb7cce10@tobias.gr> Subject: Re: [bug#27464] [PATCH] gnu: Add ht. References: <20170623161612.13783-1-boskovits@gmail.com> In-Reply-To: <20170623161612.13783-1-boskovits@gmail.com> --j7HXTptxIPRTtdhm7ePxsO0DlCLH4Urwi Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 23/06/17 18:16, G=C3=A1bor Boskovits wrote: > * gnu/packages/hexedit.scm (ht): New variable. > --- > gnu/packages/hexedit.scm | 21 +++++++++++++++++++++ > 1 file changed, 21 insertions(+) >=20 > diff --git a/gnu/packages/hexedit.scm b/gnu/packages/hexedit.scm > index d2aaec306..7fc5a20ff 100644 > --- a/gnu/packages/hexedit.scm > +++ b/gnu/packages/hexedit.scm > @@ -1,5 +1,6 @@ > ;;; GNU Guix --- Functional package management for GNU > ;;; Copyright =C2=A9 2016 Kei Kebreau > +;;; Copyright =C2=A9 2017 G=C3=A1bor Boskovits > ;;; > ;;; This file is part of GNU Guix. > ;;; > @@ -44,3 +45,23 @@ file can be a device as the file is read a piece at = a time. You can modify > the file and search through it.") > (home-page "http://rigaux.org/hexedit.html") > (license license:gpl2+))) > + > +(define-public ht > + (package > + (name "ht") > + (version "2.1.0") > + (source (origin > + (method url-fetch) > + (uri (string-append "https://sourceforge.net/projects/ht= e/files/ht-source/" I'd re-format this to wrap at <=3D 80 characters. I'm old. > + name "-" version ".tar.bz2")) > + (sha256 > + (base32 > + "0w2xnw3z9ws9qrdpb80q55h6ynhh3aziixcfn45x91bzrbifix9= i")))) The two lines above should be indented with a single space: (sha256 (base32 ("0foobar..." In a properly configured=E2=84=A2 Emacs editor, hitting C-M-q at the star= t of the package expression will do the Right Thing. > + (build-system gnu-build-system) > + (inputs `(("ncurses",ncurses))) Missing space before ,ncurses. Does this compile? If so, cool. (It does!) > + (synopsis "The HT Editor: A file editor/viewer/analyzer for execut= ables") In the spirit of section 6.7.4 of the Guix manual, I'd shorten this to (synopsis "Editor, viewer, and analyzer for executable files") > + (description "This program is a file viewer, editor and analyzer f= or text, binary, > +and (especially) executable files.") s/This program/ht/ > + (home-page "http://hte.sourceforge.net/") > + (license license:gpl2))) > + Spurious newline: $ git am ~/this Applying: gnu: Add ht. .git/rebase-apply/patch:39: new blank line at EOF. warning: 1 line adds whitespace errors. All in all trivial things! I'll leave a day or so for other reviewers. You can submit a new patch if you like, or I can make the changes myself when I push. Kind regards, T G-R --j7HXTptxIPRTtdhm7ePxsO0DlCLH4Urwi-- --Hx2HV8m3vpax5V0rKoHnxQwlnh3qjNadq Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQFBBAEBCgArFiEEeqzfDJ8DWw5d4xcqkczbm0hUG5kFAllOdDYNHG1lQHRvYmlh cy5ncgAKCRCRzNubSFQbmUDYB/9oMA8PcR3i1De9yTYY9bNqaD7cqnO2/9CKGHX4 BDm9fJprw++K1TCzX2+P4OtQkbu5/03jKf67d/UfnUoknb7uGcFDSXgT0DQpWjfv l6iExSjo61zLirmi6qMOR8MeZL2rcp9yNB4ejJsbVsonOh2ZC8JSHA7MfYANm1sr BcRTqt352sfKtIU98f0SoyWxH4/npGdQLdsojexzXvsSdX+TSNsqYfLyz0oJU43X 5L5HaX4EXncrMGO+fNA9jhEWLxjN1YEjp/p7jPqT12JPbjWVb1zRwfpNlLK/Pj7C jruG43YEA70S7CXCBiVWDYz5W6bxQ7n98MxC0yJ3IM2vvsA4 =KGDl -----END PGP SIGNATURE----- --Hx2HV8m3vpax5V0rKoHnxQwlnh3qjNadq--