From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id yCzPMUg3+2VxVwAAqHPOHw:P1 (envelope-from ) for ; Wed, 20 Mar 2024 20:21:45 +0100 Received: from aspmx1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0.migadu.com with LMTPS id yCzPMUg3+2VxVwAAqHPOHw (envelope-from ) for ; Wed, 20 Mar 2024 20:21:44 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=protonmail.com header.s=protonmail3 header.b="SW3tjx2/"; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1710962504; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=IiIK9d701nZmsDLNWzbzrQgX8GU35nJg8B2rKsBqKnI=; b=dqLqiq/Kz3QC2Ri24/PsWjcObSYb8PWvRsHDfNhQrOVa4uuMyqT/xL9fF5N9ws8aXDrBLt A8fWmMA6kpNY9hERZcU8aqpDJkBYCIXnHcwlaL9D+SfZn4ATNmh4Z76FQHFoeh3ZWRBcqX pRhPh1G09TVny7hY7kXoOSZwmb/ilBNSjuh/r02LAwhXxr4XpQuXGMj6rz2pJWfkUuzq27 GedpbXPLQH82/zqDLiYOu7c7nn1K8re/ShGJ/hh/0+8tx9o5THJUD2+CAi2AUzKGmEEzTD cu2jBZAvTmPRoZlvrGnnS0+1q0L8yxR721JkPh3LkMSXUhOUOINvdftUGOuSEQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=protonmail.com header.s=protonmail3 header.b="SW3tjx2/"; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Seal: i=1; s=key1; d=yhetil.org; t=1710962504; a=rsa-sha256; cv=none; b=emRlCQ1stoOgDK0evdKZToMlA2C/0U6JlnZx1ZGvvKUyJNEPmFwhr5FbI8nMOXqI7N0RN9 LUbVIrfs5QTYYw6+xWxHWWIExlxPhwwHbEbi9/i9cb9xcp/g+DxAfxrAgVuZuO2XOGuqds YZa19hum+cGoEnvr7cVO8Bn3zv8ZR0Ah5bdifmvTSXUXu9IL6JlL+36Es7+atkgEv7xEC8 S46cu+gx6wXrdpzLWOU9oY+VIWVjeIBJ1USWd419qjDhOhH4YW/WoyfF2mWQ6NuoDK0PHl 5pv4tZj1PmIYdeG1qcl4S5eIM4Kwcax+AhCpj4QlmRieffdUNVC0eaonTG8CUw== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id A33D452B48 for ; Wed, 20 Mar 2024 20:21:44 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rn1V7-0005EE-Nv; Wed, 20 Mar 2024 15:21:25 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rn1V5-0005E1-Il for guix-patches@gnu.org; Wed, 20 Mar 2024 15:21:23 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rn1V5-0005mO-AH for guix-patches@gnu.org; Wed, 20 Mar 2024 15:21:23 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rn1Vi-0006Xu-Gh for guix-patches@gnu.org; Wed, 20 Mar 2024 15:22:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#69885] [PATCH] gnu: Add python-x-wr-timezone. Resent-From: Skyler Ferris Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 20 Mar 2024 19:22:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 69885 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Benjamin Slade , 69885@debbugs.gnu.org Received: via spool by 69885-submit@debbugs.gnu.org id=B69885.171096250225095 (code B ref 69885); Wed, 20 Mar 2024 19:22:02 +0000 Received: (at 69885) by debbugs.gnu.org; 20 Mar 2024 19:21:42 +0000 Received: from localhost ([127.0.0.1]:58252 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rn1VO-0006Wh-2m for submit@debbugs.gnu.org; Wed, 20 Mar 2024 15:21:42 -0400 Received: from mail-40133.protonmail.ch ([185.70.40.133]:43611) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rn1VL-0006W6-9E for 69885@debbugs.gnu.org; Wed, 20 Mar 2024 15:21:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1710962453; x=1711221653; bh=IiIK9d701nZmsDLNWzbzrQgX8GU35nJg8B2rKsBqKnI=; h=Date:To:From:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=SW3tjx2/sVUcNAAm9l4G0JNYdfIEMSTO45v4YC7MI1rjEohN5YFaleyfMbgOuwxnL TWBPLAfgj57voiGfZWvM1TxHdK6nBY8LtbrcgUXeq5aEezO8BW8wpTU4swZf7Nhy8M Nu9LTvCBfDIwDhkqz5Yvaq5CJX+Nv1v5ZUnCxh4dhxkwd7hzRSBefboDS7hdhfFL0s F50OHwqu5T+PoVzti/+P75+vACJvsye+XIHmYQWZE6r3Dibd+oS3Cs0lYomxJ9Nd5d 3LISdqlAEhhcVWkps3pTE5B2D+3ayHTuYg34pRzkAMPdV8/ZbAMHLzKvwefO2MidmC 6UjBJhK9Yz9fQ== Date: Wed, 20 Mar 2024 19:20:46 +0000 Message-ID: <12d7b39d-bbe2-493a-842a-10f8b9a71593@protonmail.com> In-Reply-To: <877chzyx3t.fsf@lambda-y.net> References: <877chzyx3t.fsf@lambda-y.net> Feedback-ID: 40635331:user:proton MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Skyler Ferris X-ACL-Warn: , Skyler Ferris via Guix-patches From: Skyler Ferris via Guix-patches via Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Scanner: mx13.migadu.com X-Migadu-Spam-Score: -6.82 X-Spam-Score: -6.82 X-Migadu-Queue-Id: A33D452B48 X-TUID: Oq568m8uVoL9 Hi Benjamin, > +=C2=A0=C2=A0=C2=A0=C2=A0 '(#:phases (modify-phases %standard-phases > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (delete 'sanity-check)) Could you elaborate on why it is necessary to remove this phase? I tried=20 adding it back in and the package still built. > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 #:tests? #f)) It looks like this is here because tests require=20 python-icalendar>=3D5.0.11, correct? Could you update the existing package= =20 (note that it has 3 dependents which should be checked for compatibility=20 in this case), or add a second package with the correct version instead=20 of skipping the tests? I also tried the example from the x-wr-timezone=20 README, and the icalendar.from_ical function it uses doesn't seem to=20 exist on the 4.1.0 version of python-icalendar (or at least if it does,=20 it is not provided by the top-level icalendar package, so I expect that=20 this package would break). Note that the python-icalendar update should=20 be in a separate commit that this one is based on. Also a note about submissions: if it would be possible for you to use=20 git send-email as described in the manual, this would make it easier for=20 more reviewer to look at and so make it more likely that your patches=20 are reviewed quickly. It is described in the section "Sending a Patch=20 Series", but the instructions apply to single patches as well.=20 https://guix.gnu.org/manual/en/html_node/Sending-a-Patch-Series.html Regards, Skyler