From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id wGzEEwVsHGSFzQAASxT56A (envelope-from ) for ; Thu, 23 Mar 2023 16:11:01 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id yKG6EgVsHGRWnAAAG6o9tA (envelope-from ) for ; Thu, 23 Mar 2023 16:11:01 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id D0D9640794 for ; Thu, 23 Mar 2023 16:10:21 +0100 (CET) Authentication-Results: aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1679584221; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=Kq1uXV8mMAlq3KeObHdGxtANy/RG+JM78JkE1PyRYw0=; b=kK+xaie3iP8lL5JrFZSVP1zhIHMIJY5pohFiFxp9O2lhFp3aHRMm7km21ugCoiRHAiK6sN LIC6peNJmE6YJnteA9fUZxvtvWKXwrQSEr1yKQU0LFcIOdGsz+ohfj4nGyh2qFgWgHiJhJ HhZWjOZw5XnXvB6pW1sW+SKXPXWisYSUrGHUq5z9LAb6mh8FMcvQ83MwhTDWNiR/YlxgBJ W2H7+v0YynFB292mQoyphlo7GLyM9q5KSD6uAphvXoiNzb03IHnzJ0E0D8GAGz4ETCSuA1 3KyRg4GYhX3WwwdpZ8J97inDJQ4dUUF7w4vx9u3/6Z/nKDlvdBOyNW5xvExl5Q== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1679584221; a=rsa-sha256; cv=none; b=hxkQnrndt0rne7DHrErEbGaViP3FKOp7DUk8h0n3J6NuFJtocBlA38o40pLUXSJDf1c0nn bsTk+5dO0Aa+Lr1n6+grBexnu2RLy/hvOD+rK7dNAiO8TuFDmUJmNhTWh7n6nn4P5JliXL yI3YhvQoaBrVU9FoduDqvpuLVndunklZi7fbML/r0LxqgoKPTcBeNd/69XnYZK3tVkkgyD 2GkEAfLJPGJWu5XLDJHyl+Dx90ttH4g6/ySRZ0LUypfUKQbvgUt4CjMLbQetZgPM9XZEVU TshKFMjVR6X7n/Q1r4RHi4VOY29PyaqfzRIy7Q/kwfWy8QaZ5gZJIwEhf4NIjA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=none Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pfMa3-0004jT-8p; Thu, 23 Mar 2023 11:10:19 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pfMa2-0004jI-Jv for guix-patches@gnu.org; Thu, 23 Mar 2023 11:10:18 -0400 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pfMZm-0003Bl-2F for guix-patches@gnu.org; Thu, 23 Mar 2023 11:10:18 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pfMZl-0001pZ-OQ for guix-patches@gnu.org; Thu, 23 Mar 2023 11:10:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#62298] [PATCH v2 5/8] services: mpd: Fix unintentional API breakage for mixer-type field. Resent-From: Bruno Victal Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 23 Mar 2023 15:10:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62298 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 62298@debbugs.gnu.org Cc: ludo@gnu.org, Bruno Victal , liliana.prikler@gmail.com, maxim.cournoyer@gmail.com Received: via spool by 62298-submit@debbugs.gnu.org id=B62298.16795841787001 (code B ref 62298); Thu, 23 Mar 2023 15:10:01 +0000 Received: (at 62298) by debbugs.gnu.org; 23 Mar 2023 15:09:38 +0000 Received: from localhost ([127.0.0.1]:39124 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pfMZN-0001oq-OF for submit@debbugs.gnu.org; Thu, 23 Mar 2023 11:09:37 -0400 Received: from smtpmciv3.myservices.hosting ([185.26.107.239]:37234) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pfMZL-0001oi-AH for 62298@debbugs.gnu.org; Thu, 23 Mar 2023 11:09:35 -0400 Received: from mail1.netim.hosting (unknown [185.26.106.173]) by smtpmciv3.myservices.hosting (Postfix) with ESMTP id DE0722079A; Thu, 23 Mar 2023 16:09:32 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by mail1.netim.hosting (Postfix) with ESMTP id F1C67800B3; Thu, 23 Mar 2023 16:04:07 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at mail1.netim.hosting Received: from mail1.netim.hosting ([127.0.0.1]) by localhost (mail1-2.netim.hosting [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 4RyTKLkZAaGN; Thu, 23 Mar 2023 16:04:07 +0100 (CET) Received: from guix-nuc.home.arpa (bl9-119-177.dsl.telepac.pt [85.242.119.177]) (Authenticated sender: lumen@makinata.eu) by mail1.netim.hosting (Postfix) with ESMTPSA id 616EF800AE; Thu, 23 Mar 2023 16:04:07 +0100 (CET) From: Bruno Victal Date: Thu, 23 Mar 2023 15:02:15 +0000 Message-Id: <12a3b44e8516829fd6ef5db2b5084f7c836b99e2.1679583701.git.mirai@makinata.eu> X-Mailer: git-send-email 2.39.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: X-Migadu-Queue-Id: D0D9640794 X-Spam-Score: -0.35 X-Migadu-Spam-Score: -0.35 X-Migadu-Scanner: scn0.migadu.com List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-TUID: wC+SJfBoUuzU * gnu/services/audio.scm (mpd-output)[mixer-type]: Use sanitizer to accept both strings and symbols as values. --- gnu/services/audio.scm | 17 ++++++++++++++++- 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/gnu/services/audio.scm b/gnu/services/audio.scm index e5b065a479..56ea2f8638 100644 --- a/gnu/services/audio.scm +++ b/gnu/services/audio.scm @@ -140,6 +140,11 @@ (define (uglify-field-name field-name) (define list-of-symbol? (list-of symbol?)) + +;;; +;;; MPD +;;; + (define (mpd-serialize-field field-name value) (let ((field (if (string? field-name) field-name (uglify-field-name field-name))) @@ -294,7 +299,17 @@ (define-configuration mpd-output for this audio output: the @code{hardware} mixer, the @code{software} mixer, the @code{null} mixer (allows setting the volume, but with no effect; this can be used as a trick to implement an external mixer -External Mixer) or no mixer (@code{none}).") +External Mixer) or no mixer (@code{none})." + (sanitizer + (lambda (x) ; TODO: deprecated, remove me later. + (cond + ((symbol? x) + (warning (G_ "symbol value for 'mixer-type' is deprecated, \ +use string instead~%")) + (symbol->string x)) + ((string? x) x) + (else + (configuration-field-error #f 'mixer-type x)))))) (replay-gain-handler maybe-string -- 2.39.1