From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58181) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eyb1P-0001un-FH for guix-patches@gnu.org; Wed, 21 Mar 2018 06:31:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eyb1L-00085B-5x for guix-patches@gnu.org; Wed, 21 Mar 2018 06:31:07 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:36995) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eyb1K-00084v-SC for guix-patches@gnu.org; Wed, 21 Mar 2018 06:31:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eyb1K-00080O-Ib for guix-patches@gnu.org; Wed, 21 Mar 2018 06:31:02 -0400 Subject: [bug#30885] Submitting Patch File for r-catdap Package Description for CRAN package Resent-Message-ID: References: <87d0zyc4v8.fsf@elephly.net> From: Sahithi Yarlagadda Message-ID: <1262bbc6-6b7c-fd72-5b34-06dc3e928ebd@swecha.net> Date: Wed, 21 Mar 2018 16:00:00 +0530 MIME-Version: 1.0 In-Reply-To: <87d0zyc4v8.fsf@elephly.net> Content-Type: multipart/mixed; boundary="------------0CCE073B0210182610545208" Content-Language: en-US List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Ricardo Wurmus Cc: 30885@debbugs.gnu.org This is a multi-part message in MIME format. --------------0CCE073B0210182610545208 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Hi I resending the patch. Bear with my mistakes, im learning things. Hopefully Ill make sure my next patch would be perfect. On Wednesday 21 March 2018 12:06 PM, Ricardo Wurmus wrote: > Hi Sahithi, > > thanks for the patch! > >> + >> +(define-public r-catdap >> + (package >> + (name "r-catdap") >> + (version "1.3.4") >> + (source >> + (origin >> + (method url-fetch) >> + (uri (cran-uri "catdap" version)) >> + (sha256 >> + (base32 >> + "0i877l61f6c75pczi235rzci67w29zv1d7z5zn5p5ymndclvlpl2")))) >> + (build-system r-build-system) >> + (home-page "https://cran.r-project.org/web/packages/catdap/") >> + (synopsis "Categorical data analysis program package") >> + (description >> + "Categorical data analysis by AIC. The methodology is described in >> +Sakamoto (1992) @url{https://www.springer.com/in/book/9780792314295}") > Please use full sentences in the description. In this case I went to > the home page and downloaded the reference manual, which contains this > sentence: > > “This package provides functions for analyzing multivariate > data. Dependencies of the distribution of specified variable > (response variable) to other variables (explanatory variables) are > derived and evaluated by AIC (Akaike Information Criterion).” > > This is a better description based on that sentence: > > This package provides functions for analyzing multivariate data. > Dependencies of the distribution of the specified variable (response > variable) to other variables (explanatory variables) are derived and > evaluated by the @dfn{Akaike Information Criterion} (AIC). > > “@dfn” is used for definitions. > >> + ;; Any GPL version. >> + (license license:gpl2+))) > The comment is incorrect. The home page says: > > License: GPL-2 | GPL-3 [expanded from: GPL (≥ 2)] > > This means it is actually GPLv2+. > >> + >> + >> + >> + >> + >> + >> + >> + >> + >> + >> + >> + > Please don’t add so many empty lines at the end :) > > Could you please send an updated patch as a reply to this message? > > -- > Ricardo > > GPG: BCA6 89B6 3655 3801 C3C6 2150 197A 5888 235F ACAC > https://elephly.net > > > -- Regards Sahithi --------------0CCE073B0210182610545208 Content-Type: text/x-patch; name="0001-gnu-Add-r-catdap.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="0001-gnu-Add-r-catdap.patch" >From 993ec4eb85c24d0dcaba2052604913fb0941e96d Mon Sep 17 00:00:00 2001 From: Sahithi Yarlagadda Date: Wed, 21 Mar 2018 15:52:40 +0530 Subject: [PATCH] gnu: Add r-catdap. * gnu/packages/cran.scm (r-catdap): New variable. --- gnu/packages/cran.scm | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+) diff --git a/gnu/packages/cran.scm b/gnu/packages/cran.scm index 749eed8b5..ce09c22c5 100644 --- a/gnu/packages/cran.scm +++ b/gnu/packages/cran.scm @@ -3273,3 +3273,25 @@ those functions to be used with time series including specifications that may contain lags, diffs and missing values.") ;; Any GPL version. (license license:gpl2+))) + + +(define-public r-catdap + (package + (name "r-catdap") + (version "1.3.4") + (source + (origin + (method url-fetch) + (uri (cran-uri "catdap" version)) + (sha256 + (base32 + "0i877l61f6c75pczi235rzci67w29zv1d7z5zn5p5ymndclvlpl2")))) + (build-system r-build-system) + (home-page "https://cran.r-project.org/web/packages/catdap/") + (synopsis "Categorical data analysis program package") + (description + "This package provides functions for analyzing multivariate data. +Dependencies of the distribution of the specified variable (response +variable) to other variables (explanatory variables) are derived and +evaluated by the @dfn{Akaike Information Criterion} (AIC).") + (license license:gpl2+))) -- 2.16.2 --------------0CCE073B0210182610545208--