From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:54831) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hfjhE-0003Vl-57 for guix-patches@gnu.org; Tue, 25 Jun 2019 07:33:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hfjh9-0000bT-7u for guix-patches@gnu.org; Tue, 25 Jun 2019 07:33:08 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:45227) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hfjh8-0000ap-L0 for guix-patches@gnu.org; Tue, 25 Jun 2019 07:33:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hfjh8-0005of-GR for guix-patches@gnu.org; Tue, 25 Jun 2019 07:33:02 -0400 Subject: [bug#36258] [PATCH 1/2] gnu: monero: Update to 0.14.1.0. Resent-Message-ID: Received: from eggs.gnu.org ([2001:470:142:3::10]:54706) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hfjgV-00032Q-2I for guix-patches@gnu.org; Tue, 25 Jun 2019 07:32:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hfjgT-0008Nw-PS for guix-patches@gnu.org; Tue, 25 Jun 2019 07:32:22 -0400 Received: from mx1.riseup.net ([198.252.153.129]:52562) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hfjgT-0008Ms-JT for guix-patches@gnu.org; Tue, 25 Jun 2019 07:32:21 -0400 References: <20190617084436.12311-1-glv@posteo.net> <49b66acb-c2f9-5fd0-97aa-16711ae933e1@riseup.net> <87imsx2rk3.fsf@yamatai> <87blyobgzl.fsf@yamatai> <9abcc53c-1a07-d3b3-2b9f-1571328c7414@riseup.net> <87y31rtijx.fsf@yamatai> <87mui63rnd.fsf@yamatai> From: swedebugia Message-ID: <11d7747e-a7c8-3f29-dd8a-7dc1534dfc23@riseup.net> Date: Tue, 25 Jun 2019 13:32:15 +0200 MIME-Version: 1.0 In-Reply-To: <87mui63rnd.fsf@yamatai> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Guillaume LE VAILLANT Cc: 36258@debbugs.gnu.org On 2019-06-25 12:07, Guillaume LE VAILLANT wrote: >=20 > Guillaume LE VAILLANT a =C3=A9crit : >=20 >> swedebugia a =C3=A9crit : >> >>> Tests completed succesfully. I saw this note: >>> >>> + ;; TODO: Find why portability_wallet test fai= ls >>> + ;; Maybe the Boost version used to create the= test >>> + ;; wallet and the current Boost version are n= ot >>> + ;; completely compatible? >>> + "Serialization.portability_wallet" >>> + "is_hdd.linux_os_root") >>> >>> Did you report this upstream? >>> Could you include the failed test also (commented below the comment) >>> >>> Otherwise LGTM :) >>> >>> PS: I started working on Aeon (fork of monero) since they are very si= milar it >>> should be "easy" to package now that you got monero working again. >> >> I'm not entirely sure why the "Serialization.portability_wallet" test >> fails. It might not be related to compatibility between Boost versions= , >> because compiling with the same Boost version in two different ways >> gives different results. >> >> When I compile using 'guix build monero', the test fails. >> --- >> /tmp/guix-build-monero-0.14.1.0.drv-0/monero-0.14.1.0-checkout/tests/u= nit_tests/serialization.cpp:633: Failure >> Value of: r >> Actual: false >> Expected: true >> --- >> >> When I compile by hand using 'guix environment --pure monero', the tes= t >> passes. >=20 > I found out why the "Serialization.portability_wallet" failed; it was > because of missing write permissions on some test files. >=20 > Updated patch with the test enabled attached. >=20 Good catch :D I do not have commit access so someone else will have to commit this. I'm not going to review monero-gui because qt is too heavy for my=20 mobile bandwidth. --=20 Cheers Swedebugia