From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id wJceKjisB2BTQwAA0tVLHw (envelope-from ) for ; Wed, 20 Jan 2021 04:06:16 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id yLLXJTisB2D8SQAAbx9fmQ (envelope-from ) for ; Wed, 20 Jan 2021 04:06:16 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id E264B940482 for ; Wed, 20 Jan 2021 04:06:15 +0000 (UTC) Received: from localhost ([::1]:42320 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l24l4-0002oq-Tc for larch@yhetil.org; Tue, 19 Jan 2021 23:06:14 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:52634) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l24ks-0002nq-HW for guix-patches@gnu.org; Tue, 19 Jan 2021 23:06:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:40890) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l24ks-0001G1-AB for guix-patches@gnu.org; Tue, 19 Jan 2021 23:06:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1l24ks-0000m1-4D for guix-patches@gnu.org; Tue, 19 Jan 2021 23:06:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#45725] [PATCH] gnu: Add gutenprint. Resent-From: dftxbs3e Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 20 Jan 2021 04:06:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45725 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Received: via spool by 45725-submit@debbugs.gnu.org id=B45725.16111155052904 (code B ref 45725); Wed, 20 Jan 2021 04:06:02 +0000 Received: (at 45725) by debbugs.gnu.org; 20 Jan 2021 04:05:05 +0000 Received: from localhost ([127.0.0.1]:52436 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l24jx-0000km-Ee for submit@debbugs.gnu.org; Tue, 19 Jan 2021 23:05:05 -0500 Received: from smtp5-g21.free.fr ([212.27.42.5]:54904) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l24jv-0000kd-CO for 45725@debbugs.gnu.org; Tue, 19 Jan 2021 23:05:03 -0500 Received: from [IPv6:2a01:e0a:2a2:1350:6d9:f5ff:fe15:345c] (unknown [IPv6:2a01:e0a:2a2:1350:6d9:f5ff:fe15:345c]) by smtp5-g21.free.fr (Postfix) with ESMTP id 376635FF20; Wed, 20 Jan 2021 05:05:01 +0100 (CET) Message-ID: <11b109d12f70f56ef6d924650d480f4327f5cd24.camel@free.fr> From: dftxbs3e Date: Wed, 20 Jan 2021 05:04:58 +0100 In-Reply-To: <87eeihht5c.fsf_-_@gnu.org> References: <20210108113822.24978-1-dftxbs3e@free.fr> <20210109111236.31405-1-dftxbs3e@free.fr> <87eeihht5c.fsf_-_@gnu.org> Content-Type: multipart/signed; micalg="pgp-sha256"; protocol="application/pgp-signature"; boundary="=-/2UN2Ib3dw4/aS1ks6Uw" User-Agent: Evolution 3.38.2 (3.38.2-1.fc33) MIME-Version: 1.0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 45725@debbugs.gnu.org Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -4.45 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: E264B940482 X-Spam-Score: -4.45 X-Migadu-Scanner: scn0.migadu.com X-TUID: 8lKdoBv1WCep --=-/2UN2Ib3dw4/aS1ks6Uw Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, 2021-01-19 at 15:56 +0100, Ludovic Court=C3=A8s wrote: > Hi, >=20 > John Doe skribis: >=20 > > * gnu/packages/cups.scm (gutenprint): New variable. >=20 > [...] >=20 > > +=C2=A0=C2=A0=C2=A0 (synopsis "Printer drivers for CUPS on GNU/Linux") >=20 > You can remove =E2=80=9Con GNU/Linux=E2=80=9D, it=E2=80=99s implicit (I d= on=E2=80=99t see how it > could > be non-portable actually!). The package itself used "Linux" which I modified to GNU/Linux but I'll remove it altogether and reword it. >=20 > > +=C2=A0=C2=A0=C2=A0 ;; Supported printers list from: > > +=C2=A0=C2=A0=C2=A0 ;; http://gimp-print.sourceforge.net/p_Supported_Pr= inters.php > > +=C2=A0=C2=A0=C2=A0 ;; Remember to update on version bumps with this co= mmand: > > +=C2=A0=C2=A0=C2=A0 ;; $ curl =20 > > http://gimp-print.sourceforge.net/p_Supported_Printers.php=C2=A0| \ > > +=C2=A0=C2=A0=C2=A0 ;; grep -Po '(?<=3D^).+?(?=3D)' | sed = 's/^/@item /g' > > +=C2=A0=C2=A0=C2=A0 (description "Printer drivers for > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ^ > Please make it a full sentence, as per: >=20 > =C2=A0 =20 > https://guix.gnu.org/manual/en/html_node/Synopses-and-Descriptions.html Will do. >=20 > > +CUPS on GNU/Linux, Macintosh OS X, and other POSIX-compliant > > operating systems. > > +This project also maintains an enhanced Print plug-in for GIMP 2.x > > from > > +the same code base.=C2=A0 This driver claims to support these printers= : > > + > > +@enumerate > > +@item Canon BJ-30 > > +@item Canon BJC-50 >=20 > I think we shouldn=E2=80=99t have such lists, even with the comment above= on > how > to update it.=C2=A0 It=E2=80=99s not the right place for that and it woul= d scare > away > translators (who are already shy enough when it comes to translating > package descriptions :-)). >=20 > What you could do is write a sentence like: >=20 > =C2=A0 =E2=80=9CThis driver supports widespread inkjet printers by major = vendors, > =C2=A0 including Canon, Epson, Fujitsu, and SONY.=E2=80=9D=C2=A0 (arbitra= ry choice) >=20 > That way people will at least see the vendor names, but the > description > remains human-readable. OK, there is so many different vendors supported so I figured I'd include the full list, I'll try including a full list of vendors instead. >=20 > Otherwise LGTM.=C2=A0 Could you send an updated patch? I still have not fixed the issue where CUPS tried to find the gutenprint-5.3 filter binary within it's own package folder instead of gutenprint's. I'd appreciate some help for that. Otherwise will come to investigate soon, busy with other things now but wont last too long. >=20 > Thanks, > Ludo=E2=80=99. Thanks for the review! --=-/2UN2Ib3dw4/aS1ks6Uw Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQQozTys6hLca3Ekt8u3HhLxn6GoewUCYAer6gAKCRC3HhLxn6Go e8DRAP9tTQw/MzZqbSQy8pS/Zspt/PD+0rDAj5/EkRuXPCTpeAEArwRBtax1vV+4 OvPMTXH0opM9pryRlHjKWjo3qQSTOw4= =CTEm -----END PGP SIGNATURE----- --=-/2UN2Ib3dw4/aS1ks6Uw--