From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id KAfmEgoANmHDKAAAgWs5BA (envelope-from ) for ; Mon, 06 Sep 2021 13:48:26 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id eGv5DgoANmE3FQAA1q6Kng (envelope-from ) for ; Mon, 06 Sep 2021 11:48:26 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 9243DFE81 for ; Mon, 6 Sep 2021 13:48:25 +0200 (CEST) Received: from localhost ([::1]:45990 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mND6t-0007Bv-P9 for larch@yhetil.org; Mon, 06 Sep 2021 07:48:23 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37670) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mND6Y-0007Ab-LU for guix-patches@gnu.org; Mon, 06 Sep 2021 07:48:06 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:40663) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mND6Y-0002qS-EE for guix-patches@gnu.org; Mon, 06 Sep 2021 07:48:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mND6Y-0004lD-Cu for guix-patches@gnu.org; Mon, 06 Sep 2021 07:48:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#50072] [PATCH WIP 0/4] Add upstream updater for git-fetch origins. Resent-From: Maxime Devos Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 06 Sep 2021 11:48:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50072 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: Sarah Morgensen , Xinglu Chen , 50072@debbugs.gnu.org Received: via spool by 50072-submit@debbugs.gnu.org id=B50072.163092886818266 (code B ref 50072); Mon, 06 Sep 2021 11:48:02 +0000 Received: (at 50072) by debbugs.gnu.org; 6 Sep 2021 11:47:48 +0000 Received: from localhost ([127.0.0.1]:52208 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mND6J-0004kY-VA for submit@debbugs.gnu.org; Mon, 06 Sep 2021 07:47:48 -0400 Received: from michel.telenet-ops.be ([195.130.137.88]:55228) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mND6H-0004kJ-EO for 50072@debbugs.gnu.org; Mon, 06 Sep 2021 07:47:46 -0400 Received: from butterfly.local ([188.188.57.172]) by michel.telenet-ops.be with bizsmtp id qbni250053ix9AL06bniSq; Mon, 06 Sep 2021 13:47:43 +0200 Message-ID: <10996c63a8690ceea6c88a5fc88ddabad7b000dd.camel@telenet.be> From: Maxime Devos Date: Mon, 06 Sep 2021 13:47:35 +0200 In-Reply-To: <87k0ju80kk.fsf_-_@gnu.org> References: <8d1ae518b23fac5b15812a30b11df1c360ab3fbf.1629068119.git.iskarian@mgsn.dev> <86fsv9jh8h.fsf_-_@mgsn.dev> <7986923ce7712dc341e859e62675abee12072922.camel@telenet.be> <87k0ju80kk.fsf_-_@gnu.org> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-v5Hhn2n+7sUb2T2OY7dt" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r21; t=1630928863; bh=+wgEu9X7wVJIzWD/KjNKPrKL7CGeR9Fe11JK3/vWzq4=; h=Subject:From:To:Cc:Date:In-Reply-To:References; b=KNtzuNSN5MsmsNen0vw5N6ysNiJ1yNdt7of3z7Q0hutN6D2o4uN7rAkOOamron42s UAsdJLDZo1H38PXxx/uICTubxJoGetZGnFHC7T2v0h1AxFF3RzYU+Wu8Ogyl5+XthS lGBM0e6wabAKHwQw22dweve0l+3L9/7ZObqJlxoPmyoeMdbt/xp93QZz0J0RAbHbGL zuIFVyTseHB0GIeQwDQe80en1Edy3v1UomZ80B+7fABMqNKJ92oqQ1ScOime/C510+ kkYtlsfVwzSsAqqei59Y0GxjhXaogpoDnEHDd2+hWGQBKep9MuvXvnBYjquWZDeuOa WauI2ZuJpvJzQ== X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1630928905; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=+wgEu9X7wVJIzWD/KjNKPrKL7CGeR9Fe11JK3/vWzq4=; b=S4o+KRHyMideFGv2k4pICzuzGcEDrmEBvxT2E5eUEoFbZutEV3s1zBzi5tmNj5Kundj/e8 tJabpXAzYiYNJHaeNyk0XwymLB3HMhKG7sNAaFfhB1/2OmgtwAX9CzL1KQ0UilD2rVmV9W v0C23BwolizjjZcrCOKE14V7J5Miwb6KJrKuXn5tKK+CyQWiBt66gB7hq0zPagf/dmV00u LtE9zbZ+ZAOBMZC3bXM+Ts3NacMr89CH4Df2vbnVYfalG69Fl/aaW5WUQj0B+w/qhh0E6R nVcfahPlSKIIAMrodXvZnoZ6WK3RYiL8ma1irVMGe9AK0stKAlWgUILVv2hFVA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1630928905; a=rsa-sha256; cv=none; b=qgZxSccG9aFW6Rjywut9DSZpNTET1RbIaSlLtXhID+zTw0+WEjyhBEiuaxBZArk5RrINn9 hQ/0xjQouroHlyvqROddYAXpSJvmP3MikaL9zlJHonOEkivPhv+XrAfI6OtZGIj/j38iOJ DQyffi+CCG4ZFEVAzuL2dmZbCz+Qj0eu6MEN4pwOrxjAgpzS3qPWulgJC7qzoE/ZjF4R7o pq4xgTqUUqSxaT7al4O8L8RxcuxH+O2ygQpq2xVVxo36+tUJkMXOS9Ne7bN05dNYMKVtli uYHzCeUbNyh//Crt4KKRgaeADJ/uyq0syZs8smvUikJ+Jf95S463VNTjMrA6RQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=telenet.be header.s=r21 header.b=KNtzuNSN; dmarc=fail reason="SPF not aligned (relaxed)" header.from=telenet.be (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -3.41 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=telenet.be header.s=r21 header.b=KNtzuNSN; dmarc=fail reason="SPF not aligned (relaxed)" header.from=telenet.be (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 9243DFE81 X-Spam-Score: -3.41 X-Migadu-Scanner: scn0.migadu.com X-TUID: +V/PZ/olNR4w --=-v5Hhn2n+7sUb2T2OY7dt Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi, Ludovic Court=C3=A8s schreef op ma 06-09-2021 om 12:23 [+0200]: > > > >=20 > > > > [...] > > > > Does it support packages defined like (a) > > > >=20 > > > > (define-public gnash > > > > (let ((commit "583ccbc1275c7701dc4843ec12142ff86bb305b4") > > > > (revision "0")) > > > > (package > > > > (name "gnash") > > > > (version (git-version "0.8.11" revision commit)) > > > > (source (git-reference > > > > (url "https://example.org") > > > > (commit commit))) > > > > [...]))) > > >=20 > > > No, it doesn't. Since the commit definition isn't part of the actual > > > package definition, the current code has no way of updating it. It > > > would require a rewrite of the edit-in-place logic with probably a lo= t > > > of special-casing. > >=20 > > Perhaps a 'surrounding-expression-location' procedure can be defined? > >=20 > > (define (surrounding-expression-location inner-location) > > "Determine the location of the S-expression that surrounds the S-expr= ession > > at INNER-LOCATION, or #false if the inner S-expression is at the top-le= vel." > > ??? Something like 'read', but in reverse, maybe? > > Doesn't need to support every construct, just "string without escapes= " and > > (parentheses other-things) might be good enough in practice for now) > >=20 > > Seems tricky to implement, but it would be more robust than relying > > on conventions like =E2=80=98the surrounding 'let' can be found by movi= ng two columns > > and two lines backwards=E2=80=99. Or see another method (let&) below t= hat is actually > > implemented ... >=20 > I think we can work incrementally. It wouldn=E2=80=99t be unreasonable t= o start > with a =E2=80=98definition-location=E2=80=99 procedure that would work in= a way similar > to =E2=80=98package-field-location=E2=80=99 (essentially =E2=80=98read=E2= =80=99 each top-level sexp of > the file and record the location of the one that immediately precedes > the package location.) =E2=80=98package-field-location=E2=80=99 (currently) doesn't work like that= . Currently, it extracts the location from the package, opens the file, uses a procedure 'goto' that works like 'seek' except that it accepts line and column number= s instead of byte offsets. What you proposed could work, though it seems a bit inefficient to me. Asking upstream for an update probably takes a lot more time though. > But maybe the discussion in will > give us something nice. Greetings, Maxime --=-v5Hhn2n+7sUb2T2OY7dt Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYTX/1xccbWF4aW1lZGV2 b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7ophAQC7GSfWH0C/M+dLr8Jkdg0mny/r yoG85v0kcMpD6jIk/AD+MgzJwEj1oLYkRndZc9Ql4ILaODgpj0tHD0orEEKA/gk= =koNy -----END PGP SIGNATURE----- --=-v5Hhn2n+7sUb2T2OY7dt--