From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:51598 helo=eggs1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jQKI6-0004N2-VM for guix-patches@gnu.org; Sun, 19 Apr 2020 20:28:03 -0400 Received: from Debian-exim by eggs1p.gnu.org with spam-scanned (Exim 4.90_1) (envelope-from ) id 1jQKI6-00007d-Ee for guix-patches@gnu.org; Sun, 19 Apr 2020 20:28:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:34714) by eggs1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jQKI6-00007B-22 for guix-patches@gnu.org; Sun, 19 Apr 2020 20:28:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jQKI5-0005Is-Vv for guix-patches@gnu.org; Sun, 19 Apr 2020 20:28:01 -0400 Subject: [bug#40646] gnu: Add blueman. Resent-Message-ID: Date: Sun, 19 Apr 2020 20:25:57 -0400 In-Reply-To: <87ftcz15i4.fsf@gnu.org> References: <87mu773ekd.fsf@gnu.org> <20200415135234.3bd638ea.raghavgururajan@disroot.org> <87ftcz15i4.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="----SIZ6943KMLEU5MWV90IEJ6NVSUTP64" Content-Transfer-Encoding: 7bit From: Raghav Gururajan Message-ID: <1082E275-C6A5-4D33-997F-2E45C7A36BB4@disroot.org> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 40646@debbugs.gnu.org ------SIZ6943KMLEU5MWV90IEJ6NVSUTP64 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi Ludo! Yes yes, sorry, I did not over look=2E I was gonna try it and then goon le= t you know=2E :-) Regards, RG=2E On April 19, 2020 6:21:23 p=2Em=2E EDT, "Ludovic Court=C3=A8s" wrote: >Hi, > >"Raghav Gururajan" skribis: > >>>> + (substitute* "apps/blueman-adapters=2Ein" >>>> + (("@PYTHON@") (string-append (assoc-ref inputs "python") >>>> + "/bin/python3=2E7"))) >>>=20 >>> Are you sure this is necessary? If these are scripts, the >>> =E2=80=98patch-shebangs=E2=80=99 phase should take care of it=2E Perha= ps it=E2=80=99s enough >to >>> add =E2=80=98python-wrapper=E2=80=99 as an input (it provides a =E2=80= =9Cpython=E2=80=9D executable) >and >>> then you can remove all this? >> >> It is not necessary=2E Those scripts were not patched by >'patch-shebangs' phase, and received warnings during build=2E So >corrected them manually=2E :-) > >I think you overlooked the rest of my comment: if you add >=E2=80=98python-wrapper=E2=80=99 as an input, everything will be fine=2E > >Could you check? > >Thanks in advance! > >Ludo=E2=80=99=2E --=20 Sent from my Android device with K-9 Mail=2E Please excuse my brevity=2E ------SIZ6943KMLEU5MWV90IEJ6NVSUTP64 Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi Ludo!

Yes yes, sorry, I did not over loo= k=2E I was gonna try it and then goon let you know=2E :-)

Regards,RG=2E

On April 19, 2020 6:21:23 p=2Em= =2E EDT, "Ludovic Court=C3=A8s" <ludo@gnu=2Eorg> wrote:
Hi,

"Raghav Gururajan" <raghavgururajan@di=
sroot=2Eorg> skribis:

+ (substitute* "apps/blueman-adapters=2Ein"+ (("@PYTHON@") (string-append (assoc-ref inputs "python")
+ "/bin/pyth=
on3=2E7")))

Are you sure this is necessary? If these ar=
e scripts, the
=E2=80=98patch-shebangs=E2=80=99 phase should take care o=
f it=2E Perhaps it=E2=80=99s enough to
add =E2=80=98python-wrapper=E2=80=
=99 as an input (it provides a =E2=80=9Cpython=E2=80=9D executable) and
=
then you can remove all this?

 It is not necessary=2E T=
hose scripts were not patched by 'patch-shebangs' phase, and received warni=
ngs during build=2E So corrected them manually=2E :-)

I=
 think you overlooked the rest of my comment: if you add
=E2=80=98python=
-wrapper=E2=80=99 as an input, everything will be fine=2E

Could you =
check?

Thanks in advance!

Ludo=E2=80=99=2E

--
Sent from my Android device with K-9 Mail=2E Please ex= cuse my brevity=2E ------SIZ6943KMLEU5MWV90IEJ6NVSUTP64--