From: Christopher Baines <mail@cbaines.net>
To: 74950@debbugs.gnu.org
Cc: "Ludovic Courtès" <ludo@gnu.org>,
"Maxim Cournoyer" <maxim.cournoyer@gmail.com>
Subject: [bug#74950] [PATCH] doc: contributing: Add guidance on reverting commits.
Date: Wed, 18 Dec 2024 17:43:32 +0000 [thread overview]
Message-ID: <105caea83cc475bd2b89acf6be9b1ad2f2daf227.1734543812.git.mail@cbaines.net> (raw)
Particularly to cover the case where things might need to happen with the
build farms if changes are reverted.
* doc/contributing.texi (Commit Access): Add guidance on reverting commits.
Change-Id: Iba320b76b0927b693c75054b5473a50bdd77c7ee
---
doc/contributing.texi | 14 ++++++++++++++
1 file changed, 14 insertions(+)
diff --git a/doc/contributing.texi b/doc/contributing.texi
index d4784de452..c94ae940fa 100644
--- a/doc/contributing.texi
+++ b/doc/contributing.texi
@@ -2945,6 +2945,20 @@ Commit Access
a consensus about the problem, learning from it and improving
processes so that it's less likely to reoccur.
+@subsubsection Reverting commits
+
+Like normal commits, the commit message should state why the changes are
+being made, which in this case would be why the commits are being
+reverted.
+
+If the changes are being reverted because they led to excessive number
+of packages being affected, then a decision should be made whether to
+allow the build farms to build the changes, or whether to avoid
+this. For the bordeaux build farm, commits can be ignored by adding them
+to the @code{ignore-commits} list in the
+@code{build-from-guix-data-service} record, found in the bayfront
+machine configuration.
+
@subsection Commit Revocation
In order to reduce the possibility of mistakes, committers will have
base-commit: 2185b5ad3d252774ae633a90e03d34cc24b95c38
--
2.46.0
next reply other threads:[~2024-12-18 17:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-18 17:43 Christopher Baines [this message]
2024-12-19 1:51 ` [bug#74950] [PATCH] doc: contributing: Add guidance on reverting commits Maxim Cournoyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=105caea83cc475bd2b89acf6be9b1ad2f2daf227.1734543812.git.mail@cbaines.net \
--to=mail@cbaines.net \
--cc=74950@debbugs.gnu.org \
--cc=ludo@gnu.org \
--cc=maxim.cournoyer@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).