From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id 8L2yF7aAv2Cn6QAAgWs5BA (envelope-from ) for ; Tue, 08 Jun 2021 16:37:42 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id gHXtEraAv2DmZgAAbx9fmQ (envelope-from ) for ; Tue, 08 Jun 2021 14:37:42 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 0CE4E19B9D for ; Tue, 8 Jun 2021 16:37:42 +0200 (CEST) Received: from localhost ([::1]:34338 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lqcrM-0001Vf-Ui for larch@yhetil.org; Tue, 08 Jun 2021 10:37:40 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37300) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lqcqk-0000H5-8f for guix-patches@gnu.org; Tue, 08 Jun 2021 10:37:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:47897) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lqcqk-00078z-1X for guix-patches@gnu.org; Tue, 08 Jun 2021 10:37:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lqcqk-0000sH-07 for guix-patches@gnu.org; Tue, 08 Jun 2021 10:37:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#48909] [PATCH] gnu: Add goldendict. References: <20210607200532.27565-1-sarg@sarg.org.ru> In-Reply-To: <20210607200532.27565-1-sarg@sarg.org.ru> Resent-From: Brendan Tildesley Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 08 Jun 2021 14:37:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48909 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: "48909@debbugs.gnu.org" <48909@debbugs.gnu.org> Cc: Sergey Trofimov Received: via spool by 48909-submit@debbugs.gnu.org id=B48909.16231629903316 (code B ref 48909); Tue, 08 Jun 2021 14:37:01 +0000 Received: (at 48909) by debbugs.gnu.org; 8 Jun 2021 14:36:30 +0000 Received: from localhost ([127.0.0.1]:59443 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lqcqE-0000rQ-6c for submit@debbugs.gnu.org; Tue, 08 Jun 2021 10:36:30 -0400 Received: from mout-p-101.mailbox.org ([80.241.56.151]:32980) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lqcq9-0000r4-70 for 48909@debbugs.gnu.org; Tue, 08 Jun 2021 10:36:29 -0400 Received: from smtp1.mailbox.org (smtp1.mailbox.org [80.241.60.240]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-101.mailbox.org (Postfix) with ESMTPS id 4Fzt8f4FZlzQk93; Tue, 8 Jun 2021 16:36:18 +0200 (CEST) X-Virus-Scanned: amavisd-new at heinlein-support.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=brendan.scot; s=MBO0001; t=1623162976; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=htbbu/eXB5ku8tIAVKbzJ9dNYtGYRjTvfHmOIIctUGs=; b=r9yvirGIfJ67gaeusLQCn3p/g+AIHivDYuMLD8CoMk+Py2rNkOOafO0WK38SCubpnTy/Ig n5YRRUsRq0QXQbfOYYRjof0OGRulsR74AqQ1BbgEzmV2VZk6FoIynKJxHyEn6hALj6vmaa n6zXCVmgT7vemuC4DpiH0psBASuBz4HYVk1wT+5sid831WjO3gkg9FI4bn+84Se6Y6qo0t i6644YEIYhgmMC2royaF1Bm+wVvE8jr4EapgDYkx0ivdw/MozG5O9UFjLnjkYAcHGibprk NFXylKhMD6M6tx0DsiWUyeTUqwsvwmJ2qW/gtoiakztAfYnLbLWnnT69MuS6Sg== Received: from smtp1.mailbox.org ([80.241.60.240]) by spamfilter03.heinlein-hosting.de (spamfilter03.heinlein-hosting.de [80.241.56.117]) (amavisd-new, port 10030) with ESMTP id f-kr-BwWUaZb; Tue, 8 Jun 2021 16:36:14 +0200 (CEST) Date: Tue, 8 Jun 2021 16:36:13 +0200 (CEST) From: Brendan Tildesley Message-ID: <1051806061.54116.1623162973231@office.mailbox.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Priority: 3 Importance: Normal X-MBO-SPAM-Probability: X-Rspamd-Score: -1.96 / 15.00 / 15.00 X-Rspamd-Queue-Id: 4B449189F X-Rspamd-UID: 2d00d0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1623163062; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=htbbu/eXB5ku8tIAVKbzJ9dNYtGYRjTvfHmOIIctUGs=; b=K5VPQyLzzNW8JolkhA67ZlAIeHMzFbYgXIszCrkHzjFz2lleXabMtZVrgPD+Czdf+6tus+ 00G4Ln8suo91M7BYqKyzEQ+JrI3IM0pTxDE4upVKJNuveQnk56+9TsCC2RpyjzMOIK3YFd DpblnCSWvyS+ScyHMQuaNDXegrd7YeRPFCAvE3EKSLYMSQeg2g6S8SKEvD77Gy9CekGejT 6Fmr4R/egygHXLsPUsiPUZOcp1emTlKa4SgYwNOUAl3IVGJdBvqP4l34ejVGI50jeKKO6h KM9Op24b7oFTF4z7VUqqc3mnSkxWTKSoGjWzZgjfjJ/VloTbj0v5zaXGm80QVg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1623163062; a=rsa-sha256; cv=none; b=LTmg2Z+Fiya9LKDVlI9rpTG3M5fy7fOZROVNvRWyWKpEinJkOXZ/gk6x9vFZJ1VDIHBGw1 t/5R1jh+WtBzIe8JArtE4MhOuCnFaCMcSIYsJt6VuUnoVpFUmRErOICIdIcHNapHlux11S GcvZsTVv0ouflhix6yxzwGeyx6tTTfkPxeA64OpCye2v1+S+KYoZPFz/TLdkwK39K5OD9K 7ZuhpB4gx1U6MioMat5Plt4dD818rejwnAkrPwaIz+w5S2r57ZL7eEmu9Iq/XpmDQwAevL 41bLTPA4C8rh3RTgWo7QJqwduvZkUnWaYjOkb+NeUol57Ibtl+9RQxA1oXUsWw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=brendan.scot header.s=MBO0001 header.b=r9yvirGI; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -1.42 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=brendan.scot header.s=MBO0001 header.b=r9yvirGI; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 0CE4E19B9D X-Spam-Score: -1.42 X-Migadu-Scanner: scn0.migadu.com X-TUID: xvEkBduK6vp0 The program phones home to check for updates at this url http://goldendict.org/latest_release.php?current=1.5.0-RC2+git&platform=x11 Setting checkForNewReleases( false ), in config.cc should fix it... Actually Nix has a patch to disable updates that edits some other lines for some reason. Theres also a substitute fixing the hardcoded hunspell-1.6.1. Not sure if that is needed. Also consider adding opencc as an input and adding "CONFIG+=chinese_conversion_support" I tried packaging this years ago but I got stuck figuring out how Goldendict is supposed to find system installed dictionaries. Ludo suggested a patch but I can't code in C/C++ so I was unable to do it. https://lists.gnu.org/archive/html/guix-devel/2017-10/msg00238.html You can see that Goldendict looks in these places for dictionaries: #ifdef Q_OS_LINUX if ( QDir( "/usr/share/stardict/dic" ).exists() ) c.paths.push_back( Path( "/usr/share/stardict/dic", true ) ); if ( QDir( "/usr/share/dictd" ).exists() ) c.paths.push_back( Path( "/usr/share/dictd", true ) ); if ( QDir( "/usr/share/opendict/dictionaries" ).exists() ) c.paths.push_back( Path( "/usr/share/opendict/dictionaries", true ) ); if ( QDir( "/usr/share/goldendict-wordnet" ).exists() ) c.paths.push_back( Path( "/usr/share/goldendict-wordnet", true ) ); if ( QDir( "/usr/share/WyabdcRealPeopleTTS" ).exists() ) c.soundDirs.push_back( SoundDir( "/usr/share/WyabdcRealPeopleTTS", "WyabdcRealPeopleTTS" ) ); if ( QDir( "/usr/share/myspell/dicts" ).exists() ) c.hunspell.dictionariesPath = "/usr/share/myspell/dicts"; I think Guix/Nix support should be added directly upstream, so it can look in /run/current-system/profile/share and $GUIX_PROFILE/share for dictionaries. However it would still be good to add goldendict and work on that later.