From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id CBRcI4sP/2KpMgEAbAwnHQ (envelope-from ) for ; Fri, 19 Aug 2022 06:20:27 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id QClQI4sP/2KbPgAA9RJhRA (envelope-from ) for ; Fri, 19 Aug 2022 06:20:27 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 46D5D1E141 for ; Fri, 19 Aug 2022 06:20:27 +0200 (CEST) Received: from localhost ([::1]:39468 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oOtUf-0006M5-QP for larch@yhetil.org; Fri, 19 Aug 2022 00:20:25 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41932) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oOtUI-0006Lv-7F for guix-patches@gnu.org; Fri, 19 Aug 2022 00:20:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:39160) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oOtUH-0004xv-UQ for guix-patches@gnu.org; Fri, 19 Aug 2022 00:20:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oOtUH-0004TS-QA for guix-patches@gnu.org; Fri, 19 Aug 2022 00:20:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#57280] [PATCH 0/3] Add documentation-files argument to emacs build system. Resent-From: Liliana Marie Prikler Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 19 Aug 2022 04:20:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57280 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Andrew Tropin Cc: 57280@debbugs.gnu.org Received: via spool by 57280-submit@debbugs.gnu.org id=B57280.166088279217179 (code B ref 57280); Fri, 19 Aug 2022 04:20:01 +0000 Received: (at 57280) by debbugs.gnu.org; 19 Aug 2022 04:19:52 +0000 Received: from localhost ([127.0.0.1]:57142 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oOtU8-0004T0-Ac for submit@debbugs.gnu.org; Fri, 19 Aug 2022 00:19:52 -0400 Received: from mail-ed1-f66.google.com ([209.85.208.66]:37612) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oOtU2-0004SZ-Dg for 57280@debbugs.gnu.org; Fri, 19 Aug 2022 00:19:51 -0400 Received: by mail-ed1-f66.google.com with SMTP id b16so4254533edd.4 for <57280@debbugs.gnu.org>; Thu, 18 Aug 2022 21:19:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:user-agent:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc; bh=yJ4z0CDH1EPZEC4Wq/+uUFDE+GS8kvKTfUZRHKwec/g=; b=Q7zYmoPUcTIP7hbJ0VxkxuHP1X2pi/JFWx52S4zoI0+3vcai2fefaaazvw/lgaAxxM Gx8HfQkfw+URRicohFQBmsA1kLtyhoMWGRfZw4Zxd/LXmGrdcl8eI/LF7wEE6xdj+q/Q cf9NdQzeyWahewzBaVRMDxdw138AwFqGGPqzZyng2s/Rb9evWaf9zJ8UZ45J648Oq+rz tqZC5BsUUdBX4xTpYq0drz2cZQZ04g+2jVM2mVxBvc5dS/kVnF48j+r4EoiBrxoFMFWS xHzMzZvtwLxEnBR8yrBEpjRjEwgKUSB9UVIyUM6AIyVmbtatKhUuaqbbW7oR3+7qg6us G7HA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:user-agent:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc; bh=yJ4z0CDH1EPZEC4Wq/+uUFDE+GS8kvKTfUZRHKwec/g=; b=BN4DUbNqAkessnu6lc6//owPf3GBwDVPKKTg+gh+s1l6tlw4K+NRJ8czDK0eKvZ6zg bSOmc4vQrOhAqdjsh6ZA1P4SJC3XcOC9f2AMFZLaiN+iPRHo8WVm5BW8zGBAQazpYrV+ 4ZXGTufqz3URpAZHMZkJXeoa4f3PSKD0A7Q1HR4TIYdvYA9/3AwP87ZHHZGgcY1IhXX8 9g0x86xDOzDs7TiZvXmGMHtcS+o/8sR26nsjhjaYd/UluM3M3D/7kbMJWIhZi2R7tWQd 88jj2lBAEqvIKjlm7I+W8sZ3oryOzesSh8e8xk9w+uNNuzd7KArtbEPdQ9n8DPgWGGbS KRjA== X-Gm-Message-State: ACgBeo1NZJB6M83kVnAGracHKvIFcuDUuhLzQhSwBWSIC3iDYU8mvVJ8 YaarMJOkCRhxHnrFn0XR6iU= X-Google-Smtp-Source: AA6agR4Z8CQpItYv3bNq/vOsGczH5G68Il9HgTL6KLsPXDvxrMknczZI8iNZRhRPss73nWphNlyknw== X-Received: by 2002:a05:6402:42d3:b0:435:2c49:313d with SMTP id i19-20020a05640242d300b004352c49313dmr4565957edc.86.1660882780301; Thu, 18 Aug 2022 21:19:40 -0700 (PDT) Received: from nijino.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id dk5-20020a0564021d8500b00442d5054a51sm2312422edb.87.2022.08.18.21.19.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Aug 2022 21:19:39 -0700 (PDT) Message-ID: <0f6169482efaaf9f0caac9810841e38c9c569e66.camel@gmail.com> From: Liliana Marie Prikler Date: Fri, 19 Aug 2022 06:19:38 +0200 In-Reply-To: <87k074gb69.fsf@trop.in> References: <87wnb5lhyr.fsf@trop.in> <107d9c475d47842d67db4f0a7d85d63ae11f9f3c.camel@gmail.com> <87k074gb69.fsf@trop.in> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.42.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1660882827; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=yJ4z0CDH1EPZEC4Wq/+uUFDE+GS8kvKTfUZRHKwec/g=; b=oJIqweQQbUajluHuWdW1a9k1nbRIhBPk0lBEqhCg2kGeTsgP2+eLldLmXhHJALk1+DsC/t gm1BSEn93AhA0LLOCnVCZpEUENOXKLXXoSZH2sZYr2a3kyFL60AjZ5VlRqIDPCfsonrdE7 nYZYNl1y/lcoqs2X3/l1dh7l/NoErSYM7cuLO8TBoQHAc5w9HKwsO1QfHFanFMvTTMqrG7 c0D8YsO8YW3PJLSXhbH2MFh3lCLtOkWZXjhMgfypVlcl5JvKCZB6fxavztauxOrvKPCVFB hTI8xmZW4iwh9+63HERQ1frPmeVvx6GSfRN+ivP9aXD/r/wq7g+f9amt//PNdw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1660882827; a=rsa-sha256; cv=none; b=R6iePZFCjMK2pU91sGx5bNDBByAnSS6KNH/TsibGKakjWA+hngHbWib3Fb1Gh4xR/tjR6k 1C6xLP1PYSc1tcPnSe7za3SGsAu8ElwkXbMkxziGPxlk4lMDZCJzgdopRKSurzANL28Q2l n506YPBOVVvDOqObe/iEBIOldOBYPKrgAXZDrGFc4Uoqp8UKCR08ORMASRoTZAfgR2roBb OaEIImV3rdClaZl36C+m8T3KObFyv6dS8kJqf0Db3s8cYTxZBLE02eCYDTQuR6gCLPPVdl a0NSjwZDQKF/AbGKOZkHA3oE6shVa4ouqDGlVCyEeAr1E/gzLNMeEtSQPVCYAw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=Q7zYmoPU; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 5.15 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=Q7zYmoPU; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 46D5D1E141 X-Spam-Score: 5.15 X-Migadu-Scanner: scn0.migadu.com X-TUID: L9u+pn2M9pXw Am Freitag, dem 19.08.2022 um 06:33 +0300 schrieb Andrew Tropin: > On 2022-08-18 20:31, Liliana Marie Prikler wrote: > [...] > > Am Donnerstag, dem 18.08.2022 um 17:50 +0300 schrieb Andrew Tropin: > > > [...] > > > +(define (default-texinfo) > > > +  "Return the default texinfo package." > > > +  ;; Lazily resolve the binding to avoid a circular dependency. > > > +  (let ((texinfo-mod (resolve-interface '(gnu packages texinfo)))) > > > +    (module-ref texinfo-mod 'texinfo))) > > > + > > >  (define* (lower name > > >                  #:key source inputs native-inputs outputs system > > > target > > > +                documentation-files > > I don't think hard-coding this list is useful.  Instead, it would be > > nice if we simply used find-files with the right pattern, and use a > > binary switch as in meson-build-systems #:glib-or-gtk? > > It's not clear how to find a documentation file heuristically, it can > be README, DOCUMENTATION, README.org, docs/MANUAL.org docs/PACKAGE.texi > or anything else, morevover a few of them can be present at the same > time and I'm afraid it will be a very tough task to understand which of > them to use. I think it's possible to cover most of those with heuristics. For the rest, we can still override the phase or just rename the file to something our heuristics handle. > > > > > +                (texinfo (default-texinfo)) > > >                  (emacs (default-emacs)) > > >                  #:allow-other-keys > > >                  #:rest arguments) > > > @@ -77,6 +85,7 @@ (define private-keywords > > >                          ;; Keep the standard inputs of 'gnu- > > > build- > > > system'. > > >                          ,@(standard-packages))) > > >           (build-inputs `(("emacs" ,emacs) > > > +                         ,@(if (null? documentation-files) '() > > > `(("texinfo" ,texinfo))) > > >                           ,@native-inputs)) > > We should probably append rather than prepend implicit inputs. > > In fact, doing so for emacs itself also means that people could > > prepend their own emacs if emacs-minimal is not enough rather than > > needing a transformer. > > > > I thought #:emacs and #:texinfo arguments are enough to specify > custom emacs/texinfo inputs. And what if any of the documentations needs emacs-org rather than the org included by emacs-minimal? Spamming keywords is not helpful. Cheers > >