From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id II1VOVLEY2dNWwEA62LTzQ:P1 (envelope-from ) for ; Thu, 19 Dec 2024 06:59:31 +0000 Received: from aspmx1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1.migadu.com with LMTPS id II1VOVLEY2dNWwEA62LTzQ (envelope-from ) for ; Thu, 19 Dec 2024 07:59:31 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b="FWD/TnND"; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=OFO2DEWF; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1734591570; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=S6cryWGRFbiIw073CMK83xjbngpe6oxgj6/55p5pWtU=; b=tV4ERXzYPbasD4RWPibipD+Hiw2fO1uXiVPSQakNntzSbZqM7TR8YIgVMOYbh/IoGP03oQ 2BP3KklAXeCSaI9pwd3ERRcvEaIxQgO7s01jlsriLXLSqXgUNiDfTyWyVz4QJqa/FvM+4I Hjz9qEtMF8Juzbjl5eF49x8MZ7IHFDj3CKLrxmYto8KuPyryTAcvaQDR6TtA23xQv3wXdt 6LXhBV9XpAJIkxfEIaSohKw7IZnvWwSRGH3CPiOoo7GYxJ8/uQsWoB1zU5nESbIUeAMm9C sYUHJ6t4rTkTvP3usawQ+Ot/F6RB97ymbpriS59tJ/8OR/kS8D8KEPpaZTvPdQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b="FWD/TnND"; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=OFO2DEWF; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Seal: i=1; s=key1; d=yhetil.org; t=1734591570; a=rsa-sha256; cv=none; b=TjP4aGZIqJu/6IqfQfW2fy7cBjZsg6+uU2+L64ewEE+sDvlc1dyW/su4hRBEpWNz7Y8HvM BbT5E2iw0c63RUgLEwUQEIL+pYny95kgMovgJtPqhAdzPPh8myqQIvpN64iqyKP02Vd9S4 I8Au8KcxqBGoB7ZksyMwl6lFIQrimWVmgTYScibaCr7dFnVUl+G3sRcebFjBB1bNT0od8g pPDvrOgnnjqlgK+xxwRAaSaPjwNDf3ALkNQ+q2rrcBcPyfrbC6tz/j9rixRKcuc8utqyLZ lR7fxYBmcbA5GbpgNDkyNocfTe2dk/V6L1460qcq7rpodbZJ5eEqwNtJUeNMkw== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 8E52FADF for ; Thu, 19 Dec 2024 07:59:30 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tOAUz-0006k6-4J; Thu, 19 Dec 2024 01:59:05 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tOAUw-0006ji-Vv for guix-patches@gnu.org; Thu, 19 Dec 2024 01:59:03 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tOAUw-0005H6-Mr; Thu, 19 Dec 2024 01:59:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:From:To:Subject; bh=S6cryWGRFbiIw073CMK83xjbngpe6oxgj6/55p5pWtU=; b=FWD/TnNDv9yivA97bkDdGs7x5n2OCtf9ArGNrufTIH+4OBsZe0kOHmN/agMPOr2PewqG3Ra3xoGGdXrgPDYtkPxYkmX9R4Gjx+FLsusSBEhHcJ/uekIJ4sNWiB8NTL9K5AwdhkktiTF4XcZ9l0//+JqYEs5+DTP8P68sP7v6zHuH0jWaZkCx+6JqCzx0yiMp/tseDlsdgBNv/oR3uf1Kxq7VqDK/bEE38tWdIaCKem/XbXCQqGEVzMFCH8AkDaUafNj8hBgn3YazP5gkJnS2ugN/z9/P//xHCTb5TsenDduStzgHTnxZQqZoins0sD2XHQh/BLHQ3mNA01lHUyDCjA==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tOAUw-0005rs-BH; Thu, 19 Dec 2024 01:59:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#74962] [PATCH] etc/guix-install.sh: Explicit shebang to use /usr/bin/env. Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: ludo@gnu.org, guix-patches@gnu.org Resent-Date: Thu, 19 Dec 2024 06:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 74962 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 74962@debbugs.gnu.org Cc: Maxim Cournoyer , ludo@gnu.org X-Debbugs-Original-To: guix-patches@gnu.org X-Debbugs-Original-Xcc: ludo@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.173459149522474 (code B ref -1); Thu, 19 Dec 2024 06:59:02 +0000 Received: (at submit) by debbugs.gnu.org; 19 Dec 2024 06:58:15 +0000 Received: from localhost ([127.0.0.1]:37187 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tOAUB-0005qQ-3H for submit@debbugs.gnu.org; Thu, 19 Dec 2024 01:58:15 -0500 Received: from lists.gnu.org ([209.51.188.17]:54278) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tOAU8-0005qI-UN for submit@debbugs.gnu.org; Thu, 19 Dec 2024 01:58:14 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tOAU8-0006hS-Ln for guix-patches@gnu.org; Thu, 19 Dec 2024 01:58:12 -0500 Received: from mail-pl1-x62f.google.com ([2607:f8b0:4864:20::62f]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tOAU7-00059z-1O for guix-patches@gnu.org; Thu, 19 Dec 2024 01:58:12 -0500 Received: by mail-pl1-x62f.google.com with SMTP id d9443c01a7336-21634338cfdso5758485ad.2 for ; Wed, 18 Dec 2024 22:58:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1734591488; x=1735196288; darn=gnu.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=S6cryWGRFbiIw073CMK83xjbngpe6oxgj6/55p5pWtU=; b=OFO2DEWFaLQwkZanDTF/xc13VYloN8myAjaYA189HoZOL9em9bBHDGV5pEdsCZotVr pJXZlMlUIegZe4IUOXYlQG12eOpjZWA1AvJJhYv3zn7IivfirZ4XRzyTD/t98EG1LFax BTS14GwxE54uUbadVmT7gTGKp5kmcYmh9J8I0fjW1UBj1i0KoMxDWLQXrRVyTOOwAnng Sg1+PQ8h8WBCWhUvTBlPHWf9rByg5zimHhesoK1+pKteMS8qeJO5dj1V+jdDsqccw/iv ltQtYz9GtHDoU70+r5EN+eIGR40ytqS7eQmXnzf4wIj2CzoF6hxlgfpSAe6R2QDVNs/G vYoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734591488; x=1735196288; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=S6cryWGRFbiIw073CMK83xjbngpe6oxgj6/55p5pWtU=; b=jBEQb7P5N1/M3t4mccMMb4uykENvBw0e0jFRp7eNL1f/IMKJlcQ3GKgMKgmRt6n3Kl OCa6HhMcSB4JUlEWXt1+Sb6yhtt/4l6Vt9oTMY1InR1leYJPd16k9sbBAgS4djPcGxlR +JkNiqmAzTRcQctvzny2A9j7vsRR3r6R2ZEBhb8xSsSdcvdQtiaNMDaDIBoiHlc/92tv f99c6IxyTGqCwVfoA8c9oWsfJx32QSZFjhcDS16iXEYfEXcmji4wgyxmQsRu4RUcJnBv s9q8g5A5L90nesAWWvT1cgKPvpVNGL2ZIqw7z2o3srH6DsxhyLbdQLuQMaStmFCZHENC hpNw== X-Gm-Message-State: AOJu0YzPB2JxKg1WCMbaQNFzP2OmxhsGZzacixHifIyTNyd3pfx/8ouy +Q81cQCkk78Cyp7+BVb6EbU/ugAIqlvUe9rthLzheknxyM5Y3wWmSKN19B2O37w= X-Gm-Gg: ASbGncsSdW+0aw1vQUgqVKjBh0jMITgcZOlnuvQmbpHW4NoLPaH01fQLdCxWZqfeHV1 1HzE/AhEOGxzZSA6TbA0K7IQAnbCK5A4bLDwfigr8q51VoCsDksatLNkqtwCS9Zi2k0upuF2na7 dA7/tvSdNmOejEHeUrtWRkPEQo4AfMY+FtaIa6PcIOn4Zj99qS2ijbDR/8rr20i1m5JRgifq2ox drcxCecpFrP7Zp6y0XHGCh59uGQXRNQify6+B9FIsE3hybw8iHZ0vSnGUcX2eDgHAX0T4qnQik= X-Google-Smtp-Source: AGHT+IEOlXB3nj1YtRcYFxLRIqsXVO6RV6JttwdExU8VoSDMzl3NF6+wTjXh4F2nd3yTpKE+RVTNRg== X-Received: by 2002:a17:902:db0f:b0:217:89da:fd54 with SMTP id d9443c01a7336-218d722f88fmr95716015ad.33.1734591488349; Wed, 18 Dec 2024 22:58:08 -0800 (PST) Received: from localhost.localdomain ([2405:6586:be0:0:c8ff:1707:9b9:af89]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-219dca04c85sm5779665ad.271.2024.12.18.22.58.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Dec 2024 22:58:07 -0800 (PST) From: Maxim Cournoyer Date: Thu, 19 Dec 2024 15:57:53 +0900 Message-ID: <0e7da0b076ebc6a90ae1c8c2c760b89ad6dd1d5e.1734591473.git.maxim.cournoyer@gmail.com> X-Mailer: git-send-email 2.46.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2607:f8b0:4864:20::62f; envelope-from=maxim.cournoyer@gmail.com; helo=mail-pl1-x62f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Scanner: mx13.migadu.com X-Migadu-Spam-Score: -0.53 X-Spam-Score: -0.53 X-Migadu-Queue-Id: 8E52FADF X-TUID: UkMzFehQBZkP Having an explicit shebang tells something useful: we depend on Bash. Tools such as shellcheck make use of it. The original technical reason for avoiding /usr/bin/env is no more (Guix System lacking it). * etc/guix-install.sh: Adjust shebang. Remove conditional 'exec bash' further block below. Change-Id: I3c92a9e58fe11610dfbf74dbbd4b1ac8852abcf0 --- etc/guix-install.sh | 15 ++++----------- 1 file changed, 4 insertions(+), 11 deletions(-) diff --git a/etc/guix-install.sh b/etc/guix-install.sh index f07b2741bb..481eb6f12a 100755 --- a/etc/guix-install.sh +++ b/etc/guix-install.sh @@ -1,4 +1,4 @@ -#!/bin/sh +#!/usr/bin/env bash # GNU Guix --- Functional package management for GNU # Copyright © 2017 sharlatan # Copyright © 2018 Ricardo Wurmus @@ -9,7 +9,7 @@ # Copyright © 2020 Daniel Brooks # Copyright © 2021 Jakub Kądziołka # Copyright © 2021 Chris Marusich -# Copyright © 2021, 2022, 2023 Maxim Cournoyer +# Copyright © 2021, 2022, 2023, 2024 Maxim Cournoyer # Copyright © 2022 Prafulla Giri # Copyright © 2023 Andrew Tropin # Copyright © 2020 David A. Redick @@ -31,10 +31,8 @@ # # You should have received a copy of the GNU General Public License # along with GNU Guix. If not, see . - -# We require Bash but for portability we'd rather not use /bin/bash or -# /usr/bin/env in the shebang, hence this hack. - +# +# # Environment variables # # GUIX_BINARY_FILE_NAME @@ -50,11 +48,6 @@ # installation required the user to extract Guix packs under /gnu to # satisfy its dependencies. -if [ "x$BASH_VERSION" = "x" ] -then - exec bash "$0" "$@" -fi - set -eo pipefail [ "$UID" -eq 0 ] || { echo "This script must be run as root."; exit 1; } base-commit: 17c0aa6192f6a90c227e92720f2d63240996d0d4 -- 2.46.0