From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id aMaUN1GeVWIyuwAAgWs5BA (envelope-from ) for ; Tue, 12 Apr 2022 17:44:17 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id +OUjMFGeVWKqEgEAG6o9tA (envelope-from ) for ; Tue, 12 Apr 2022 17:44:17 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 9FCBF99DD for ; Tue, 12 Apr 2022 17:44:17 +0200 (CEST) Received: from localhost ([::1]:46798 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1neIgi-00052r-Mv for larch@yhetil.org; Tue, 12 Apr 2022 11:44:16 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42612) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1neIgU-00051k-SF for guix-patches@gnu.org; Tue, 12 Apr 2022 11:44:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:55552) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1neIgU-0006k8-Jf for guix-patches@gnu.org; Tue, 12 Apr 2022 11:44:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1neIgU-0005Gx-Et for guix-patches@gnu.org; Tue, 12 Apr 2022 11:44:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#54882] [PATCH 2/2] gnu: Add hut. Resent-From: Maxime Devos Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 12 Apr 2022 15:44:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54882 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Dhruvin Gandhi , 54882@debbugs.gnu.org Received: via spool by 54882-submit@debbugs.gnu.org id=B54882.164977820720213 (code B ref 54882); Tue, 12 Apr 2022 15:44:02 +0000 Received: (at 54882) by debbugs.gnu.org; 12 Apr 2022 15:43:27 +0000 Received: from localhost ([127.0.0.1]:49449 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1neIfv-0005Fx-76 for submit@debbugs.gnu.org; Tue, 12 Apr 2022 11:43:27 -0400 Received: from laurent.telenet-ops.be ([195.130.137.89]:38680) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1neIfs-0005Fi-CV for 54882@debbugs.gnu.org; Tue, 12 Apr 2022 11:43:25 -0400 Received: from ptr-bvsjgyhxw7psv60dyze.18120a2.ip6.access.telenet.be ([IPv6:2a02:1811:8c09:9d00:3c5f:2eff:feb0:ba5a]) by laurent.telenet-ops.be with bizsmtp id HrjN270094UW6Th01rjNyj; Tue, 12 Apr 2022 17:43:22 +0200 Message-ID: <0da419e7da045a2321e83a0754068b69823d8055.camel@telenet.be> From: Maxime Devos Date: Tue, 12 Apr 2022 17:43:16 +0200 In-Reply-To: References: <20220412122319.24231-1-contact@dhruvin.dev> <20220412122319.24231-2-contact@dhruvin.dev> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-StcoctP9hoHArYTrnEea" User-Agent: Evolution 3.38.3-1 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22; t=1649778202; bh=d9TYMY68bDK2qyxrly9atEmd2cSfEMqL9aZ1q7Y/uOM=; h=Subject:From:To:Date:In-Reply-To:References; b=m4kuo0rwAXBqyRuQyE7QTw9QFGQY1dEF9Oo5OaD9p3o9ClWEp8OADNQGqJC9qb9D3 OVVr2FqGxqNrACAKQkFyDMhmznps8q7EvTKPUA4iSMumaaDXqk43+lvUhLcLUbhO6M Xobpbd8eQDfuin4l3fJ0aDl+OSEV6M3xdv2GBuTLQD9yRynR7DnbrJQcoaZhdZGPwv GSYoJJ5JriG9+YR1QYYONKGH8ikb7ZwW232wU0MThOF45u5K3A3ZgWsIhgMBxDm48d /4KenMjm3IV/RQg9FVr0YxYVReCqaOtSWWgk6zIq7zL4etfseEwE/VzCnnhCXb1CDS VQgXXP21Nv8BQ== X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" Authentication-Results: aspmx1.migadu.com; none X-Migadu-Scanner: scn1.migadu.com X-TUID: iKpwmO5vAOCV --=-StcoctP9hoHArYTrnEea Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Dhruvin Gandhi schreef op di 12-04-2022 om 18:42 [+0530]: > On Tue Apr 12, 2022 at 6:06 PM IST, Maxime Devos wrote: > > Only one package per patch.=C2=A0 From (guix)Submitting Patches: > >=20 > > =C2=A0=C2=A0 13. Verify that your patch contains only one set of relate= d changes. > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 Bundling unrelated changes together make= s reviewing harder and > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 slower. > >=20 > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 Examples of unrelated changes include th= e addition of several > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 packages, or a package update along with= fixes to that package. > Should I submit a patch for each dependency? Or do you mean I should > send a separate patch for updating github.com/spf13/cobra? A separate patch like for updating github.com/spf13/cobra. > All newly added packages before hut's definition are required to build > hut, so I put them together in one commit. FWIW, a separate patch makes it easier to see at a glance which commit modifies which packages. Greetings, Maxime. --=-StcoctP9hoHArYTrnEea Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYlWeFBccbWF4aW1lZGV2 b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7hY6APwONnwuqsApemPLNzPxLYubxqg4 Fd/lPFrlqYZr4fHsBwEAr+9lV1mVVcVrqKTmKkFI+Xpm2Q5JF8IozBTqq5ue3gY= =lo/n -----END PGP SIGNATURE----- --=-StcoctP9hoHArYTrnEea--