From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:8:6d80::]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id kC8aEphTiGAbfgEAgWs5BA (envelope-from ) for ; Tue, 27 Apr 2021 20:10:32 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id MHWsDZhTiGCsLAAAB5/wlQ (envelope-from ) for ; Tue, 27 Apr 2021 18:10:32 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id BE7921659C for ; Tue, 27 Apr 2021 20:10:31 +0200 (CEST) Received: from localhost ([::1]:32976 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lbSAI-0002rw-BN for larch@yhetil.org; Tue, 27 Apr 2021 14:10:30 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52440) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lbS9u-0002rT-E8 for guix-patches@gnu.org; Tue, 27 Apr 2021 14:10:07 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:39318) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lbS9p-00063w-UE for guix-patches@gnu.org; Tue, 27 Apr 2021 14:10:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lbS9p-0003kv-Oe for guix-patches@gnu.org; Tue, 27 Apr 2021 14:10:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#46012] Acknowledgement (Upgrade Nheko) Resent-From: Maxime Devos Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 27 Apr 2021 18:10:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46012 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: =?UTF-8?Q?Nicol=C3=B2?= Balzarotti , 46012@debbugs.gnu.org Received: via spool by 46012-submit@debbugs.gnu.org id=B46012.161954696114373 (code B ref 46012); Tue, 27 Apr 2021 18:10:01 +0000 Received: (at 46012) by debbugs.gnu.org; 27 Apr 2021 18:09:21 +0000 Received: from localhost ([127.0.0.1]:50864 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lbS9B-0003jl-EK for submit@debbugs.gnu.org; Tue, 27 Apr 2021 14:09:21 -0400 Received: from michel.telenet-ops.be ([195.130.137.88]:60852) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lbS97-0003jZ-W1 for 46012@debbugs.gnu.org; Tue, 27 Apr 2021 14:09:20 -0400 Received: from ptr-bvsjgyjmffd7q9timvx.18120a2.ip6.access.telenet.be ([IPv6:2a02:1811:8c09:9d00:aaf1:9810:a0b8:a55d]) by michel.telenet-ops.be with bizsmtp id xu9G240040mfAB406u9G06; Tue, 27 Apr 2021 20:09:16 +0200 Message-ID: <0d873a1e5f8db448e279d558d9f6845e161cccb7.camel@telenet.be> From: Maxime Devos Date: Tue, 27 Apr 2021 20:09:08 +0200 In-Reply-To: <87k0onrfu7.fsf@guixSD.i-did-not-set--mail-host-address--so-tickle-me> References: <875z3ryvk0.fsf@guixSD.i-did-not-set--mail-host-address--so-tickle-me> <87ft2mc7a4.fsf@guixSD.i-did-not-set--mail-host-address--so-tickle-me> <87k0onrfu7.fsf@guixSD.i-did-not-set--mail-host-address--so-tickle-me> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-//tY9B7+5SsLG3GHBbQD" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r21; t=1619546956; bh=5cEn7f6uh0VVSybazQlbayqqGEcZYJBBNpuyEwvtJjQ=; h=Subject:From:To:Date:In-Reply-To:References; b=GlZyzdJ78e+eu6e0tGheFyBrEC8Qzo6BHA36zDOEe9xGVJhqngqAWCvyxGOTD3ooY iUgAmYPGRJq4OXF8MtRpC7kfu92moXKQ4bUb4e+DYydS6FBDzYVsebQSiv1TajnZ70 fjxl2dnq3A6NNe4r+OJjpF/8Gnpxw9ROW6LPhOZE9641vEuCfLBWdLVQB84a30etqv V6vZTubOHN04z63Ijd7m2J5fepb2CM7ZXwUMUCZrBZ7PruegEg9iNtK/VTdWYkjm5B owrUC82y9LciFOVO4XDsrjNufB3BSxbOz3PT7qEQyr4N20mZFlPzwjfgICHvTKYNXO a22wE2kwHYMAw== X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1619547031; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=5cEn7f6uh0VVSybazQlbayqqGEcZYJBBNpuyEwvtJjQ=; b=vBPgtVR4mU0DEDHzKKDpCMSttu2jHJrP6au3kNfBiNKzaab3wly0DcfK5WHNGKDsrGAem4 mpcRV1LNSsqonGIdLljAm66LNmVPccU1ozmOaRIGNJEZcphislpj/145NX4sJgD8jpxkoB R/RV1FiKaqiXncN/cz5CWQJP3olApAbcEz50hA5oVCviO3QNEvG/dcLIh3QpT3tpE9V+J2 SWs0KuRwbTn+l8zSOvtSW8SkWK9mKub5uzp6/UTrVTCdgCKRlcsQoWMMu/pAk/7MbRnu93 WQwhBS0QSAbfT8cm2WqrzGtDOftoAOzDvfEdazlzSy/nRWTRlrW7lS722sSmIA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1619547031; a=rsa-sha256; cv=none; b=GZ/rKDHhUPRO2rJnbWXU2s9teOwHqWFpMDRUQCsBE9yzMtPK71zoqfKt8OMUX6OBi1yBsw a78qq+srMRJW48zYoyM1u5BT1uQBmLKhyZqeQobwRHXZYXtINwTtImlj9QysHRS5I2mpWq I83gBJDm8r0mza9c+/iyah1+Ztxq53QlI0/h1LBbve1BewVvjGwoDfrBzHaz3FSyYoObll Lm6Cmedn9jcXYPKTPx7O238ZpnodMfxbVV2E9FPcY4W/QiPYWuLgtWQIJKfmCouMA4Yh3I QQeLEtlBn8C3m4yBOGUdCJjdI/BB8NbrzKpy3Tlo5fxISH20b0qB5OzFClNlRA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=telenet.be header.s=r21 header.b=GlZyzdJ7; dmarc=fail reason="SPF not aligned (relaxed)" header.from=telenet.be (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -3.45 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=telenet.be header.s=r21 header.b=GlZyzdJ7; dmarc=fail reason="SPF not aligned (relaxed)" header.from=telenet.be (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: BE7921659C X-Spam-Score: -3.45 X-Migadu-Scanner: scn0.migadu.com X-TUID: 54H+THIZfCfV --=-//tY9B7+5SsLG3GHBbQD Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Nicol=C3=B2 Balzarotti schreef op di 27-04-2021 om 15:56 [+0200]: > + (synopsis "C++ header-only HTTP/HTTPS server and client library") > + (description "cpp-httplib is a C++11 single-file header-only cross > +platform blocking HTTP/HTTPS library, easy to setup. Just include the > +@file{httplib.h} file in your code!") This is a little misleading, as shared libraries are build, as BUILD_SHARED= _LIBS is enabled. Maybe "cpp-http is a single-file header-only library" --> "cpp-http can be used as a single-file header-only=20 library"? About =E2=80=98header-only=E2=80=99: this is true, but ultimately irrelevan= t to the user (=3D C++ developer on a Guix System or using Guix on top of a foreign distr= o). But there's also a desirable thing called =E2=80=98portability=E2=80=99, th= e user might be searching for a single-header web server software to distribute to other people (not on Guix) in source form ... I'm conflicted if "single-file header" should be included in the descriptio= n. If you decide to remove it, I suggest you add a comment like ;; this package is not graftable, as everything is implemented in a singl= e ;; header to prevent trouble in a (admittedly somewhat far-fetched, no insult intende= d to its developers) future where cpp-httplib becomes a very popular dependen= cy in Guix. > + #:phases > + (modify-phases %standard-phases > + (replace 'check > + (lambda* (#:key source #:allow-other-keys) > + ;; openssl genrsa wants to write a file in the git checkout > + (copy-file (string-append source "/test") "test") > + (chmod "test" #o744) > + (invoke "make")))))) Tests most likely should not be run when cross-compiling. I'm not 100% sur= e, but you might need to do something like > + (lambda* (#:key tests? source #:allow-other-keys) > + ;; openssl genrsa wants to write a file in the git checkout > + (when tests? > + (copy-file (string-append source "/test") "test") > + (chmod "test" #o744) > + (invoke "make"))))))) Search for example for "when tests?" in gnu/packages/python-xyz.scm. > + ("zlib" ,zlib))) In I see a few lines #ifdef CPPHTTPLIB_ZLIB_SUPPORT #include #endif so it seems zlib should be in (inputs ...) instead. I also saw these lines: #ifdef CPPHTTPLIB_BROTLI_SUPPORT #include #include #endif Would it be useful to include brotli? #ifdef CPPHTTPLIB_OPENSSL_SUPPORT #include #include ... Likewise, for openssl? Greetings, Maxime. --=-//tY9B7+5SsLG3GHBbQD Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYIhTRBccbWF4aW1lZGV2 b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7vk4AQDTpwkB30S1On0jKIQEbcdCWT4u eEqjY2juhlzJibCa6QEApqJrVdZepIHcGbb3A/KgU69qUJh7XDBl1KSHAqDUOg8= =uVKs -----END PGP SIGNATURE----- --=-//tY9B7+5SsLG3GHBbQD--