bug#26515: [PATCH] gnu: Add emacs-calfw.

bug#26515: [PATCH] gnu: Add emacs-calfw.

[Vasile Dumitrascu]

* gnu/packages/emacs.scm (emacs-calfw): New variable.
---
 gnu/packages/emacs.scm | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)

diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index 976ea31e0..aa7d21dbc 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -1207,6 +1207,26 @@ writing input files for TeX, LaTeX, ConTeXt, Texinfo, and docTeX using Emacs
 or XEmacs.")
     (license license:gpl3+)))
 
+(define-public emacs-calfw
+  (package
+    (name "emacs-calfw")
+    (version "1.5")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append
+             "https://github.com/kiwanami/emacs-calfw/archive/v"
+             version ".tar.gz"))
+       (sha256
+        (base32
+         "17ssg8gx66yp63nhygjq2r6kgl4h45cacmrxsxs9f0lrfcx37k0l"))))
+    (build-system emacs-build-system)
+    (home-page "https://elpa.gnu.org/packages/aggressive-indent.html")
+    (synopsis "Calendar framework for Emacs")
+    (description
+     "This program displays a calendar view in the Emacs buffer.")
+    (license license:gpl3+)))
+
 (define-public emacs-mmm-mode
   (package
     (name "emacs-mmm-mode")
-- 
2.11.0

bug#26515: Acknowledgement ([PATCH] gnu: Add emacs-calfw.)

[Vasile Dumitrascu]

[-- Attachment #1: Type: text/plain, Size: 799 bytes --]

   Hi

I have added a small correction on the homepage for calfw, as I forgot
to update the Url from the code stub I have used.
  Thank you,

  Vasile

GNU bug Tracking System:
> Thank you for filing a new bug report with debbugs.gnu.org.
> 
> This is an automatically generated reply to let you know your message
> has been received.
> 
> Your message is being forwarded to the package maintainers and other
> interested parties for their attention; they will reply in due course.
> 
> Your message has been sent to the package maintainer(s):
>  guix-patches@gnu.org
> 
> If you wish to submit further information on this problem, please
> send it to 26515@debbugs.gnu.org.
> 
> Please do not send mail to help-debbugs@gnu.org unless you wish
> to report a problem with the Bug-tracking system.
> 

[-- Attachment #2: 0001-gnu-emacs-calfw-Homepage-correction.patch --]
[-- Type: text/x-patch, Size: 973 bytes --]

From 0f1d9e797853a59767190b2f55907769f4837255 Mon Sep 17 00:00:00 2001
From: Vasile Dumitrascu <va511e@yahoo.com>
Date: Sat, 15 Apr 2017 16:32:55 +0200
Subject: [PATCH] gnu: emacs-calfw: Homepage correction.

* gnu/packages/emacs.scm (emacs-calfw): Homepage correction.
[home-page]: Update homepage.
---
 gnu/packages/emacs.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index aa7d21dbc..4d420037c 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -1221,7 +1221,7 @@ or XEmacs.")
         (base32
          "17ssg8gx66yp63nhygjq2r6kgl4h45cacmrxsxs9f0lrfcx37k0l"))))
     (build-system emacs-build-system)
-    (home-page "https://elpa.gnu.org/packages/aggressive-indent.html")
+    (home-page "https://github.com/kiwanami/emacs-calfw/")
     (synopsis "Calendar framework for Emacs")
     (description
      "This program displays a calendar view in the Emacs buffer.")
-- 
2.11.0

bug#26515: Acknowledgement ([PATCH] gnu: Add emacs-calfw.)

[Alex Kost]

Vasile Dumitrascu (2017-04-15 14:37 +0000) wrote:

>    Hi
>
> I have added a small correction on the homepage for calfw, as I forgot
> to update the Url from the code stub I have used.

Applied¹, thanks!  Next time, if you have corrections to your original
patch, please send an updated patch instead of the new patch build on
top of the original one.

Note that "guix lint emacs-calfw" reports:

  gnu/packages/emacs.scm:1200:5: emacs-calfw@1.5: the source file name should contain the package name

This means the source origin should contain:

  (file-name (string-append name "-" version ".tar.gz"))

Otherwise, the downloaded tarball will have the following name in the
store (this is often the case with github tagged releases):

   /gnu/store/...-v1.5.tar.gz

while we prefer

   /gnu/store/...-emacs-calfw-1.5.tar.gz


Finally, I see that for some additional features, this package require
'howm' and 'google-maps' emacs packages, so these features won't work;
but you probably know about it.

¹ http://git.savannah.gnu.org/cgit/guix.git/commit/?id=36890436710032d6c731e31becf6a5bd7aa4afaf

-- 
Alex

bug#26515: Acknowledgement ([PATCH] gnu: Add emacs-calfw.)

[Vasile Dumitrascu]

  Hi

  I did miss the linter warning, regarding the tarball name, sorry for that.

  I will prepare packages for 'howm' and 'google-maps', in order not to
leave the calfw only partially working, and I will send the patches asap.

  Thank you for the observations,

   Vasile

Alex Kost:
> Vasile Dumitrascu (2017-04-15 14:37 +0000) wrote:
> 
>>    Hi
>>
>> I have added a small correction on the homepage for calfw, as I forgot
>> to update the Url from the code stub I have used.
> 
> Applied¹, thanks!  Next time, if you have corrections to your original
> patch, please send an updated patch instead of the new patch build on
> top of the original one.
> 
> Note that "guix lint emacs-calfw" reports:
> 
>   gnu/packages/emacs.scm:1200:5: emacs-calfw@1.5: the source file name should contain the package name
> 
> This means the source origin should contain:
> 
>   (file-name (string-append name "-" version ".tar.gz"))
> 
> Otherwise, the downloaded tarball will have the following name in the
> store (this is often the case with github tagged releases):
> 
>    /gnu/store/...-v1.5.tar.gz
> 
> while we prefer
> 
>    /gnu/store/...-emacs-calfw-1.5.tar.gz
> 
> 
> Finally, I see that for some additional features, this package require
> 'howm' and 'google-maps' emacs packages, so these features won't work;
> but you probably know about it.
> 
> ¹ http://git.savannah.gnu.org/cgit/guix.git/commit/?id=36890436710032d6c731e31becf6a5bd7aa4afaf
> 

bug#26515: [PATCH] gnu: Add emacs-calfw.

[Ludovic Courtès]

Vasile Dumitrascu <va511e@yahoo.com> skribis:

> * gnu/packages/emacs.scm (emacs-calfw): New variable.

I addressed the file name warning reported by ‘guix lint’ and committed.

Thanks!

Ludo’.

bug#26515: [PATCH] gnu: Add emacs-calfw.

[Vasile Dumitrascu]

  Hi Ludovic

 I did miss the linter tarball name warning. Sorry for that and thanks
for the correction,

   Vasile

Ludovic Courtès:
> Vasile Dumitrascu <va511e@yahoo.com> skribis:
> 
>> * gnu/packages/emacs.scm (emacs-calfw): New variable.
> 
> I addressed the file name warning reported by ‘guix lint’ and committed.
> 
> Thanks!
> 
> Ludo’.
>