From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id oBCuHjWwdWZ/xwAA62LTzQ:P1 (envelope-from ) for ; Fri, 21 Jun 2024 16:54:13 +0000 Received: from aspmx1.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1.migadu.com with LMTPS id oBCuHjWwdWZ/xwAA62LTzQ (envelope-from ) for ; Fri, 21 Jun 2024 18:54:13 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=posteo.net header.s=2017 header.b=S+WOOoTr; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (strict)" header.from=posteo.net (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1718988853; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=5w7Y2tcQtUN8ageKmj0EhDt54+BdXkrl1RO3e4MVtfA=; b=LpLxwtbP6nWJasF7DkRRnW5gtzhg8gpjcVoR4+yG6xabtw04RBDqecjoRzdQ6Tn0MYCM6H 9jrA3jHn7/ZLh7HAlb/53J3VVAV9IhiRo9PKMuAmTmIAt9XIeZ5WL+yLZ88bC6ZU+jfQn5 iqtbWP9/ZikdlB/B3fZqVimcKrYCiBFtxtk4NqGnbcKYqSOmDIAEircC9YbDxDr9LShbS7 buSwTujVAiJFQPKLAX7UT8aE2lDCF16LEKhPoUI0oWAjRhqASpJig9UKufuVT5x1VT3xUk AGdIJkQTAju+56Q/GMgwWFnH/u8u2X4+/hKOERFgUK21kw3eAP89Pq8aC0VCIQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=posteo.net header.s=2017 header.b=S+WOOoTr; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (strict)" header.from=posteo.net (policy=none) ARC-Seal: i=1; s=key1; d=yhetil.org; t=1718988853; a=rsa-sha256; cv=none; b=bJKtdhQCV4iTVPInGGCJTQjXTELGsnn6pouPp1McjOR+ZgJGS0BVIdegcxhzGG7qOzMKJ7 ZHeCjG1cEkhPG/M1z1VBbc4dHoZSBJEMqSsP4d9SvpX6chVGgkaRTpyHaMc+Rxr/F7EZhj oxg31lX2+rj3jZH2KE5ki2Du1ULjzWdYQJqHXHIRy/wKrmIHmwx8XtpTJEdS3ZfqKtPqV+ cwd1ntAKE6bsdDZrcBXhatbxop4plU+wGCDuagz621YJwgJr+ahGJDxzzaOU0tNB023s8a 0GZoN6XIqRSuH+hNj5ymvLkl/hyUHGDRPJjNJaMCtzFM1du3he08WIVlNMYzug== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 536B2263AB for ; Fri, 21 Jun 2024 18:54:13 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sKhWY-0007uu-OB; Fri, 21 Jun 2024 12:54:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sKhWU-0007uA-W8 for guix-patches@gnu.org; Fri, 21 Jun 2024 12:54:03 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sKhWU-0001U0-Nq for guix-patches@gnu.org; Fri, 21 Jun 2024 12:54:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sKhWT-0001KY-Qa for guix-patches@gnu.org; Fri, 21 Jun 2024 12:54:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#71659] [PATCH] gnu: Add fastfetch. Resent-From: Dariqq Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 21 Jun 2024 16:54:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71659 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Richard Sent Cc: 71659@debbugs.gnu.org Received: via spool by 71659-submit@debbugs.gnu.org id=B71659.17189888405107 (code B ref 71659); Fri, 21 Jun 2024 16:54:01 +0000 Received: (at 71659) by debbugs.gnu.org; 21 Jun 2024 16:54:00 +0000 Received: from localhost ([127.0.0.1]:43201 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sKhWR-0001KI-Sy for submit@debbugs.gnu.org; Fri, 21 Jun 2024 12:54:00 -0400 Received: from mout02.posteo.de ([185.67.36.66]:38423) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sKhWP-0001K4-BH for 71659@debbugs.gnu.org; Fri, 21 Jun 2024 12:53:58 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 3910E240103 for <71659@debbugs.gnu.org>; Fri, 21 Jun 2024 12:56:45 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1718967405; bh=xFBAHP7y6+/KOcU8spYF5yy+C0LBlnkSLU9BVkwBNLA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:From:Content-Type: Content-Transfer-Encoding:From; b=S+WOOoTrb+voqci59+viU9YqcZbXmXfz72+ItcBNXDj6FWpm5CmJD0/0iktAU0+nV UdI6YwfuCdncqq1y7ghwMFgk3ATT7PG+PGzHfyw3U23wGku8mIsrwynAVJVKew+JRx WlwHZ+FwDlsYFxOULVY9PW939IWv0XmYbn4+P3E4fVNou3PzfKp4q1ffEeEVLI4+Nh gIqK/USgrP+PoBCKsjMlcU+mpvu2ntEaIw6+UExCgLwHNhQlKXfiAxmwFwv5Tfp5j/ xODcyZ4k97ETKbRYUMDQRV8yCl48oX04u1OoocWXTs2aCUsZH8A2CgiPvA3fHTSZub H1IaQxpYdKpYw== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4W5DnS22DPz9rxD; Fri, 21 Jun 2024 12:56:44 +0200 (CEST) Message-ID: <0d3dc221-8675-4662-9378-5ad00498eadd@posteo.net> Date: Fri, 21 Jun 2024 10:56:41 +0000 MIME-Version: 1.0 References: <22c0522a-858c-48cc-91f6-c744d95af042@posteo.net> <87r0crr4ex.fsf@freakingpenguin.com> <87jzijqx9c.fsf@freakingpenguin.com> Content-Language: en-US From: Dariqq In-Reply-To: <87jzijqx9c.fsf@freakingpenguin.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Spam-Score: 2.44 X-Migadu-Queue-Id: 536B2263AB X-Migadu-Scanner: mx10.migadu.com X-Migadu-Spam-Score: 2.44 X-TUID: PW6DXxJH6E7v Hi Richard, I have just reported the LM detection issue upstream. So hopefully it will be fixed soon and we can ignore it in the guix package. On 20.06.24 20:34, Richard Sent wrote: > > I agree, I think this package would benefit from a -minimal version or > some similar structure with variants. > A minimal version sounds like a great idea and would be easy to customize by just adding the relevant packages. The question then becomes which features to include in a minimal build. Afaik apart from hwdata and libdrm (for specifying the custom paths) none are really required. The upstream wiki has some infos what is used for what. Apart from libdrm is there anything is there a feature you'd think that should be included in a -minimal version? >> network-manager > > I wonder if adding the network-manager plugin can cause issues on > systems that don't use it. (e.g. connman). I'd be a little worried > they'd start fighting. > Great catch. I havent even thought about this being an issue as i have only ever been using %desktop-services. It feels like there are a lot of things that have (explicit or implicit) assumptions on the system being used. - LM : logind - Music: dbus - Wifi: networkmanager - maybe more. >>> Is there anything I can help with? >> >> I have built with "-DBINARY_LINK_TYPE=dynamic" to dynamically link the >> dependencies instead. There was an error due to fastfetch wanting a >> newer version of ddcutil. Havent looked into how complicated that is to >> update yet. >> >> On a related note dynamically linking would avoid the (kind of awkward) >> wrapper. Are there benefits/downsides to using that instead? > > I'm no expert but dynamic linking sounds like a better solution to me > than a wrapper + dlopen. Disabling runtime linking seems to be a > semi-common thing in packages. Maybe we'll get lucky and ddcutil can be > updated without any breakages. > >> I hope the formating turned out ok for the code blocks > > Looks great. > Slightly related: What do you think of the current guix package detection? As it is not really comparable to package count in other distributions. My first implementation (in 2.14.0) is just counting lines in the output of "guix package -I" which only counts packages explicitly installed. As that was kind of slow I rewrote it (as of 2.15) to count unique /gnu/store/* entries in the profile manifest files (e.g. /run/current-system/profile/manifest) directly with C which also counts propagated inputs and ignores the lisy syntax of the file. The nix package detection parses the (nix equivalent) of "guix gc -R $(realpath PROFILE)" which gives counts similiar to other systems but was even slower and I haven't thought about a good way to filter out packages from the list (as there are also things like the computed info-dir , etc in there) The nix implementation sidesteps the slowness problem by caching results. I thought about using libguile directly but this is above my C and guile knowledge. Have a nice day, Dariqq