From: Liliana Marie Prikler <liliana.prikler@gmail.com>
To: "(" <paren@disroot.org>, 56286@debbugs.gnu.org
Subject: [bug#56286] [PATCH 3/3] gnu: Add pkgconf.
Date: Tue, 28 Jun 2022 21:13:21 +0200 [thread overview]
Message-ID: <0d359aa389bbeae5cc6852067c995286e0cc3922.camel@gmail.com> (raw)
In-Reply-To: <20220628180831.9792-3-paren@disroot.org>
Am Dienstag, dem 28.06.2022 um 19:08 +0100 schrieb (:
> Note that this package produces a `guix lint` warning that is
> basically unfixable:
>
> ```
> /home/paren/code/guix/gnu/packages/pkg-config.scm:213:16:
> pkgconf@1.8.0-0.b0802cb: TLS certificate error: X.509 server
> certificate
> for 'pkgconf.org' does not match:
> C=US,ST=California,L=San Francisco,O=GitHub\, Inc.,CN=*.github.com
> ```
>
> This is because pkgconf.org is actually hosted via Github Pages.
Note that plain HTTP works :)
> * gnu/packages/pkg-config.scm (pkgconf): New variable.
> ---
> gnu/packages/pkg-config.scm | 48
> +++++++++++++++++++++++++++++++++++++
> 1 file changed, 48 insertions(+)
>
> diff --git a/gnu/packages/pkg-config.scm b/gnu/packages/pkg-
> config.scm
> index dcd6ba3353..8c826ca25d 100644
> --- a/gnu/packages/pkg-config.scm
> +++ b/gnu/packages/pkg-config.scm
> @@ -24,9 +24,11 @@ (define-module (gnu packages pkg-config)
> #:use-module (guix build-system gnu)
> #:use-module (guix download)
> #:use-module (guix gexp)
> + #:use-module (guix git-download)
> #:use-module ((guix licenses) #:prefix license:)
> #:use-module (guix memoization)
> #:use-module (guix packages)
> + #:use-module (gnu packages autotools)
> #:use-module (gnu packages bash)
> #:export (pkg-config))
>
> @@ -168,3 +170,49 @@ (define where (string-append #$output "/bin/pkg-
> config"))
> (inherit original)
> (variable "PKG_CONFIG_PATH_FOR_BUILD")))
> (package-native-search-paths %pkg-config)))))
> +
> +(define-public pkgconf
> + ;; The last release was tagged on 2021-07-25, and there's been a
> lot of activity
> + ;; since then.
> + (let ((commit "b0802cb3d19b5b963ad20eed464a2da6e7d7b0b5")
> + (revision "0"))
> + (package
> + (name "pkgconf")
> + (version (git-version "1.8.0" revision commit))
> + (source (origin
> + (method git-fetch)
> + (uri (git-reference
> + (url "https://github.com/pkgconf/pkgconf")
> + (commit commit)))
> + (file-name (git-file-name name version))
> + (sha256
> + (base32
> +
> "1xcpvzahrp34jhdfsazdhbj9byr2wqwmjx7jfarhpc1x4z3l37a0"))))
> + (build-system gnu-build-system)
> + (arguments
> + ;; Kyua, which pkgconf uses for testing, is not packaged in
> Guix,
> + ;; though it should be trivial to add; the problem is that it
> "cannot
> + ;; find test programs" that it needs when run during this
> package's
> + ;; check phase.
> + ;;
Did you try running check after install? That is often required by
package which don't do pre-inst-env well.
> + ;; The silver lining is that omitting Kyua means we drop
> dependencies
> + ;; on pkg-config, Lua, and C++. It does not, in fact, seem as
> if the
> + ;; tests are even supposed to be run by anyone but the pkgconf
> + ;; developers, as <https://pkgconf.org> touts pkgconf's
> dependency-free
> + ;; nature as an advantage over pkg-config.
I think this is a misinterpretation on your part or a confusing wording
on theirs. Basically, pkgconf does not *link* against any "huge"
binary, so it's fine. Never mind that glib is a sane dependency to
have or that it also complains about pkg-config's license, which is
most meaningless in the context of tools you invoke at build time.
> + (list #:tests? #f))
> + (native-inputs (list ;; pkgconf's autotools setup forbids the
> use of any
> + ;; earlier version of autoconf than 2.71.
> + autoconf-2.71
> + automake
> + libtool))
> + (native-search-paths
> + (list (search-path-specification
> + (variable "PKG_CONFIG_PATH")
> + (files '("lib/pkgconfig" "lib64/pkgconfig"
> "share/pkgconfig")))))
I'm not sure if we want to provide $PKG_CONFIG_PATH as a variable, but
there's at least two definitions within the same file now :)
> + (home-page "https://pkgconf.org")
> + (synopsis "Package compiler and linker metadata toolkit")
> + (description "@code{pkgconf} is a compiler and linker
> configuration toolkit,
> +mostly compatible with freedesktop.org's @code{pkg-config}. A
> library called
> +@code{libpkgconf} is provided so that programs can embed its
> functionality.")
> + (license license:isc))))
Cheers
next prev parent reply other threads:[~2022-06-28 19:14 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-28 17:41 [bug#56286] [PATCHSET] Add pkgconf ( via Guix-patches via
2022-06-28 18:08 ` [bug#56286] [PATCH 1/3] gnu: pkg-config: Qualify import of (guix licenses) ( via Guix-patches via
2022-06-28 18:08 ` [bug#56286] [PATCH 2/3] gnu: pkg-config: Rearrange imports ( via Guix-patches via
2022-06-28 18:08 ` [bug#56286] [PATCH 3/3] gnu: Add pkgconf ( via Guix-patches via
2022-06-28 19:13 ` Liliana Marie Prikler [this message]
2022-06-28 19:20 ` ( via Guix-patches via
2022-06-28 19:45 ` Liliana Marie Prikler
2022-06-28 19:46 ` Liliana Marie Prikler
2022-06-28 20:14 ` ( via Guix-patches via
2022-06-28 20:34 ` [bug#56286] [PATCH v2 1/6] gnu: Add atf ( via Guix-patches via
2022-06-28 20:34 ` [bug#56286] [PATCH v2 2/6] gnu: Add lutok ( via Guix-patches via
2022-06-28 20:34 ` [bug#56286] [PATCH v2 3/6] gnu: Add kyua ( via Guix-patches via
2022-06-28 20:34 ` [bug#56286] [PATCH v2 4/6] gnu: pkg-config: Qualify import of (guix licenses) ( via Guix-patches via
2022-06-28 20:34 ` [bug#56286] [PATCH v2 5/6] gnu: pkg-config: Rearrange imports ( via Guix-patches via
2022-06-28 20:34 ` [bug#56286] [PATCH v2 6/6] gnu: Add pkgconf ( via Guix-patches via
2022-06-28 23:34 ` Maxime Devos
2022-06-29 5:41 ` ( via Guix-patches via
2022-08-03 16:21 ` Efraim Flashner
2023-09-02 3:28 ` Vagrant Cascadian
2024-02-26 16:06 ` bug#56286: Add kyua, lutok, atf Maxim Cournoyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0d359aa389bbeae5cc6852067c995286e0cc3922.camel@gmail.com \
--to=liliana.prikler@gmail.com \
--cc=56286@debbugs.gnu.org \
--cc=paren@disroot.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).